WordPress.org

Make WordPress Core

#47502 closed defect (bug) (fixed)

Media modal bottom toolbar cuts-off content in Internet Explorer 11

Reported by: afercia Owned by: afercia
Milestone: 5.2.3 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-screenshots has-patch fixed-major needs-testing dev-feedback 2nd-opinion
Focuses: ui, accessibility Cc:

Description

Please refer to the attached screenshot.

With Internet Explorer 11, the content of the bottom toolbar in the modal is not fully operable: links are partially hidden. Minor: the "Insert" button bottom part is hidden.

Quickly checking, seems to me it's related to the bottom bar height set to auto for some reason. A proper fix would need to investigate a bit why this CSS property was set and if it affects something else.

Attachments (5)

IE 11 bottom selection toolbar.png (39.8 KB) - added by afercia 2 months ago.
47502.diff (152.7 KB) - added by mspatovaliyski 2 months ago.
47502.2.diff (152.7 KB) - added by mspatovaliyski 2 months ago.
47502 IE 11 CSS initial.png (79.6 KB) - added by afercia 2 months ago.
Internet Explorer 11 thinking the initial value is invalid.
47502.3.diff (428 bytes) - added by afercia 2 months ago.

Download all attachments as: .zip

Change History (16)

#1 @mspatovaliyski
2 months ago

  • Keywords needs-testing added

This should address the cutout for the media editor in IE11. The "initial" property is not a valid one for IE

#2 @afercia
2 months ago

  • Keywords has-patch added
  • Owner set to afercia
  • Status changed from new to assigned

#3 @afercia
2 months ago

  • Keywords needs-testing removed

@mspatovaliyski thanks for your patch! Indeed, Internet Explorer 11 doesn't understand the initial value. Tested on a Windows machine with native IE 11 and your suggested fix solves the issue without side effects.

Introduced in [40428] / #40152.

Aside: there's no need to modify the minified and .rtl files, they are generated automatically during the build process :)

@afercia
2 months ago

Internet Explorer 11 thinking the initial value is invalid.

@afercia
2 months ago

#4 @afercia
2 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45526:

Media: Make sure the bottom media toolbar content is fully visible with Internet Explorer 11.

Props mspatovaliyski.
Fixes #47502.

#5 @joemcgill
4 days ago

  • Keywords fixed-major added
  • Milestone changed from 5.3 to 5.2.3
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening this so it can be back-ported to the 5.2 branch.

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


3 days ago

#7 @audrasjb
3 days ago

Adding needs-testing keyword to validate if this ticket is good to land in 5.2.3 (should be ok though).

#8 @audrasjb
3 days ago

  • Keywords needs-testing added

#9 @audrasjb
3 days ago

Tested on my side against 5.2.2, but unless I'm mistaken [45526] doesn't look to apply cleanly, there should be some dependancies to previous commits.

#10 @JeffPaul
11 hours ago

  • Keywords dev-feedback 2nd-opinion added

@afercia any idea which other commit(s) this may be dependent upon? If not, probably best we move this back to 5.3 to limit risk in 5.2.3.

#11 @SergeyBiryukov
43 minutes ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 45838:

Media: Make sure the bottom media toolbar content is fully visible with Internet Explorer 11.

Props mspatovaliyski, afercia.
Merges [45526] to the 5.2 branch.
Fixes #47502.

Note: See TracTickets for help on using tickets.