WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 3 months ago

Last modified 8 weeks ago

#47561 closed defect (bug) (fixed)

Plugin: View details popup layout issue

Reported by: mukesh27 Owned by: afercia
Milestone: 5.2.3 Priority: normal
Severity: normal Version: 5.2.2
Component: Plugins Keywords: has-patch has-screenshots fixed-major
Focuses: ui Cc:
PR Number:

Description

This issue is generate in 5.2.2 when [45520] changeset is applied in #45094 ticket and committed in core. That changeset add clear: both; in wp-admin/css/common.css to fix the responsive layout after changes to the Screen Options and Help buttons position.

@afercia can you please check this?

Attachments (11)

Layout issue.png (293.7 KB) - added by mukesh27 4 months ago.
Popup Layout Issue
47561.diff (287 bytes) - added by mukesh27 4 months ago.
Patch That Fixed Popup Layout Issue
Popup After Patch Applied.png (253.7 KB) - added by mukesh27 4 months ago.
Screen Shot 2019-06-19 at 2.01.59 PM.png (28.2 KB) - added by marybaum 4 months ago.
Screen Shot 2019-06-19 at 2.16.58 PM.png (354.7 KB) - added by marybaum 4 months ago.
Screen Shot 2019-06-19 at 2.17.13 PM.png (32.4 KB) - added by marybaum 4 months ago.
47561.2.diff (526 bytes) - added by mukesh27 4 months ago.
Updated patch with absolute position and remove margin right
47561.3.diff (540 bytes) - added by audrasjb 4 months ago.
Remove wrap class from plugin modal
Capture d’écran 2019-06-24 à 10.53.18.png (322.4 KB) - added by audrasjb 4 months ago.
47561.3.diff : Remove wrap class from plugin modal
47561.4.diff (1.1 KB) - added by afercia 4 months ago.
plugin details modal.jpg (185.2 KB) - added by afercia 4 months ago.

Download all attachments as: .zip

Change History (55)

@mukesh27
4 months ago

Popup Layout Issue

@mukesh27
4 months ago

Patch That Fixed Popup Layout Issue

#1 follow-up: @SGr33n
4 months ago

Watching, I was opening the same ticket :P

#2 in reply to: ↑ 1 @mukesh27
4 months ago

@SGr33n Is attached patch resolved issue for your setup?

Replying to SGr33n:

Watching, I was opening the same ticket :P

#3 @SGr33n
4 months ago

Hi @mukesh27 No tryied yet, sorry.

#4 @mukesh27
4 months ago

  • Version set to 5.2.2

#5 @audrasjb
4 months ago

  • Keywords needs-testing needs-codex added
  • Milestone changed from Awaiting Review to 5.3
  • Priority changed from normal to high
  • Severity changed from normal to major

Hi thanks for the report, I triaged the ticket in the next major release but we'll probably need a 5.2.3.

#6 @audrasjb
4 months ago

  • Keywords needs-codex removed

#7 @marybaum
4 months ago

I've found the issue happens on every plugin page -- seems to me that we can fix this with a couple of lines of CSS to change the positioning.

#8 @marybaum
4 months ago

If we add relative positioning to the parent element, #plugin-information.content.with-banner, and absolute positioning to the element itself, we fix the issue across the board.

@mukesh27
4 months ago

Updated patch with absolute position and remove margin right

#9 @mukesh27
4 months ago

@marybaum i have update patch and it is working fine with new patch.

#10 @desrosj
4 months ago

  • Milestone changed from 5.3 to 5.2.3

#11 @earnjam
4 months ago

#47585 was marked as a duplicate.

This ticket was mentioned in Slack in #forums by clorith. View the logs.


4 months ago

#13 @afercia
4 months ago

Thanks everyone for the ticket and patches. Touching the admin CSS is... challenging, even for minor changes :)

I'd tend to think a better fix would be removing the wrap CSS class from the plugin details modal content area. wrap has some styling (margins) that are specifically meant for the admin pages main content area. It shouldn't be used in other places. The styles needed for the modal content can be set directly on #section-holder, which is used only in the plugin modal.

#14 @afercia
4 months ago

  • Owner set to afercia
  • Status changed from new to assigned

@audrasjb
4 months ago

Remove wrap class from plugin modal

@audrasjb
4 months ago

47561.3.diff : Remove wrap class from plugin modal

#15 @audrasjb
4 months ago

Both 47561.2.diff and 47561.3.diff are fixing the issue, but I think @afercia’s approach is better, since there is less risk to remove an unused class. I also tested the path on mobile and it looks fine.

#16 @mukesh27
4 months ago

@audrasjb patch working fine for me also and @afercia approach is better then others solutions

Last edited 4 months ago by mukesh27 (previous) (diff)

@afercia
4 months ago

#17 @afercia
4 months ago

  • Keywords commit added; needs-testing removed

Thanks everyone. 47561.4.diff adjusts the margins that were previously set by the wrap class, also when there's the warning notice displayed. See attached screenshot.

#18 @afercia
4 months ago

  • Priority changed from high to normal
  • Severity changed from major to normal

Note for bug gardeners: while priority and severity are, to some extent, subjective calls, high priority and major severity should be used for bugs that really make a functionality not usable or trigger a crash or a fatal error. I do realize the alarm triggered by this layout breakage but the modal content is still readable and I wouldn't call this a major breakage.

#19 @afercia
4 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45563:

Plugins: Fix the plugin details modal layout after [45520].

Props mukesh27, marybaum, audrasjb.
Fixes #47561.

#20 follow-up: @afercia
4 months ago

  • Keywords fixed-major added; commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 5.2.3 consideration.

#21 in reply to: ↑ 20 @marybaum
4 months ago

Replying to afercia:

Reopening for 5.2.3 consideration.

Love this! Anytime we can lose a div and use default positioning instead of relative / absolute on parent / child, I'm for it!

Also, thanks for the guidance on gardening!

Last edited 4 months ago by marybaum (previous) (diff)

This ticket was mentioned in Slack in #core by sergey. View the logs.


4 months ago

This ticket was mentioned in Slack in #meta by sergey. View the logs.


4 months ago

#24 @hatschiii
4 months ago

Great to see progress. So this will be fixed in 5.2.3? When will 5.2.3 be available?

#25 @shagimuratov
4 months ago

Same question. Is there a date to release 5.2.3?

#26 @garrett-eclipse
4 months ago

#47647 was marked as a duplicate.

#27 follow-up: @hatschiii
3 months ago

Any news when 5.2.3 will be available?

#28 in reply to: ↑ 27 @SergeyBiryukov
3 months ago

Replying to hatschiii:

Any news when 5.2.3 will be available?

There is no date yet, please follow https://make.wordpress.org/core/ for announcements.

This ticket was mentioned in Slack in #core by earnjam. View the logs.


3 months ago

#30 @earnjam
3 months ago

#47673 was marked as a duplicate.

#31 @remzicavdar
3 months ago

This should be fixed asap, because people notice this. In this way WP gets a bad rep.

This ticket was mentioned in Slack in #core by remzicavdar. View the logs.


3 months ago

#33 @Marius84
3 months ago

this bug it's really annoying is there any timeline to fix this?

This ticket was mentioned in Slack in #core by remzicavdar. View the logs.


3 months ago

#35 @earnjam
3 months ago

This issue is fixed in trunk. If there is a 5.2.3, then it will be included in that. If not, then it will be fixed in 5.3, which is tentatively targeted for late September/early October.

#36 @pento
3 months ago

#47736 was marked as a duplicate.

This ticket was mentioned in Slack in #core by remzicavdar. View the logs.


3 months ago

#38 @SergeyBiryukov
3 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 45666:

Plugins: Fix the plugin details modal layout after [45520].

Props mukesh27, marybaum, audrasjb.
Merges [45563] to the 5.2 branch.
Fixes #47561.

#39 @hatschiii
3 months ago

To skipp such an issue which is fixed for severall month is a shame! Many WordPress user does nor realize that the informations are there when they scroll down!

#40 follow-up: @audrasjb
3 months ago

Hi @hatschiii, thank you for following this ticket,

We are not ignoring the issue, it was committed 4 weeks ago and it will be fixed when 5.2.3 will be released.
If you want, you can also weight on the next minor release schedule: 5.2.3 planning is publicly discussed every Wednesday at 20:00 UTC in the #core Slack channel (https://make.wordpress.org/chat/) during the dev-chat meeting. You're more than welcome to join and weight on the planning if you want to.

Last edited 3 months ago by audrasjb (previous) (diff)

#41 in reply to: ↑ 40 @hatschiii
3 months ago

Replying to audrasjb:

Hi @hatschiii, thank you for following this ticket,

We are not ignoring the issue, it was committed 4 weeks ago and it will be fixed when 5.2.3 will be released.
If you want, you can also weight on the next minor release schedule: 5.2.3 planning is publicly discussed every Wednesday at 20:00 UTC in the #core Slack channel (https://make.wordpress.org/chat/) during the dev-chat meeting. You're more than welcome to join and weight on the planning if you want to.

And if you read what was discussed in the last Dev Chat Meeting last Wednesday it doesn't look like that 5.2.3 is comming. However this is a very visible bug which ist solved since several weeks. I donot understand why there is no update right now!?

#42 @Marius84
3 months ago

+1 for @hatschiii
This bug caused damage to the user experience and simply was not fixed fast. 4 weeks? Better to say 1 month.

#43 @mukesh27
8 weeks ago

#47918 was marked as a duplicate.

#44 @justinahinon
8 weeks ago

#47931 was marked as a duplicate.

Note: See TracTickets for help on using tickets.