WordPress.org

Make WordPress Core

Opened 5 weeks ago

Last modified 4 days ago

#47561 reopened defect (bug)

Plugin: View details popup layout issue

Reported by: mukesh27 Owned by: afercia
Milestone: 5.2.3 Priority: normal
Severity: normal Version: 5.2.2
Component: Plugins Keywords: has-patch has-screenshots fixed-major
Focuses: ui Cc:

Description

This issue is generate in 5.2.2 when [45520] changeset is applied in #45094 ticket and committed in core. That changeset add clear: both; in wp-admin/css/common.css to fix the responsive layout after changes to the Screen Options and Help buttons position.

@afercia can you please check this?

Attachments (11)

Layout issue.png (293.7 KB) - added by mukesh27 5 weeks ago.
Popup Layout Issue
47561.diff (287 bytes) - added by mukesh27 5 weeks ago.
Patch That Fixed Popup Layout Issue
Popup After Patch Applied.png (253.7 KB) - added by mukesh27 5 weeks ago.
Screen Shot 2019-06-19 at 2.01.59 PM.png (28.2 KB) - added by marybaum 5 weeks ago.
Screen Shot 2019-06-19 at 2.16.58 PM.png (354.7 KB) - added by marybaum 5 weeks ago.
Screen Shot 2019-06-19 at 2.17.13 PM.png (32.4 KB) - added by marybaum 5 weeks ago.
47561.2.diff (526 bytes) - added by mukesh27 5 weeks ago.
Updated patch with absolute position and remove margin right
47561.3.diff (540 bytes) - added by audrasjb 4 weeks ago.
Remove wrap class from plugin modal
Capture d’écran 2019-06-24 à 10.53.18.png (322.4 KB) - added by audrasjb 4 weeks ago.
47561.3.diff : Remove wrap class from plugin modal
47561.4.diff (1.1 KB) - added by afercia 4 weeks ago.
plugin details modal.jpg (185.2 KB) - added by afercia 4 weeks ago.

Download all attachments as: .zip

Change History (48)

@mukesh27
5 weeks ago

Popup Layout Issue

@mukesh27
5 weeks ago

Patch That Fixed Popup Layout Issue

#1 follow-up: @SGr33n
5 weeks ago

Watching, I was opening the same ticket :P

#2 in reply to: ↑ 1 @mukesh27
5 weeks ago

@SGr33n Is attached patch resolved issue for your setup?

Replying to SGr33n:

Watching, I was opening the same ticket :P

#3 @SGr33n
5 weeks ago

Hi @mukesh27 No tryied yet, sorry.

#4 @mukesh27
5 weeks ago

  • Version set to 5.2.2

#5 @audrasjb
5 weeks ago

  • Keywords needs-testing needs-codex added
  • Milestone changed from Awaiting Review to 5.3
  • Priority changed from normal to high
  • Severity changed from normal to major

Hi thanks for the report, I triaged the ticket in the next major release but we'll probably need a 5.2.3.

#6 @audrasjb
5 weeks ago

  • Keywords needs-codex removed

#7 @marybaum
5 weeks ago

I've found the issue happens on every plugin page -- seems to me that we can fix this with a couple of lines of CSS to change the positioning.

#8 @marybaum
5 weeks ago

If we add relative positioning to the parent element, #plugin-information.content.with-banner, and absolute positioning to the element itself, we fix the issue across the board.

@mukesh27
5 weeks ago

Updated patch with absolute position and remove margin right

#9 @mukesh27
5 weeks ago

@marybaum i have update patch and it is working fine with new patch.

#10 @desrosj
5 weeks ago

  • Milestone changed from 5.3 to 5.2.3

#11 @earnjam
5 weeks ago

#47585 was marked as a duplicate.

This ticket was mentioned in Slack in #forums by clorith. View the logs.


4 weeks ago

#13 @afercia
4 weeks ago

Thanks everyone for the ticket and patches. Touching the admin CSS is... challenging, even for minor changes :)

I'd tend to think a better fix would be removing the wrap CSS class from the plugin details modal content area. wrap has some styling (margins) that are specifically meant for the admin pages main content area. It shouldn't be used in other places. The styles needed for the modal content can be set directly on #section-holder, which is used only in the plugin modal.

#14 @afercia
4 weeks ago

  • Owner set to afercia
  • Status changed from new to assigned

@audrasjb
4 weeks ago

Remove wrap class from plugin modal

@audrasjb
4 weeks ago

47561.3.diff : Remove wrap class from plugin modal

#15 @audrasjb
4 weeks ago

Both 47561.2.diff and 47561.3.diff are fixing the issue, but I think @afercia’s approach is better, since there is less risk to remove an unused class. I also tested the path on mobile and it looks fine.

#16 @mukesh27
4 weeks ago

@audrasjb patch working fine for me also and @afercia approach is better then others solutions

Last edited 4 weeks ago by mukesh27 (previous) (diff)

@afercia
4 weeks ago

#17 @afercia
4 weeks ago

  • Keywords commit added; needs-testing removed

Thanks everyone. 47561.4.diff adjusts the margins that were previously set by the wrap class, also when there's the warning notice displayed. See attached screenshot.

#18 @afercia
4 weeks ago

  • Priority changed from high to normal
  • Severity changed from major to normal

Note for bug gardeners: while priority and severity are, to some extent, subjective calls, high priority and major severity should be used for bugs that really make a functionality not usable or trigger a crash or a fatal error. I do realize the alarm triggered by this layout breakage but the modal content is still readable and I wouldn't call this a major breakage.

#19 @afercia
4 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45563:

Plugins: Fix the plugin details modal layout after [45520].

Props mukesh27, marybaum, audrasjb.
Fixes #47561.

#20 follow-up: @afercia
4 weeks ago

  • Keywords fixed-major added; commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 5.2.3 consideration.

#21 in reply to: ↑ 20 @marybaum
4 weeks ago

Replying to afercia:

Reopening for 5.2.3 consideration.

Love this! Anytime we can lose a div and use default positioning instead of relative / absolute on parent / child, I'm for it!

Also, thanks for the guidance on gardening!

Last edited 4 weeks ago by marybaum (previous) (diff)

This ticket was mentioned in Slack in #core by sergey. View the logs.


4 weeks ago

This ticket was mentioned in Slack in #meta by sergey. View the logs.


4 weeks ago

#24 @hatschiii
3 weeks ago

Great to see progress. So this will be fixed in 5.2.3? When will 5.2.3 be available?

#25 @shagimuratov
3 weeks ago

Same question. Is there a date to release 5.2.3?

#26 @garrett-eclipse
3 weeks ago

#47647 was marked as a duplicate.

#27 follow-up: @hatschiii
3 weeks ago

Any news when 5.2.3 will be available?

#28 in reply to: ↑ 27 @SergeyBiryukov
2 weeks ago

Replying to hatschiii:

Any news when 5.2.3 will be available?

There is no date yet, please follow https://make.wordpress.org/core/ for announcements.

This ticket was mentioned in Slack in #core by earnjam. View the logs.


13 days ago

#30 @earnjam
12 days ago

#47673 was marked as a duplicate.

#31 @remzicavdar
12 days ago

This should be fixed asap, because people notice this. In this way WP gets a bad rep.

This ticket was mentioned in Slack in #core by remzicavdar. View the logs.


11 days ago

#33 @Marius84
9 days ago

this bug it's really annoying is there any timeline to fix this?

This ticket was mentioned in Slack in #core by remzicavdar. View the logs.


6 days ago

#35 @earnjam
6 days ago

This issue is fixed in trunk. If there is a 5.2.3, then it will be included in that. If not, then it will be fixed in 5.3, which is tentatively targeted for late September/early October.

#36 @pento
4 days ago

#47736 was marked as a duplicate.

This ticket was mentioned in Slack in #core by remzicavdar. View the logs.


4 days ago

Note: See TracTickets for help on using tickets.