Plugin: View details popup layout issue

[mukesh27]

This issue is generate in 5.2.2 when [45520] changeset is applied in #45094 ticket and committed in core. That changeset add clear: both; in wp-admin/css/common.css to fix the responsive layout after changes to the Screen Options and Help buttons position.

@afercia can you please check this?

[mukesh27]

Popup Layout Issue

[mukesh27]

Patch That Fixed Popup Layout Issue

[SGr33n]

Watching, I was opening the same ticket :P

[mukesh27]

@SGr33n Is attached patch resolved issue for your setup?

Replying to SGr33n:

Watching, I was opening the same ticket :P

[SGr33n]

Hi @mukesh27 No tryied yet, sorry.

[audrasjb]

Hi thanks for the report, I triaged the ticket in the next major release but we'll probably need a 5.2.3.

[marybaum]

I've found the issue happens on every plugin page -- seems to me that we can fix this with a couple of lines of CSS to change the positioning.

[marybaum]

If we add relative positioning to the parent element, #plugin-information.content.with-banner, and absolute positioning to the element itself, we fix the issue across the board.

[mukesh27]

Updated patch with absolute position and remove margin right

[mukesh27]

@marybaum i have update patch and it is working fine with new patch.

[earnjam]

#47585 was marked as a duplicate.

[afercia]

Thanks everyone for the ticket and patches. Touching the admin CSS is... challenging, even for minor changes :)

I'd tend to think a better fix would be removing the wrap CSS class from the plugin details modal content area. wrap has some styling (margins) that are specifically meant for the admin pages main content area. It shouldn't be used in other places. The styles needed for the modal content can be set directly on #section-holder, which is used only in the plugin modal.

[audrasjb]

Remove wrap class from plugin modal

[audrasjb]

47561.3.diff : Remove wrap class from plugin modal

[audrasjb]

Both 47561.2.diff and 47561.3.diff are fixing the issue, but I think @afercia’s approach is better, since there is less risk to remove an unused class. I also tested the path on mobile and it looks fine.

[mukesh27]

@audrasjb patch working fine for me also and @afercia approach is better then others solutions

[afercia]

Thanks everyone. 47561.4.diff​ adjusts the margins that were previously set by the wrap class, also when there's the warning notice displayed. See attached screenshot.

[afercia]

Note for bug gardeners: while ​priority and severity are, to some extent, subjective calls, high priority and major severity should be used for bugs that really make a functionality not usable or trigger a crash or a fatal error. I do realize the alarm triggered by this layout breakage but the modal content is still readable and I wouldn't call this a major breakage.

[afercia]

In 45563:

Plugins: Fix the plugin details modal layout after [45520].

Props mukesh27, marybaum, audrasjb.
Fixes #47561.

[afercia]

Reopening for 5.2.3 consideration.

[marybaum]

Replying to afercia:

Reopening for 5.2.3 consideration.

Love this! Anytime we can lose a div and use default positioning instead of relative / absolute on parent / child, I'm for it!

Also, thanks for the guidance on gardening!

[hatschiii]

Great to see progress. So this will be fixed in 5.2.3? When will 5.2.3 be available?

[shagimuratov]

Same question. Is there a date to release 5.2.3?

[garrett-eclipse]

#47647 was marked as a duplicate.

[hatschiii]

Any news when 5.2.3 will be available?

[SergeyBiryukov]

Replying to hatschiii:

Any news when 5.2.3 will be available?

There is no date yet, please follow ​https://make.wordpress.org/core/ for announcements.

[earnjam]

#47673 was marked as a duplicate.

[remzicavdar]

This should be fixed asap, because people notice this. In this way WP gets a bad rep.

[Marius84]

this bug it's really annoying is there any timeline to fix this?

[earnjam]

This issue is fixed in trunk. If there is a 5.2.3, then it will be included in that. If not, then it will be fixed in 5.3, which is tentatively targeted for late September/early October.

[pento]

#47736 was marked as a duplicate.

[SergeyBiryukov]

In 45666:

Plugins: Fix the plugin details modal layout after [45520].

Props mukesh27, marybaum, audrasjb.
Merges [45563] to the 5.2 branch.
Fixes #47561.

[hatschiii]

To skipp such an issue which is fixed for severall month is a shame! Many WordPress user does nor realize that the informations are there when they scroll down!

[audrasjb]

Hi @hatschiii, thank you for following this ticket,

We are not ignoring the issue, it was committed 4 weeks ago and it will be fixed when 5.2.3 will be released.
If you want, you can also weight on the next minor release schedule: 5.2.3 planning is publicly discussed every Wednesday at 20:00 UTC in the #core Slack channel (​https://make.wordpress.org/chat/) during the dev-chat meeting. You're more than welcome to join and weight on the planning if you want to.

[hatschiii]

Replying to audrasjb:

Hi @hatschiii, thank you for following this ticket,

We are not ignoring the issue, it was committed 4 weeks ago and it will be fixed when 5.2.3 will be released.
If you want, you can also weight on the next minor release schedule: 5.2.3 planning is publicly discussed every Wednesday at 20:00 UTC in the #core Slack channel (​https://make.wordpress.org/chat/) during the dev-chat meeting. You're more than welcome to join and weight on the planning if you want to.

And if you read what was discussed in the last Dev Chat Meeting last Wednesday it doesn't look like that 5.2.3 is comming. However this is a very visible bug which ist solved since several weeks. I donot understand why there is no update right now!?

[Marius84]

+1 for @hatschiii
This bug caused damage to the user experience and simply was not fixed fast. 4 weeks? Better to say 1 month.

[mukesh27]

#47918 was marked as a duplicate.

[justinahinon]

#47931 was marked as a duplicate.