WordPress.org

Make WordPress Core

Opened 19 months ago

Last modified 29 hours ago

#47594 accepted enhancement

Add nbsp symbol codes to convert throught sanitize_title

Reported by: hokku Owned by: SergeyBiryukov
Milestone: 5.7 Priority: normal
Severity: minor Version: 5.3
Component: Formatting Keywords: has-patch needs-unit-tests
Focuses: Cc:

Description

Default filters needs to be supplemented nbsp codes such as

[ '%e2%80%af', '%e2%80%87', '%e2%81%a0' ]

and

[ ' ', ' ', ' ', ' ', '⁠', '⁠' ]

Attachments (2)

47594.diff​ (1.7 KB) - added by adhitya03 18 months ago.
Patch
47594.1.diff​ (693 bytes) - added by audrasjb 29 hours ago.
Patch refreshed and simplified as per today's bug scrub

Download all attachments as: .zip

Change History (23)

#1 @hokku
19 months ago

  • Type changed from defect (bug) to enhancement

#2 @hokku
19 months ago

  • Summary changed from Add nbsp symbol codes to convert to sanitize_title to Add nbsp symbol codes to convert throught sanitize_title

#3 @SergeyBiryukov
19 months ago

  • Milestone changed from Awaiting Review to 5.3
  • Owner set to SergeyBiryukov
  • Status changed from new to accepted

#4 @adhitya03
18 months ago

Hi,I wanna make a patch for this but I need clarify something so I don't get it wrong.
In this case, do mean "Default filters needs to be supplemented nbsp" is to sanitize all kind of Unicode characters of SPACE to be its HTML Entity "&nbsp" ?

Last edited 18 months ago by adhitya03 (previous) (diff)

@adhitya03
18 months ago

Patch

#5 @adhitya03
18 months ago

  • Keywords has-patch added

#6 @azaozz
16 months ago

  • Keywords reporter-feedback 2nd-opinion added

I need to clarify something so I don't get it wrong.

I'm missing some context here too :)

@SergeyBiryukov are you looking at this for 5.3? I'm not sure I understand what's being fixed and why.

#7 @davidbaumwald
16 months ago

  • Milestone changed from 5.3 to Future Release

With version 5.3 Beta 1 releasing today, I'm moving this to Future Release.

#10 @SergeyBiryukov
11 months ago

  • Milestone changed from Future Release to 5.5

#11 @SergeyBiryukov
7 months ago

  • Milestone changed from 5.5 to 5.6

This ticket was mentioned in ​Slack in #core by metalandcoffee. ​View the logs.
4 months ago

#14 @hellofromTonya
4 months ago

Per Sergey during today's scrub:

Will try to address before beta, or punt otherwise.

#15 @hellofromTonya
3 months ago

  • Keywords needs-refresh added

Marking for a refresh as the patch no longer applies cleanly to trunk.

#16 @SergeyBiryukov
3 months ago

  • Milestone changed from 5.6 to 5.7

Didn't get a chance to write the tests for this in time for 5.6 Beta 1, moving to the next release for now.

This ticket was mentioned in ​Slack in #core by lukecarbis. ​View the logs.
2 weeks ago

#18 @noisysocks
2 weeks ago

  • Keywords needs-unit-tests added; reporter-feedback removed

This ticket was mentioned in ​Slack in #core by hellofromtonya. ​View the logs.
31 hours ago

@audrasjb
29 hours ago

Patch refreshed and simplified as per today's bug scrub

#20 @audrasjb
29 hours ago

  • Keywords 2nd-opinion needs-refresh removed

@hellofromTonya @SergeyBiryukov I refreshed and simplified the previous patch as per today's bug scrub.

#21 @hellofromTonya
29 hours ago

Thank you @audrasjb! I'll get the unit tests written for it. And it should be ready for commit consideration.

Note: See TracTickets for help on using tickets.