#47982 closed enhancement (fixed)
Site Health: Under version control and background updates
Reported by: | afragen | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Site Health | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Currently Site Health will give a Critical
error for background updates not working because the site is under version control.
While I do believe it should be a critical error if background updates are not able to happen, I think that being under version control shouldn't push that to an error. Any site owner should know if their site is under version control.
Attachments (3)
Change History (14)
#2
@
5 years ago
- Keywords has-patch added; needs-patch removed
This patch moves the error from fail to warning when version control is detected for background updates. It doesn't effect any of the other checks for background updates.
This ticket was mentioned in Slack in #core by afragen. View the logs.
5 years ago
This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.
5 years ago
#6
@
5 years ago
- Keywords commit added
Tested this, and it looks good to move forward. See screenshot above.
#7
@
5 years ago
There are two messages when version control is detected for background updates:
- (info)
The folder %1$s was detected as being under version control (%2$s), but the %3$s filter is allowing updates.
- (fail)
The folder %1$s was detected as being under version control (%2$s).
Moving the latter from fail
to warning
makes sense to me, but why moving the former from info
to warning
?
#8
@
5 years ago
@SergeyBiryukov testing now. I can't remember right now why I changed the first info
to warning
.
#9
@
5 years ago
@SergeyBiryukov you are correct 😏
Only the second change is needed. 47982.2.diff has only this change.
Related: #46733
| - Opened upstream - https://github.com/WordPress/health-check/issues/326