WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 2 months ago

#47982 closed enhancement (fixed)

Site Health: Under version control and background updates

Reported by: afragen Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Site Health Keywords: has-patch commit
Focuses: Cc:
PR Number:

Description

Currently Site Health will give a Critical error for background updates not working because the site is under version control.

While I do believe it should be a critical error if background updates are not able to happen, I think that being under version control shouldn't push that to an error. Any site owner should know if their site is under version control.

Attachments (3)

47982.diff (726 bytes) - added by afragen 3 months ago.
site-health-version-control-warning.png (36.3 KB) - added by davidbaumwald 2 months ago.
Site Health - Version Control and Auto-Updates
47982.2.diff (499 bytes) - added by afragen 2 months ago.

Download all attachments as: .zip

Change History (13)

@afragen
3 months ago

#2 @afragen
3 months ago

  • Keywords has-patch added; needs-patch removed

This patch moves the error from fail to warning when version control is detected for background updates. It doesn't effect any of the other checks for background updates.

Last edited 3 months ago by afragen (previous) (diff)

This ticket was mentioned in Slack in #core by afragen. View the logs.


2 months ago

#4 @afragen
2 months ago

  • Milestone changed from Awaiting Review to 5.3

This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.


2 months ago

@davidbaumwald
2 months ago

Site Health - Version Control and Auto-Updates

#6 @davidbaumwald
2 months ago

  • Keywords commit added

Tested this, and it looks good to move forward. See screenshot above.

#7 @SergeyBiryukov
2 months ago

There are two messages when version control is detected for background updates:

  • (info) The folder %1$s was detected as being under version control (%2$s), but the %3$s filter is allowing updates.
  • (fail) The folder %1$s was detected as being under version control (%2$s).

Moving the latter from fail to warning makes sense to me, but why moving the former from info to warning?

#8 @afragen
2 months ago

@SergeyBiryukov testing now. I can't remember right now why I changed the first info to warning.

@afragen
2 months ago

#9 @afragen
2 months ago

@SergeyBiryukov you are correct 😏
Only the second change is needed. 47982.2.diff has only this change.

#10 @SergeyBiryukov
2 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 46281:

Site Health: Move "The folder ... was detected as being under version control" message from failure to warning.

Props afragen, davidbaumwald.
Fixes #47982.

Note: See TracTickets for help on using tickets.