WordPress.org

Make WordPress Core

Opened 9 months ago

Last modified 8 weeks ago

#48002 reviewing defect (bug)

Change HTTP URLs to HTTPS

Reported by: raajtram Owned by: audrasjb
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch needs-testing
Focuses: coding-standards Cc:

Description

A few instances whereby HTTP should be changed to HTTPS to maintain consistency

Attachments (6)

48002.diff (2.6 KB) - added by raajtram 9 months ago.
change http to https
48002.2.diff (49.5 KB) - added by passoniate 6 months ago.
some other links i changed from http to https
48002.3.diff (30.8 KB) - added by bookdude13 4 months ago.
Refreshed patch, most urls
48002.4.diff (36.8 KB) - added by bookdude13 4 months ago.
Including url updates in themes
48002.5.diff (9.3 KB) - added by sabernhardt 8 weeks ago.
without changing XML namespaces or translator comments
48002.6.diff (22.4 KB) - added by sabernhardt 7 weeks ago.
option including the updated translator comments in meta-boxes.php

Download all attachments as: .zip

Change History (17)

@raajtram
9 months ago

change http to https

#1 @jrf
8 months ago

  • Keywords commit added

Thanks @raajtram Looks good to me.

@passoniate
6 months ago

some other links i changed from http to https

#2 @passoniate
6 months ago

  • Keywords commit removed
  • Version set to trunk

#3 @SergeyBiryukov
6 months ago

  • Milestone changed from Awaiting Review to 5.4

#4 @bookdude13
4 months ago

  • Keywords needs-patch added; has-patch removed

Hey @passoniate! Thanks for your work on this so far.

The one thing I see is in wp-admin/edit-link-form.php, line 125. don&#8217;t forget the <code>http://</code>' should be updated as well.

Other than that, looks great!

#5 @passoniate
4 months ago

  • Keywords has-patch added; needs-patch removed

#6 @bookdude13
4 months ago

You changed the keywords, but I don't see an updated patch with that change. Did you forget to upload?

#7 @audrasjb
4 months ago

  • Keywords needs-refresh added
  • Owner set to audrasjb
  • Status changed from new to reviewing
  • Version trunk deleted

Hi, thanks for your work on this ticket.
However, the last patch doesn't apply cleanly on WordPress dev/trunk.

I would need a full refresh to land in 5.4.

#8 @bookdude13
4 months ago

  • Keywords needs-testing added; needs-refresh removed

Here's a refresh. Some notes

  • The other urls in export.php may be able to be changed to https as well, I'm not familiar with those sites or their use in the tag
  • The original patch included url changes in comments in the Hello Dolly theme. That seemed a little out of scope so I removed that change.
  • The .3 patch is for most of the urls, and the .4 patch adds url changes within the themes before twentynineteen which didn't use https for <link rel="profile" href="https://gmpg.org/xfn/11">. I wasn't sure if this change should be backported to those themes or what the process for that would be, so those changes are separate.

@bookdude13
4 months ago

Refreshed patch, most urls

@bookdude13
4 months ago

Including url updates in themes

#9 @audrasjb
3 months ago

  • Milestone changed from 5.4 to Future Release

Hi,

With 5.4 Beta 3 approaching and the Beta period reserved for bugs introduced during the cycle, this is being moved to Future Release. If any maintainer or committer feels this should be included or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

@sabernhardt
8 weeks ago

without changing XML namespaces or translator comments

#10 follow-up: @sabernhardt
8 weeks ago

The XML namespaces for SVG images and html tags will need to keep http:// because that is part of their official names.

Also, I doubt it's worth editing the translator comments in /wp-admin/includes/meta-boxes.php, especially after 119 languages already have those 26 strings translated. But if translation editors disagree with me, the XHTML Friends Network link in the comments could be updated quite easily in another patch.

48002.5.diff still changes these links to HTTPS:

  1. XHTML Friends Network link in wp-admin/edit-link-form.php
  2. Both parts of the Web Address example in wp-admin/edit-link-form.php (the wordpress.org link and the reminder to include https://)
  3. Twenty Twenty theme preview URL in wp-admin/includes/class-wp-theme-install-list-table.php comment
  4. Explanatory link for XFN in wp-admin/includes/meta-boxes.php
  5. The XFN profile links in every bundled theme from Twenty Ten to Twenty Seventeen, plus wp-includes/theme-compat/header.php

#11 in reply to: ↑ 10 @SergeyBiryukov
8 weeks ago

Replying to sabernhardt:

Also, I doubt it's worth editing the translator comments in /wp-admin/includes/meta-boxes.php, especially after 119 languages already have those 26 strings translated. But if translation editors disagree with me, the XHTML Friends Network link in the comments could be updated quite easily in another patch.

Just to clarify, changing translator comments does not invalidate existing translations.

@sabernhardt
7 weeks ago

option including the updated translator comments in meta-boxes.php

Note: See TracTickets for help on using tickets.