Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#48002 closed defect (bug) (fixed)

Change HTTP URLs to HTTPS

Reported by: raajtram's profile raajtram Owned by: audrasjb's profile audrasjb
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch commit
Focuses: coding-standards Cc:

Description

A few instances whereby HTTP should be changed to HTTPS to maintain consistency

Attachments (8)

48002.diff (2.6 KB) - added by raajtram 5 years ago.
change http to https
48002.2.diff (49.5 KB) - added by passoniate 4 years ago.
some other links i changed from http to https
48002.3.diff (30.8 KB) - added by bookdude13 4 years ago.
Refreshed patch, most urls
48002.4.diff (36.8 KB) - added by bookdude13 4 years ago.
Including url updates in themes
48002.5.diff (9.3 KB) - added by sabernhardt 4 years ago.
without changing XML namespaces or translator comments
48002.6.diff (22.4 KB) - added by sabernhardt 4 years ago.
option including the updated translator comments in meta-boxes.php
48002.bundled-themes.diff (5.3 KB) - added by sabernhardt 4 years ago.
Editing only the bundled themes' header profile links (Twenty Ten to Twenty Seventeen)
48002.7.diff (22.6 KB) - added by audrasjb 4 years ago.
Patch refreshed

Download all attachments as: .zip

Change History (27)

@raajtram
5 years ago

change http to https

#1 @jrf
5 years ago

  • Keywords commit added

Thanks @raajtram Looks good to me.

@passoniate
4 years ago

some other links i changed from http to https

#2 @passoniate
4 years ago

  • Keywords commit removed
  • Version set to trunk

#3 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 5.4

#4 @bookdude13
4 years ago

  • Keywords needs-patch added; has-patch removed

Hey @passoniate! Thanks for your work on this so far.

The one thing I see is in wp-admin/edit-link-form.php, line 125. don&#8217;t forget the <code>http://</code>' should be updated as well.

Other than that, looks great!

#5 @passoniate
4 years ago

  • Keywords has-patch added; needs-patch removed

#6 @bookdude13
4 years ago

You changed the keywords, but I don't see an updated patch with that change. Did you forget to upload?

#7 @audrasjb
4 years ago

  • Keywords needs-refresh added
  • Owner set to audrasjb
  • Status changed from new to reviewing
  • Version trunk deleted

Hi, thanks for your work on this ticket.
However, the last patch doesn't apply cleanly on WordPress dev/trunk.

I would need a full refresh to land in 5.4.

#8 @bookdude13
4 years ago

  • Keywords needs-testing added; needs-refresh removed

Here's a refresh. Some notes

  • The other urls in export.php may be able to be changed to https as well, I'm not familiar with those sites or their use in the tag
  • The original patch included url changes in comments in the Hello Dolly theme. That seemed a little out of scope so I removed that change.
  • The .3 patch is for most of the urls, and the .4 patch adds url changes within the themes before twentynineteen which didn't use https for <link rel="profile" href="https://gmpg.org/xfn/11">. I wasn't sure if this change should be backported to those themes or what the process for that would be, so those changes are separate.

@bookdude13
4 years ago

Refreshed patch, most urls

@bookdude13
4 years ago

Including url updates in themes

#9 @audrasjb
4 years ago

  • Milestone changed from 5.4 to Future Release

Hi,

With 5.4 Beta 3 approaching and the Beta period reserved for bugs introduced during the cycle, this is being moved to Future Release. If any maintainer or committer feels this should be included or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

@sabernhardt
4 years ago

without changing XML namespaces or translator comments

#10 follow-up: @sabernhardt
4 years ago

The XML namespaces for SVG images and html tags will need to keep http:// because that is part of their official names.

Also, I doubt it's worth editing the translator comments in /wp-admin/includes/meta-boxes.php, especially after 119 languages already have those 26 strings translated. But if translation editors disagree with me, the XHTML Friends Network link in the comments could be updated quite easily in another patch.

48002.5.diff still changes these links to HTTPS:

  1. XHTML Friends Network link in wp-admin/edit-link-form.php
  2. Both parts of the Web Address example in wp-admin/edit-link-form.php (the wordpress.org link and the reminder to include https://)
  3. Twenty Twenty theme preview URL in wp-admin/includes/class-wp-theme-install-list-table.php comment
  4. Explanatory link for XFN in wp-admin/includes/meta-boxes.php
  5. The XFN profile links in every bundled theme from Twenty Ten to Twenty Seventeen, plus wp-includes/theme-compat/header.php

#11 in reply to: ↑ 10 @SergeyBiryukov
4 years ago

Replying to sabernhardt:

Also, I doubt it's worth editing the translator comments in /wp-admin/includes/meta-boxes.php, especially after 119 languages already have those 26 strings translated. But if translation editors disagree with me, the XHTML Friends Network link in the comments could be updated quite easily in another patch.

Just to clarify, changing translator comments does not invalidate existing translations.

@sabernhardt
4 years ago

option including the updated translator comments in meta-boxes.php

@sabernhardt
4 years ago

Editing only the bundled themes' header profile links (Twenty Ten to Twenty Seventeen)

#12 @sabernhardt
4 years ago

Related support topic about changing the profile link in Twenty Sixteen

I uploaded another option that only edits the bundled theme files, in case those need to be backported (and/or other changes are not desired). If it's better to address the themes on a separate ticket, I could re-upload the patch there.

#13 @SergeyBiryukov
4 years ago

  • Milestone changed from Future Release to 5.5

@audrasjb
4 years ago

Patch refreshed

#14 @audrasjb
4 years ago

  • Keywords needs-testing removed

Hi,

I refreshed the patch against trunk. Let's add commit workflow keyword as the patch is pretty straightforward.

#15 @audrasjb
4 years ago

  • Keywords commit added

#16 @SergeyBiryukov
4 years ago

In 48289:

General: Use HTTPS for the Web Address field example on Edit Link screen.

Props raajtram, jrf, passoniate, bookdude13, sabernhardt, audrasjb.
See #48002.

#17 @SergeyBiryukov
4 years ago

In 48290:

Bundled Themes: Use HTTPS for XHTML Friends Network URL.

Props raajtram, jrf, passoniate, bookdude13, sabernhardt, audrasjb.
See #48002.

#18 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 48292:

Administration: Use HTTPS for XHTML Friends Network URL.

Props raajtram, jrf, passoniate, bookdude13, sabernhardt, audrasjb.
Fixes #48002.

#19 @sabernhardt
4 years ago

#44011 was marked as a duplicate.

Note: See TracTickets for help on using tickets.