#48002 closed defect (bug) (fixed)
Change HTTP URLs to HTTPS
Reported by: | raajtram | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 5.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | General | Keywords: | has-patch commit |
Focuses: | coding-standards | Cc: |
Description
A few instances whereby HTTP should be changed to HTTPS to maintain consistency
Attachments (8)
Change History (27)
#4
@
5 years ago
- Keywords needs-patch added; has-patch removed
Hey @passoniate! Thanks for your work on this so far.
The one thing I see is in wp-admin/edit-link-form.php
, line 125. don’t forget the <code>http://</code>'
should be updated as well.
Other than that, looks great!
#6
@
5 years ago
You changed the keywords, but I don't see an updated patch with that change. Did you forget to upload?
#7
@
5 years ago
- Keywords needs-refresh added
- Owner set to audrasjb
- Status changed from new to reviewing
- Version trunk deleted
Hi, thanks for your work on this ticket.
However, the last patch doesn't apply cleanly on WordPress dev/trunk.
I would need a full refresh to land in 5.4.
#8
@
5 years ago
- Keywords needs-testing added; needs-refresh removed
Here's a refresh. Some notes
- The other urls in export.php may be able to be changed to https as well, I'm not familiar with those sites or their use in the tag
- The original patch included url changes in comments in the Hello Dolly theme. That seemed a little out of scope so I removed that change.
- The .3 patch is for most of the urls, and the .4 patch adds url changes within the themes before twentynineteen which didn't use https for
<link rel="profile" href="https://gmpg.org/xfn/11">
. I wasn't sure if this change should be backported to those themes or what the process for that would be, so those changes are separate.
#9
@
5 years ago
- Milestone changed from 5.4 to Future Release
Hi,
With 5.4 Beta 3 approaching and the Beta period reserved for bugs introduced during the cycle, this is being moved to Future Release. If any maintainer or committer feels this should be included or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.
#10
follow-up:
↓ 11
@
5 years ago
The XML namespaces for SVG images and html
tags will need to keep http://
because that is part of their official names.
Also, I doubt it's worth editing the translator comments in /wp-admin/includes/meta-boxes.php
, especially after 119 languages already have those 26 strings translated. But if translation editors disagree with me, the XHTML Friends Network link in the comments could be updated quite easily in another patch.
48002.5.diff still changes these links to HTTPS:
- XHTML Friends Network link in
wp-admin/edit-link-form.php
- Both parts of the Web Address example in
wp-admin/edit-link-form.php
(the wordpress.org link and the reminder to includehttps://
) - Twenty Twenty theme preview URL in
wp-admin/includes/class-wp-theme-install-list-table.php
comment - Explanatory link for XFN in
wp-admin/includes/meta-boxes.php
- The XFN profile links in every bundled theme from Twenty Ten to Twenty Seventeen, plus
wp-includes/theme-compat/header.php
#11
in reply to:
↑ 10
@
5 years ago
Replying to sabernhardt:
Also, I doubt it's worth editing the translator comments in
/wp-admin/includes/meta-boxes.php
, especially after 119 languages already have those 26 strings translated. But if translation editors disagree with me, the XHTML Friends Network link in the comments could be updated quite easily in another patch.
Just to clarify, changing translator comments does not invalidate existing translations.
@
4 years ago
Editing only the bundled themes' header profile links (Twenty Ten to Twenty Seventeen)
#12
@
4 years ago
Related support topic about changing the profile link in Twenty Sixteen
I uploaded another option that only edits the bundled theme files, in case those need to be backported (and/or other changes are not desired). If it's better to address the themes on a separate ticket, I could re-upload the patch there.
change http to https