Default Theme pages content should use blocks

[garrett-eclipse]

Hello,

Testing with Twenty Twenty you get the home, about, contact and blog pages setup for you as they're specified in the starter content here;
​https://github.com/WordPress/twentytwenty/blob/a2b10f33e787541bff8eb25a9fa86b752f15de91/inc/starter-content.php#L36-L41

Going to edit these pages I found they're all using the Classic Block instead of paragraph blocks for their starter content. The starter content for those pages is in core here;
​https://github.com/WordPress/wordpress-develop/blob/d88473fa2fdebeb592f3032fe1dfc68ca9d6d4d5/src/wp-includes/theme.php#L2187-L2216

It would be nice to update to use blocks here similar to how the Sample Page and Privacy Policy page are setup.

Cheers

[garrett-eclipse]

About showing it's default content is editable via Classic block instead of normal blocks

[Clorith]

I just stumbled onto this as well wen testing Twenty Twenty, and found it a bit disheartening that we're fronting the new block editor so well with it, and then we get presented with a classic block.

We're currently just days away from WordPress 5.3-RC1, so it's kind of late to start touching starter content, as I would classify this as an enhancement (improving on starter content) than a bug.

That said, Twenty Twenty can prepare for this (it already does for the front page, see ​https://github.com/WordPress/twentytwenty/blob/d925696fbe5631817c4a56854922f65aebec3fff/inc/starter-content.php).

With that in mind, I'm going to milestone this for 5.4, but will drop a note about it pre-RC for 5.3 in case we can shimmy it in there.

48130.patch​ adds the paragraph wrapper around the already existing strings, unlike #45151 (which is somewhat related), there's no need to leave the HTML comments etc in the translation string, as the strings in question have always been one off sentences.

[garrett-eclipse]

Applying the patch we're finding proper blocks on the starter content

[garrett-eclipse]

Thanks @Clorith I agree having this in 5.3 would be ideal but do understand we might be too late for that ship.

Testing this applies and works nicely for the starter content enabling as proper blocks. See screen for success there.

My only concern was users still on the classic editor will get markup but as this follows what we did in #45151 I feel this will suffice as is and we can look into stripping that markup for the classic editor in another ticket so created #48279.

[ocean90]

In 46457:

Themes: Convert core-provided starter content to block content.

Props Clorith.
Fixes #48130.