Opened 6 years ago
Closed 6 years ago
#48129 closed task (blessed) (fixed)
There isn't different of color between Select disabled and enabled
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 5.3 | Priority: | normal |
| Severity: | normal | Version: | 5.3 |
| Component: | Administration | Keywords: | has-patch has-screenshots 5-3-admin-css-changes |
| Focuses: | ui, accessibility | Cc: |
Description
In Reading Settings, When we want to choose what page as home page, between "Your latest posts" or "A static page (select below)", there is no different of color on that drop-down.
Attachments (6)
Change History (15)
#1
@
6 years ago
- Component changed from General to Administration
- Focuses administration removed
- Milestone changed from Awaiting Review to 5.3
- Owner set to kjellr
- Status changed from new to assigned
#2
@
6 years ago
Thanks for the report and for the patch, @adhitya03.
The styles for the select dropdown are based on our button styles. Since the buttons don't use opacity for the disabled state, I'd prefer we don't use it here either. I'm attaching 48129.2.diff, which uses the same disabled styles we use for buttons in buttons.css (plus the addition of a lighter gray variant of the arrow SVG).
Screenshot:
This ticket was mentioned in Slack in #core by garrett-eclipse. View the logs.
6 years ago
#5
@
6 years ago
Hi @MarcosAlexandre thanks for the patch.
I think the patch should effect to all disabled state of select, instead of only for one part. I'd prefer @kjellr 's patch.
#6
@
6 years ago
Reproduce from @kjellr 's patch, delete !important property. All style work fine without that.
#7
@
6 years ago
Sounds good to me. We do use !important styles for these in buttons.css, but I'm much happier not using them if we can help it.
48129.4.diff should be good to go. Thanks for the help, everyone!
Before Patch