WordPress.org

Make WordPress Core

Opened 11 days ago

Closed 5 days ago

#48263 closed defect (bug) (fixed)

Block Editor: Remove experimental Social Links blocks

Reported by: gziolo Owned by: gziolo
Milestone: 5.3 Priority: normal
Severity: normal Version: trunk
Component: Editor Keywords: has-patch dev-feedback commit
Focuses: javascript, performance Cc:
PR Number:

Description (last modified by gziolo)

We decided to mark Social Links block as an experimental feature in Gutenberg. In effect, we are moving all related code from WordPress 5.3 release. This PR handles it.

I also tested whether removing Social Links blocks will have an impact on the size of code sent to the users.

I used wordpress-develop without gzip enabled.

Trunk/master

https://core.trac.wordpress.org/raw-attachment/ticket/48263/Screen%20Shot%202019-10-09%20at%2013.28.17.png
https://core.trac.wordpress.org/raw-attachment/ticket/48263/Screen%20Shot%202019-10-09%20at%2013.31.44.png

Patch/branch

https://core.trac.wordpress.org/raw-attachment/ticket/48263/Screen%20Shot%202019-10-09%20at%2013.21.39.png
https://core.trac.wordpress.org/raw-attachment/ticket/48263/Screen%20Shot%202019-10-09%20at%2013.23.26.png

Attachments (5)

social-links-blocks.diff (117.5 KB) - added by gziolo 11 days ago.
Screen Shot 2019-10-09 at 13.21.39.png (78.9 KB) - added by gziolo 11 days ago.
Diff - size of the document
Screen Shot 2019-10-09 at 13.28.17.png (80.4 KB) - added by gziolo 11 days ago.
Trunk - size of the document
Screen Shot 2019-10-09 at 13.23.26.png (153.9 KB) - added by gziolo 11 days ago.
Branch - size of JS files
Screen Shot 2019-10-09 at 13.31.44.png (140.0 KB) - added by gziolo 11 days ago.
Trunk - size of JS files

Download all attachments as: .zip

Change History (15)

@gziolo
11 days ago

Diff - size of the document

@gziolo
11 days ago

Trunk - size of the document

@gziolo
11 days ago

Branch - size of JS files

@gziolo
11 days ago

Trunk - size of JS files

#1 @gziolo
11 days ago

  • Description modified (diff)

#2 @gziolo
11 days ago

  • Description modified (diff)

#3 @gziolo
11 days ago

  • Description modified (diff)

#5 @youknowriad
11 days ago

Do we need to remove the php files? I mean can't we just remove the includes. The issue I see if we remove the php files is that we might get a diff locally, each time we do npm install && npm run grunt build.

#6 @gziolo
11 days ago

Do we need to remove the php files? I mean can't we just remove the includes. The issue I see if we remove the php files is that we might get a diff locally, each time we do npm install && npm run grunt build.

You shouldn't experience this issue as long as the related PHP isn't whitelisted:
https://github.com/WordPress/wordpress-develop/pull/107/files#diff-df0280933db62a33cd94973b5ec4871eL106

#7 @davidbaumwald
5 days ago

  • Milestone changed from 5.3 to Future Release

With 5.3 RC1 releasing today and work still left on this ticket, it is being moved to Future Release. If any committer feels this can be worked in quickly for 5.3 or can assume ownership in 5.4, feel free to move it back up.

#8 @youknowriad
5 days ago

  • Milestone changed from Future Release to 5.3
  • Type changed from enhancement to defect (bug)

Actually, this is ready to ship and I forgot to approve. LGTM commit it @gziolo

#9 @youknowriad
5 days ago

  • Keywords commit added

#10 @gziolo
5 days ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 46543:

Block Editor: Remove experimental Social Links blocks

We decided to mark Social Links block as an experimental feature in Gutenberg. In effect, we are moving all related code from WordPress 5.3 release.

Props youknowriad.

Fixes #48263.

Note: See TracTickets for help on using tickets.