Opened 5 years ago
Closed 5 years ago
#48263 closed defect (bug) (fixed)
Block Editor: Remove experimental Social Links blocks
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.3 | Priority: | normal |
Severity: | normal | Version: | 5.3 |
Component: | Editor | Keywords: | has-patch dev-feedback commit |
Focuses: | javascript, performance | Cc: |
Description (last modified by )
We decided to mark Social Links block as an experimental feature in Gutenberg. In effect, we are moving all related code from WordPress 5.3 release. This PR handles it.
I also tested whether removing Social Links blocks will have an impact on the size of code sent to the users.
I used wordpress-develop
without gzip enabled.
Trunk/master
Patch/branch
Attachments (5)
Change History (15)
#4
@
5 years ago
Tested with Travis: https://github.com/WordPress/wordpress-develop/pull/107.
#5
@
5 years ago
Do we need to remove the php files? I mean can't we just remove the includes. The issue I see if we remove the php files is that we might get a diff locally, each time we do npm install && npm run grunt build.
#6
@
5 years ago
Do we need to remove the php files? I mean can't we just remove the includes. The issue I see if we remove the php files is that we might get a diff locally, each time we do npm install && npm run grunt build.
You shouldn't experience this issue as long as the related PHP isn't whitelisted:
https://github.com/WordPress/wordpress-develop/pull/107/files#diff-df0280933db62a33cd94973b5ec4871eL106
#7
@
5 years ago
- Milestone changed from 5.3 to Future Release
With 5.3 RC1 releasing today and work still left on this ticket, it is being moved to Future Release
. If any committer feels this can be worked in quickly for 5.3 or can assume ownership in 5.4, feel free to move it back up.
Diff - size of the document