WordPress.org

Make WordPress Core

Opened 14 months ago

Closed 14 months ago

Last modified 14 months ago

#48276 closed defect (bug) (reported-upstream)

Hide the snackbar action components link on focus

Reported by: Mahesh901122 Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.3
Component: Editor Keywords: 2nd-opinion
Focuses: ui Cc:

Description

Default message:

https://maheshwaghmare.files.wordpress.com/2019/10/image-2019-10-10-at-7.11.13-pm.png

Default message + focus:
https://maheshwaghmare.files.wordpress.com/2019/10/image-2019-10-10-at-7.12.37-pm.png

I think the possible fix for this issue is update the below selector:

.components-snackbar__action.components-button:not(:disabled):not([aria-disabled="true"]):not(.is-default)

with:

.components-snackbar__action.components-button:not(:disabled):not([aria-disabled="true"]):not(.is-default):not(:focus)

from files:

wp-includes/css/dist/components/style.css
wp-includes/css/dist/components/style-rtl.css

Attachments (2)

Image 2019-10-10 at 7.11.13 PM.png (1.9 KB) - added by Mahesh901122 14 months ago.
Default Message
Image 2019-10-10 at 7.12.37 PM.png (77.7 KB) - added by Mahesh901122 14 months ago.
Default Message + Focus

Download all attachments as: .zip

Change History (6)

@Mahesh901122
14 months ago

Default Message

@Mahesh901122
14 months ago

Default Message + Focus

#1 @swissspidy
14 months ago

A pull request for https://github.com/WordPress/gutenberg/blob/master/packages/components/src/snackbar/style.scss would be needed for such a change. Would you mind submitting one? :-)

#2 @Mahesh901122
14 months ago

I have added the PR on GitHub. PR URL is https://github.com/WordPress/gutenberg/pull/17887

So, Can you please close this ticket? Or I need to close it?

Also, Thank you for guiding.

Last edited 14 months ago by Mahesh901122 (previous) (diff)

#3 @SergeyBiryukov
14 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to reported-upstream
  • Status changed from new to closed

Thanks for the follow-up!

#4 @gziolo
14 months ago

It was replicated in Gutenberg, patch coming up soon there, thanks!

Note: See TracTickets for help on using tickets.