WordPress.org

Make WordPress Core

Opened 3 months ago

Last modified 2 months ago

#48399 new defect (bug)

Recovery mode can stick the admin in a bad state

Reported by: programmin Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords:
Focuses: Cc:
PR Number:

Description

I got an error because a local class hadn't been copied to test wp directory, and got the Your Site is Experiencing a Technical Issue.

I tried the enter_recovery_mode link in the email and got a different looking login, and the frontend site is blank. Even after the issue is fixed and all theme files are copied over, no fatal errors in the log, it still is blank.

When I open in new container tab or different browser, the site is fine, seems like this could cause more confusion than help since this recovery-mode can make the site blank and it is cookie-based, it probably should mention this in the email that they will be seeing not what everyone else sees, even if issue is fixed?

Change History (3)

#1 @SergeyBiryukov
3 months ago

  • Component changed from General to Site Health

#2 @SergeyBiryukov
2 months ago

  • Version changed from trunk to 5.2

#3 @Clorith
2 months ago

Hiya,

So just so I have the scenario correct. Your theme was missing some files, which caused a fatal error, and you entered recovery mode, correct?

If that's correct, it makes sense that your current session in recovery mode would be loaded without a theme (since it was the theme that broke), and not be visible until you exit recovery mode.

I do agree that this may not be the best of experiences though, so let's look at scenarios to resolve this via.

My initial thought was that the recovery mode needs a "Test now", which tries reloading without recovery mode, and if all is good, shows a notice to that effect. If trying again fails, dump the user back into recovery mode with a notice saying so.

This would still mean that the site doesn't instantly "fix" it self while in recovery mode until you hit the button, but it does provide an actionable path forward to hopefully not cause confusion?

Note: See TracTickets for help on using tickets.