"Admin Color Scheme" should not be saved before hitting the "Update Profile" button in profile page

[mukto90]

On the profile page (/wp-admin/profile.php) when you click on a color scheme, it instantly updates (via AJAX) in the user meta and changes the color.

I think this should not happen. User meta should be updated only after they hit the "Update Profile" button. It's OK to show the color (preview) as soon as they click an option, but storing the value in the database should be updated along with other info after clicking the save button.

[mukto90]

I've attached a patch

[earnjam]

I think previewing it and not saving it would be more confusing. Users would see the color scheme they want, then navigate away from the page where it would be reverted back to the previous value.

There is probably some discussion about this from back when this was first added, but I can’t find it right now.

[alvitazwar052]

Test Report

Patch tested: https://core.trac.wordpress.org/attachment/ticket/48553/48553.diff

Environment

• OS: macOS 12.4
• Web Server: Nginx
• PHP: 7.4.33
• WordPress: 6.3-alpha-55505-src
• Browser: Chrome
• Theme: Twenty Twenty-two, Twenty-nineteen

ScreenCast

Before applying the patch: ​https://www.loom.com/share/fee1873fe6ec41e6bb105f59e5b26581
After applying the patch: ​https://www.loom.com/share/8610ef1921bb4f1b880fa2dd69d5194d

Notes

After applying the patch, the user needs to click Update profile to change the color scheme.

Actual Results

• The patch is working as expected✅