Opened 3 months ago
Last modified 3 months ago
#48553 assigned defect (bug)
"Admin Color Scheme" should not be saved before hitting the "Update Profile" button in profile page
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Awaiting Review | Priority: | normal |
| Severity: | normal | Version: | 3.8 |
| Component: | Users | Keywords: | has-screenshots has-patch |
| Focuses: | ui, administration | Cc: | |
| PR Number: |
Description
On the profile page (/wp-admin/profile.php) when you click on a color scheme, it instantly updates (via AJAX) in the user meta and changes the color.
I think this should not happen. User meta should be updated only after they hit the "Update Profile" button. It's OK to show the color (preview) as soon as they click an option, but storing the value in the database should be updated along with other info after clicking the save button.
Attachments (2)
Change History (5)
#2
@
3 months ago
I think previewing it and not saving it would be more confusing. Users would see the color scheme they want, then navigate away from the page where it would be reverted back to the previous value.
There is probably some discussion about this from back when this was first added, but I can’t find it right now.
I've attached a patch