WordPress.org

Make WordPress Core

Opened 8 days ago

Last modified 8 days ago

#48553 assigned defect (bug)

"Admin Color Scheme" should not be saved before hitting the "Update Profile" button in profile page

Reported by: mukto90 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.8
Component: Users Keywords: has-screenshots has-patch
Focuses: ui, administration Cc:
PR Number:

Description

On the profile page (/wp-admin/profile.php) when you click on a color scheme, it instantly updates (via AJAX) in the user meta and changes the color.

I think this should not happen. User meta should be updated only after they hit the "Update Profile" button. It's OK to show the color (preview) as soon as they click an option, but storing the value in the database should be updated along with other info after clicking the save button.
https://s.nimbusweb.me/attachment/3516583/0ug6f4ro5vxd2e91ggdm/alEdMIiK5cCc8V2P/screenshot-core.wp-2019.11.10-17_25_46.png

Attachments (2)

48553.diff (447 bytes) - added by mukto90 8 days ago.
I've attached a patch
screenshot-core.wp-2019.11.10-17_25_46.png (77.7 KB) - added by SergeyBiryukov 8 days ago.

Download all attachments as: .zip

Change History (5)

@mukto90
8 days ago

I've attached a patch

#1 @mukto90
8 days ago

  • Keywords has-patch added; needs-patch removed

#2 @earnjam
8 days ago

I think previewing it and not saving it would be more confusing. Users would see the color scheme they want, then navigate away from the page where it would be reverted back to the previous value.

There is probably some discussion about this from back when this was first added, but I can’t find it right now.

#3 @earnjam
8 days ago

  • Focuses ui administration added
  • Version changed from trunk to 3.8
Note: See TracTickets for help on using tickets.