Remove the CollegeHumor oEmbed provider

[youknowriad]

Initially reported here ​https://wordpress.org/support/topic/collegehumor-should-be-removed/

It looks like the CollergeHumor website shut down, should we remove the oEmbed provider?

Gutenberg block related issue ​https://github.com/WordPress/gutenberg/issues/18567

[audrasjb]

embed doesn't work anymore even on classic editor

[audrasjb]

Remove CollegeHumor from embed provider since the service doesn’t exists anymore.

[audrasjb]

48696.diff removes CollegeHumor from the embed providers list and updates docs to add it to the deprecated providers list.

Worth committing it for the next point release as CollegeHumor embeds won't work anymore.

[youknowriad]

We should also sync this with the removal of the block from Gutenberg. If we remove the provider from 5.3.1 we should also remove the block at the same time.

[audrasjb]

@youknowriad are you planning to deploy Gutenberg fixes/enhancements for the next point release?

If you think it can be handled in a minor release on Gutenberg side, I'll make sure we keep synchronized on that point ;-)
In any case, I think it can be merged into trunk without problem.

[youknowriad]

are you planning to deploy Gutenberg fixes/enhancements for the next point release?

Yes hopefully, also could be a good first issue in Gutenberg if you want to try a PR :)

[audrasjb]

Thanks for the quick answer, Riad :-)
I tried a PR on Gutenberg: ​https://github.com/WordPress/gutenberg/pull/18591

[audrasjb]

Patch ready for commit since Gutenberg PR was approved earlier today.
​https://github.com/WordPress/gutenberg/pull/18591#pullrequestreview-320892610

[audrasjb]

The PR is now merged into Gutenberg: ​https://github.com/WordPress/gutenberg/pull/18591
Would be great to commit it as soon as possible, as the Editor team has to re-test the Gutenberg PR once the core patch is committed.

[SergeyBiryukov]

In 46761:

Embeds: Remove CollegeHumor oEmbed provider, as the service does not exist anymore.

Props audrasjb, youknowriad.
Fixes #48696.

[SergeyBiryukov]

Reopening for 5.3.1.

[SergeyBiryukov]

In 46768:

Embeds: Remove CollegeHumor oEmbed provider, as the service does not exist anymore.

Props audrasjb, youknowriad.
Merges [46761] to the 5.3 branch.
Fixes #48696.

[audrasjb]

Documentation added in the miscellaneous changes dev note: ​https://make.wordpress.org/core/2020/02/26/miscellaneous-developer-focused-changes-in-wordpress-5-4/