#48696 closed defect (bug) (fixed)
Remove the CollegeHumor oEmbed provider
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.3.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Embeds | Keywords: | has-patch commit fixed-major has-dev-note |
Focuses: | Cc: |
Description
Initially reported here https://wordpress.org/support/topic/collegehumor-should-be-removed/
It looks like the CollergeHumor website shut down, should we remove the oEmbed provider?
Gutenberg block related issue https://github.com/WordPress/gutenberg/issues/18567
Attachments (2)
Change History (13)
#1
@
4 years ago
- Keywords has-patch added
- Milestone changed from Awaiting Review to 5.3.1
- Owner set to audrasjb
- Status changed from new to accepted
48696.diff
removes CollegeHumor from the embed providers list and updates docs to add it to the deprecated providers list.
Worth committing it for the next point release as CollegeHumor embeds won't work anymore.
#2
@
4 years ago
We should also sync this with the removal of the block from Gutenberg. If we remove the provider from 5.3.1 we should also remove the block at the same time.
#3
@
4 years ago
@youknowriad are you planning to deploy Gutenberg fixes/enhancements for the next point release?
If you think it can be handled in a minor release on Gutenberg side, I'll make sure we keep synchronized on that point ;-)
In any case, I think it can be merged into trunk without problem.
#4
@
4 years ago
are you planning to deploy Gutenberg fixes/enhancements for the next point release?
Yes hopefully, also could be a good first issue in Gutenberg if you want to try a PR :)
#5
@
4 years ago
Thanks for the quick answer, Riad :-)
I tried a PR on Gutenberg: https://github.com/WordPress/gutenberg/pull/18591
#6
@
4 years ago
- Keywords commit added
Patch ready for commit
since Gutenberg PR was approved earlier today.
https://github.com/WordPress/gutenberg/pull/18591#pullrequestreview-320892610
#7
@
4 years ago
The PR is now merged into Gutenberg: https://github.com/WordPress/gutenberg/pull/18591
Would be great to commit it as soon as possible, as the Editor team has to re-test the Gutenberg PR once the core patch is committed.
#9
@
4 years ago
- Keywords fixed-major added
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening for 5.3.1.
#11
@
3 years ago
- Keywords has-dev-note added
Documentation added in the miscellaneous changes dev note: https://make.wordpress.org/core/2020/02/26/miscellaneous-developer-focused-changes-in-wordpress-5-4/
embed doesn't work anymore even on classic editor