WordPress.org

Make WordPress Core

Opened 11 months ago

Closed 11 months ago

Last modified 8 months ago

#48696 closed defect (bug) (fixed)

Remove the CollegeHumor oEmbed provider

Reported by: youknowriad Owned by: audrasjb
Milestone: 5.3.1 Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch commit fixed-major has-dev-note
Focuses: Cc:

Description

Initially reported here https://wordpress.org/support/topic/collegehumor-should-be-removed/

It looks like the CollergeHumor website shut down, should we remove the oEmbed provider?

Gutenberg block related issue https://github.com/WordPress/gutenberg/issues/18567

Attachments (2)

Capture d’écran 2019-11-18 à 20.47.52.png (302.2 KB) - added by audrasjb 11 months ago.
embed doesn't work anymore even on classic editor
48696.diff (1.9 KB) - added by audrasjb 11 months ago.
Remove CollegeHumor from embed provider since the service doesn’t exists anymore.

Download all attachments as: .zip

Change History (13)

@audrasjb
11 months ago

embed doesn't work anymore even on classic editor

@audrasjb
11 months ago

Remove CollegeHumor from embed provider since the service doesn’t exists anymore.

#1 @audrasjb
11 months ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 5.3.1
  • Owner set to audrasjb
  • Status changed from new to accepted

48696.diff removes CollegeHumor from the embed providers list and updates docs to add it to the deprecated providers list.

Worth committing it for the next point release as CollegeHumor embeds won't work anymore.

#2 @youknowriad
11 months ago

We should also sync this with the removal of the block from Gutenberg. If we remove the provider from 5.3.1 we should also remove the block at the same time.

#3 @audrasjb
11 months ago

@youknowriad are you planning to deploy Gutenberg fixes/enhancements for the next point release?

If you think it can be handled in a minor release on Gutenberg side, I'll make sure we keep synchronized on that point ;-)
In any case, I think it can be merged into trunk without problem.

#4 @youknowriad
11 months ago

are you planning to deploy Gutenberg fixes/enhancements for the next point release?

Yes hopefully, also could be a good first issue in Gutenberg if you want to try a PR :)

#5 @audrasjb
11 months ago

Thanks for the quick answer, Riad :-)
I tried a PR on Gutenberg: https://github.com/WordPress/gutenberg/pull/18591

#6 @audrasjb
11 months ago

  • Keywords commit added

Patch ready for commit since Gutenberg PR was approved earlier today.
https://github.com/WordPress/gutenberg/pull/18591#pullrequestreview-320892610

#7 @audrasjb
11 months ago

The PR is now merged into Gutenberg: https://github.com/WordPress/gutenberg/pull/18591
Would be great to commit it as soon as possible, as the Editor team has to re-test the Gutenberg PR once the core patch is committed.

#8 @SergeyBiryukov
11 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 46761:

Embeds: Remove CollegeHumor oEmbed provider, as the service does not exist anymore.

Props audrasjb, youknowriad.
Fixes #48696.

#9 @SergeyBiryukov
11 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 5.3.1.

#10 @SergeyBiryukov
11 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 46768:

Embeds: Remove CollegeHumor oEmbed provider, as the service does not exist anymore.

Props audrasjb, youknowriad.
Merges [46761] to the 5.3 branch.
Fixes #48696.

#11 @audrasjb
8 months ago

  • Keywords has-dev-note added
Note: See TracTickets for help on using tickets.