WordPress.org

Make WordPress Core

Opened 5 months ago

Last modified 8 weeks ago

#48709 new defect (bug)

Disabled button doesn't look disabled

Reported by: drw158 Owned by:
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch needs-dev-note
Focuses: ui, administration Cc:

Description

Midnight:

http://cldup.com/4lUDc58Vns.png

Default:

http://cldup.com/V3xFKZ3jlY.png

The Delete Permanently button is disabled because I haven't selected anything yet.

The problem is that it doesn't look disabled at all. The problem seems more prominent in the midnight color scheme. The text color seems different for some reason.

To reproduce:

  • Go to Media
  • Click Bulk Select

Attachments (2)

Screenshot 2019-11-18 at 22.27.26.png (88.5 KB) - added by afercia 5 months ago.
48709.diff (989 bytes) - added by melchoyce 4 months ago.
Not working for the Light color scheme, which takes a different approach to primary buttons. @ryelle can you take a look?

Download all attachments as: .zip

Change History (11)

This ticket was mentioned in Slack in #design by drw158. View the logs.


5 months ago

#2 @SergeyBiryukov
5 months ago

  • Component changed from General to Administration

Related: #48598

#3 @afercia
5 months ago

Not sure this is related to #48598 or any other change in WordPress 5.3. It's just the usual disabled style for primary buttons (see screenshot below from WordPress 5.2). Not saying it wouldn't benefit from some improvements.

#4 @kennethroberson5556
5 months ago

Totally agreed. I felt confused working on a recent site https://kickthebuddyapk.com/, too. The color schemes are very odd. In my opinion, it shouldn't be only enabled but also highlighted when the pictures are selected.

Last edited 5 months ago by kennethroberson5556 (previous) (diff)

#5 @melchoyce
4 months ago

Yeah, I'd say this is an issue with the core disabled button styling that's exacerbated by color schemes. I've gotten the style working better for most schemes, but I agree we should address the underlying issue of having better disabled primary button styles.

@melchoyce
4 months ago

Not working for the Light color scheme, which takes a different approach to primary buttons. @ryelle can you take a look?

#6 @afercia
4 months ago

Worth noting that introducing new color variables would need a dev note. There are plugins that extend the color schemes e.g. and they should be informed there are new variables to use.

This ticket was mentioned in Slack in #accessibility by joedolson. View the logs.


2 months ago

#8 @joedolson
2 months ago

On the accessibility side, we don't have any issues with the design team making a call on changing this. Contrast requirements don't apply to disabled interface controls, so we don't have any concerns.

#9 @valentinbora
8 weeks ago

  • Focuses administration added
  • Keywords has-patch needs-dev-note added
  • Milestone changed from Awaiting Review to 5.5
Note: See TracTickets for help on using tickets.