WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#48744 closed defect (bug) (worksforme)

Site Health terms parent theme as inactive

Reported by: superpoincare Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Site Health Keywords:
Focuses: Cc:

Description

I have just three themes: Twenty Twelve, child, and Twenty Twenty (as recommended by Site Health to remove other themes).

However, I still see an inactive theme under Site Health > Info

https://i.imgur.com/b0r84QO.png

Moreover, its version is also incorrect, that of the child theme, not parent.

Change History (4)

#1 @Clorith
3 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to worksforme
  • Status changed from new to closed

This is actually correct, as you mentioned you are using Twenty Twelve, and a child theme of that (they would be listed under Parent Theme and Child Theme respectively), and the inactive theme is Twenty Twenty, so even if the theme is a default theme in WordPress, since it's not active, it will be in the inactive list.

Since it appears like it's correct here, I'm going to mark the topic as worksforme, but if there's any new details brought ot light that indicates it's not working as intended, we can certainly re-open the ticket at that time.

#2 follow-up: @superpoincare
3 months ago

The version of the "inactive" theme is wrong, so purely for that you should reopen it.

But more importantly a parent theme of an active child theme cannot be called "inactive". It is as active as its child.

#3 in reply to: ↑ 2 @SergeyBiryukov
3 months ago

Replying to superpoincare:

The version of the "inactive" theme is wrong, so purely for that you should reopen it.

Twenty Twenty is currently at version 1.0, so the version on your screenshot appears to be correct.

But more importantly a parent theme of an active child theme cannot be called "inactive". It is as active as its child.

Right, but unless I'm missing something, your parent theme is Twenty Twelve, not Twenty Twenty:

  • Active Theme: Your child theme of Twenty Twelve
  • Parent Theme: Twenty Twelve (released with WordPress 3.5 in 2012, #19978)
  • Inactive Theme: Twenty Twenty (released with WordPress 5.3, #48110)

#4 @superpoincare
3 months ago

Oops, so sorry for my confused comments.

I guess where I am coming from is that the Site Health asks to uninstall inactive themes.

Twenty Twenty is needed for running the WordPress health check troubleshooter plugin which helps debugging.

So the site health feature shouldn't call Twenty Twenty as inactive, as it might lead a user to uninstall Twenty Twenty.

Should say that all this doesn't depend on child/parent complication unlike my previous comments indicated.

Also in "recommended improvements" in Site Health > Status, Twenty Twenty is not called inactive for an installation with lots of themes. So if I have all 10 bundled themes installed, it says 8 inactive themes. Which is fine, but to be consistent with that, under Site Health > Info, Twenty Twenty shouldn't be termed inactive.

In other words, if you have the minimal setup, like mine, no theme is inactive really.

Note: See TracTickets for help on using tickets.