WordPress.org

Make WordPress Core

Opened 3 days ago

Last modified 3 days ago

#48869 assigned defect (bug)

i18n: Use %s placeholders in wp-admin/includes/file.php

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-screenshots has-patch
Focuses: administration Cc:
PR Number:

Description

One more translation string that uses file names and constants in translation string.

See the attached screenshot.

The attached patch replaces them with %s placeholders.

Attachments (2)

48869.png (13.0 KB) - added by ramiy 3 days ago.
48869.patch (1.0 KB) - added by ramiy 3 days ago.

Download all attachments as: .zip

Change History (5)

@ramiy
3 days ago

@ramiy
3 days ago

#1 @ramiy
3 days ago

  • Keywords has-screenshots has-patch added

Old Strings:

  • The uploaded file exceeds the upload_max_filesize directive in php.ini.
  • The uploaded file exceeds the MAX_FILE_SIZE directive that was specified in the HTML form.

New Strings:

  • The uploaded file exceeds the %1$s directive in %2$s.
  • The uploaded file exceeds the %s directive that was specified in the HTML form.

#2 @ramiy
3 days ago

We should consider replacing in php.ini not only with in %2$s but with in %2$s file.

#3 @SergeyBiryukov
3 days ago

  • Milestone changed from Awaiting Review to 5.4
Note: See TracTickets for help on using tickets.