impossible to set show_admin_bar_front to false in wp_insert_user

[bilgilabs]

in wp-includes/user.php line 1752

        $meta['show_admin_bar_front'] = empty( $userdata['show_admin_bar_front'] ) ? 'true' : $userdata['show_admin_bar_front'];

with this expression it seems to me that setting show_admin_bar_front to false is impossible. it should be

        $meta['show_admin_bar_front'] = !isset( $userdata['show_admin_bar_front'] ) ? 'true' : $userdata['show_admin_bar_front'];

[SergeyBiryukov]

Hi there, welcome to WordPress Trac! Thanks for the report.

As seen in edit_user()​, the value accepts a string 'true' or 'false', not a boolean true or false, so the code is correct as is.

It could probably be explained better in the documentation, though.

[valentinbora]

@SergeyBiryukov ​https://developer.wordpress.org/reference/functions/wp_insert_user/ mentions (string|bool) in the param docs, so the OP's ticket makes sense to a certain extent.

Should we consider updating the code per the patch or updating the docs?

[audrasjb]

Docs: improve params documentation for wp_insert_user()

[audrasjb]

Hi,

There may be some backward compatibility issues if we decide to transform it into a real boolean. I propose to update the documentation to make it clear this parameter accepts only 'false' or 'true'.

In 49087.diff: Docs: improve show_admin_bar_front parameter documentation for wp_insert_user()

[bilgilabs]

hello

it's probably a good idea to only make the document clear. the line should say something like

• @type string $show_admin_bar_front Whether to display the Admin Bar for the user on the site's front end. Default 'true' (string literal not boolean or otherwise), or empty, or no parameter enables it, only 'false' (string literal not boolean or otherwise) disables it.

Replying to audrasjb:

Hi,

There may be some backward compatibility issues if we decide to transform it into a real boolean. I propose to update the documentation to make it clear this parameter accepts only 'false' or 'true'.

In 49087.diff: Docs: improve show_admin_bar_front parameter documentation for wp_insert_user()

[garrett-eclipse]

Updated patch to be clear 'true'/'false' are string literal and not boolean.

[garrett-eclipse]

I've refreshed the patch by @audrasjb (thank you) in 49087.2.diff to hopefully clarify that the values should be 'true'/'false' as string literal and not boolean. I hope that clarifies for you as well @bilgilabs.

If that works I think it's ready to move forward.

[audrasjb]

Right. @garrett-eclipse ’s proposal looks great to me 👍

[SergeyBiryukov]

In 47368:

Docs: In wp_insert_user(), clarify that rich_editing, syntax_highlighting, comment_shortcuts, and show_admin_bar_front arguments accept true or false as a string literal, not boolean.

Props garrett-eclipse, audrasjb, valentinbora, bilgilabs, SergeyBiryukov.
Fixes #49087.

[SergeyBiryukov]

In 47369:

Docs: In wp_insert_user(), correct @type for rich_editing, syntax_highlighting, comment_shortcuts, and show_admin_bar_front arguments.

Follow-up to [47368].

See #49087.