WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 6 months ago

#49139 closed defect (bug) (fixed)

Copied Text isn't vertically centred to it's corresponding button

Reported by: garrett-eclipse Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords: has-patch has-screenshots
Focuses: administration Cc:

Description

Hello,

While working on implementing similar Copied functionality to the Privacy Tools I found the Site Health version of the text isn't vertically centred to it's adjacent button.

Minor patch coming to address this.

Cheers

Attachments (3)

49139.diff (423 bytes) - added by garrett-eclipse 6 months ago.
Patch to adjust Copied verbiage to vertical centre and line up with it's corresponding button.
Screen Shot 2020-01-05 at 11.44.08 PM.png (15.9 KB) - added by garrett-eclipse 6 months ago.
Before - Slightly off centre
Screen Shot 2020-01-05 at 11.44.32 PM.png (17.1 KB) - added by garrett-eclipse 6 months ago.
After - Vertically centred in reference to it's button

Download all attachments as: .zip

Change History (5)

@garrett-eclipse
6 months ago

Patch to adjust Copied verbiage to vertical centre and line up with it's corresponding button.

@garrett-eclipse
6 months ago

Before - Slightly off centre

@garrett-eclipse
6 months ago

After - Vertically centred in reference to it's button

#1 @SergeyBiryukov
6 months ago

  • Milestone changed from Awaiting Review to 5.4
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#2 @SergeyBiryukov
6 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47047:

Site Health: Make sure the "Copied!" text is vertically centered to the "Copy site info to clipboard" button.

Props garrett-eclipse.
Fixes #49139.

Note: See TracTickets for help on using tickets.