WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 4 months ago

Last modified 4 months ago

#49270 closed enhancement (fixed)

Add color format to REST API validation

Reported by: spacedmonkey Owned by: spacedmonkey
Milestone: 5.5 Priority: normal
Severity: normal Version: 4.4
Component: REST API Keywords: has-patch
Focuses: rest-api Cc:

Description

Add validation for color as a formatted type in REST API requests.

Attachments (4)

49270.diff (1.5 KB) - added by spacedmonkey 5 months ago.
49270.2.diff (1.4 KB) - added by spacedmonkey 5 months ago.
49270.3.diff (3.8 KB) - added by spacedmonkey 5 months ago.
49270.4.diff (4.5 KB) - added by spacedmonkey 5 months ago.

Download all attachments as: .zip

Change History (11)

@spacedmonkey
5 months ago

This ticket was mentioned in PR #140 on WordPress/wordpress-develop by spacedmonkey.


5 months ago

This ticket was mentioned in PR #141 on WordPress/wordpress-develop by spacedmonkey.


5 months ago

#3 @chrisvanpatten
5 months ago

I dig this a lot but it should probably be named "hex color" or something like that, to distinguish it from other valid color types (rgb, rgba, hsl, etc)

#4 @TimothyBlynJacobs
5 months ago

  • Milestone changed from Awaiting Review to Future Release

This looks great! I agree with @chrisvanpatten about naming to make it clear this is a hex color format.

#5 @spacedmonkey
5 months ago

Thanks for the feedback. In 49270.4.diff, I change naming to hex-color and added tests.

You can also posts comments on PR here.

Last edited 5 months ago by spacedmonkey (previous) (diff)

#6 @TimothyBlynJacobs
4 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 47450:

REST API: Introduce "hex-color" JSON Schema format.

Props spacedmonkey, chrisvanpatten.
Fixes #49270.

#7 @TimothyBlynJacobs
4 months ago

  • Milestone changed from Future Release to 5.5
Note: See TracTickets for help on using tickets.