WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 3 months ago

#49320 closed defect (bug) (fixed)

Twenty Twenty: aligncenter>figcaption missing text-align: center; feature

Reported by: markusthiel Owned by: ianbelanger
Milestone: 5.4.2 Priority: normal
Severity: normal Version: 5.3
Component: Bundled Theme Keywords: has-patch good-first-bug fixed-major
Focuses: css Cc:

Description

When having a centered image.. the caption is not centered

Attachments (1)

49320.patch (896 bytes) - added by garethgillman 6 months ago.
adds center align to figcaption in styles.css and style-rtl.css

Download all attachments as: .zip

Change History (10)

#1 @SergeyBiryukov
7 months ago

  • Keywords reporter-feedback added

Hi there, welcome to WordPress Trac! Thanks for the ticket.

Some more details would be helpful here:

  • Could you share the steps to reproduce the issue on a clean install?
  • Which theme are you using? Does it still happen with a default theme (Twenty Twenty)?

#2 @markusthiel
6 months ago

Sorry.. I thought this was the trac for "Twenty Twenty"..
To reproduce, add a image block to a page using the default editor, select it to be aligned center, add caption text below the image

#3 @SergeyBiryukov
6 months ago

  • Component changed from Themes to Bundled Theme
  • Summary changed from aligncenter>figcaption missing text-align: center; feature to Twenty Twenty: aligncenter>figcaption missing text-align: center; feature

Ah, it makes more sense now :) Thanks for the follow-up!

#4 @SergeyBiryukov
6 months ago

  • Keywords reporter-feedback removed

@garethgillman
6 months ago

adds center align to figcaption in styles.css and style-rtl.css

#5 @ianbelanger
5 months ago

  • Keywords has-patch needs-testing good-first-bug added
  • Milestone changed from Awaiting Review to Future Release
  • Version set to 5.3

#6 @ianbelanger
3 months ago

  • Keywords needs-testing removed
  • Milestone changed from Future Release to 5.5
  • Owner set to ianbelanger
  • Status changed from new to reviewing

Patch looks good to me. I am going to review for commit.

#7 @ianbelanger
3 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47689:

Bundled Themes: Twenty Twenty image caption is not aligned center when image is, on the front-end.

Fixes the image caption alignment issue by adding text-align: center; to .wp-block-image .aligncenter figcaption.

Props markusthiel, SergeyBiryukov, garethgillman.
Fixes #49320.

#8 @ianbelanger
3 months ago

  • Keywords fixed-major added
  • Milestone changed from 5.5 to 5.4.2
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport.

#9 @whyisjake
3 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 47826:

Bundled Themes: Twenty Twenty image caption is not aligned center when image is, on the front-end.
Fixes the image caption alignment issue by adding text-align: center; to .wp-block-image .aligncenter figcaption.

This brings the changes from [47689] to the 5.4 branch.

Props markusthiel, SergeyBiryukov, garethgillman.
Fixes #49320.

Note: See TracTickets for help on using tickets.