WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#49320 closed defect (bug) (fixed)

Twenty Twenty: aligncenter>figcaption missing text-align: center; feature

Reported by: markusthiel Owned by: ianbelanger
Priority: normal Milestone: 5.4.2
Component: Bundled Theme Version: 5.3
Severity: normal Keywords: has-patch good-first-bug fixed-major
Cc: Focuses: css

Description

When having a centered image.. the caption is not centered

Attachments (1)

49320.patch​ (896 bytes ) - added by garethgillman 7 years ago.
adds center align to figcaption in styles.css and style-rtl.css

Download all attachments as: .zip

Change History (10)

#1 @SergeyBiryukov
7 years ago

  • Keywords reporter-feedback added

Hi there, welcome to WordPress Trac! Thanks for the ticket.

Some more details would be helpful here:

  • Could you share the steps to reproduce the issue on a clean install?
  • Which theme are you using? Does it still happen with a default theme (Twenty Twenty)?

#2 @markusthiel
7 years ago

Sorry.. I thought this was the trac for "Twenty Twenty"..
To reproduce, add a image block to a page using the default editor, select it to be aligned center, add caption text below the image

#3 @SergeyBiryukov
7 years ago

  • Component Themes → Bundled Theme
  • Summary aligncenter>figcaption missing text-align: center; feature → Twenty Twenty: aligncenter>figcaption missing text-align: center; feature

Ah, it makes more sense now :) Thanks for the follow-up!

#4 @SergeyBiryukov
7 years ago

  • Keywords reporter-feedback removed

@garethgillman
7 years ago

adds center align to figcaption in styles.css and style-rtl.css

#5 @ianbelanger
7 years ago

  • Keywords has-patch needs-testing good-first-bug added
  • Milestone Awaiting Review → Future Release
  • Version → 5.3

#6 @ianbelanger
6 years ago

  • Keywords needs-testing removed
  • Milestone Future Release → 5.5
  • Owner set to ianbelanger
  • Status new → reviewing

Patch looks good to me. I am going to review for commit.

#7 @ianbelanger
6 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 47689:

Bundled Themes: Twenty Twenty image caption is not aligned center when image is, on the front-end.

Fixes the image caption alignment issue by adding text-align: center; to .wp-block-image .aligncenter figcaption.

Props markusthiel, SergeyBiryukov, garethgillman.
Fixes #49320.

#8 @ianbelanger
6 years ago

  • Keywords fixed-major added
  • Milestone 5.5 → 5.4.2
  • Resolution fixed
  • Status closed → reopened

Reopening for backport.

#9 @whyisjake
6 years ago

  • Resolution → fixed
  • Status reopened → closed

In 47826:

Bundled Themes: Twenty Twenty image caption is not aligned center when image is, on the front-end.
Fixes the image caption alignment issue by adding text-align: center; to .wp-block-image .aligncenter figcaption.

This brings the changes from [47689] to the 5.4 branch.

Props markusthiel, SergeyBiryukov, garethgillman.
Fixes #49320.

Note: See TracTickets for help on using tickets.