redirect_canonical() removing trailing punctuation from any query string arg ending in p

[daveslaughter]

To reproduce add any query string with arg name ending p|page_id|cat|tag, and punctuation at the end of the value, e.g. "www.example.com/?comp=East+(North)"

Actual behaviour is to redirect to "www.example.com/?comp=East+(North".

Expected behaviour is to not redirect.

The problem is in the redirect_canonical function, specifically the regex to "Remove trailing spaces and end punctuation from certain terminating query string args.", which is

#(((p|page_id|cat|tag)=[^&]*?)($punctuation_pattern)+$#

The other regexes just after this code limit the query string args by making sure the complete arg name is checked, so the correct regex would be:

#((^|&)(p|page_id|cat|tag)=[^&]*?)($punctuation_pattern)+$#

[SergeyBiryukov]

Hi there, welcome to WordPress Trac! Thanks for the report and the patch.

Introduced in [41991].

[SergeyBiryukov]

In 47169:

Canonical: When removing trailing punctuation from query string arguments, match the whole query var name.

Props daveslaughter.
Fixes #49347.

[daveslaughter]

Thanks for sorting so quickly. This is my first bug report, and I must say I'm impressed with the speed and efficiency of the response.