WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

#49710 closed enhancement (fixed)

Twenty Twenty: Button block forces All Capital letters

Reported by: ianbelanger Owned by: ianbelanger
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit
Focuses: css Cc:

Description

Currently the button block in Twenty Twenty is forced to be All Caps. This should be changed so that the user can choose whether or not to use capital letters in a button.

Initially reported on GitHub by @paaljoachim: https://github.com/WordPress/gutenberg/issues/21144

Attachments (1)

49710.diff (2.3 KB) - added by ianbelanger 5 months ago.
Removes text-transform: uppercase; from button blocks

Download all attachments as: .zip

Change History (8)

@ianbelanger
5 months ago

Removes text-transform: uppercase; from button blocks

#1 @ianbelanger
5 months ago

  • Keywords has-patch needs-testing added; needs-patch removed

#2 @mukesh27
5 months ago

@ianbelanger The patch 49710.diff is working fine for me in version 5.4-RC4-47505

#3 @ianbelanger
5 months ago

  • Keywords commit added; needs-testing removed
  • Owner set to ianbelanger
  • Status changed from new to reviewing

Thanks for testing @mukesh27, I'm going to get this committed

#4 @ianbelanger
5 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47531:

Bundled Themes: Twenty Twenty Button block forces All Capital letters.

Removes text-transform: uppercase; from button blocks in order to give the user the option to have a button without All Capital letters.

Props mukesh27.
Fixes #49710.

#5 @ianbelanger
5 months ago

  • Keywords fixed-major added
  • Milestone changed from 5.5 to 5.4.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport

#6 @ianbelanger
5 months ago

  • Keywords fixed-major removed
  • Milestone changed from 5.4.1 to 5.5
  • Status changed from reopened to reviewing

Going to revert this commit after thinking about the change to current button blocks. Thanks to @joyously for bringing it to my attention.

@kjellr suggested adding an optional button block style for buttons that are not All Caps. This is probably a better option.

#7 @ianbelanger
5 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47534:

Bundled Themes: Twenty Twenty Button block forces All Capital letters - revert [47531].

Reverts [47531] to add text-transform: uppercase; back to button blocks.

Props joyously.
Fixes #49710.

Note: See TracTickets for help on using tickets.