WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 5 months ago

Last modified 5 months ago

#49798 closed enhancement (fixed)

Default WordPress favicon in dark mode browsers

Reported by: DhrRob Owned by: whyisjake
Milestone: 5.4.2 Priority: normal
Severity: normal Version: 5.4
Component: Customize Keywords: has-patch has-screenshots
Focuses: ui Cc:

Description

The default WordPress favicon added since 5.4 lacks a light background, causing it to look really odd in browsers that use dark mode. My suggestion would be to add light background, like wordpress.org does.

Attachments (4)

Annotation 2020-04-03 164232.png (1.3 KB) - added by DhrRob 7 months ago.
Screenshot of the favicon with a dark mode browser
w-logo-blue.png (7.4 KB) - added by DhrRob 7 months ago.
My suggestion for the new favicon, with an added white background inside the logo.
49798.diff (223 bytes) - added by audrasjb 7 months ago.
Customize: use a default favicon that better handles dark-mode browsers
Capture d’écran 2020-04-10 à 01.16.32.png (25.2 KB) - added by audrasjb 7 months ago.
New favicon

Download all attachments as: .zip

Change History (12)

@DhrRob
7 months ago

Screenshot of the favicon with a dark mode browser

@DhrRob
7 months ago

My suggestion for the new favicon, with an added white background inside the logo.

#1 @johnbillion
7 months ago

  • Component changed from Bootstrap/Load to Customize
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.4.1

#2 @johnbillion
7 months ago

Thanks for the report @DhrRob !

This ticket was mentioned in Slack in #core by whyisjake. View the logs.


7 months ago

@audrasjb
7 months ago

Customize: use a default favicon that better handles dark-mode browsers

#4 @audrasjb
7 months ago

  • Keywords has-patch has-screenshots added; needs-patch removed

Hi and welcome to WordPress Core Trac @DhrRob !

I agree, it’s not so readable on dark mode browsers.
49798.diff replaces the current favicon. @DhrRob I also compressed your proposed favicon from 7Kb to 2Kb.

Cheers,
Jb

Last edited 7 months ago by audrasjb (previous) (diff)

#5 @whyisjake
7 months ago

  • Owner set to whyisjake
  • Resolution set to fixed
  • Status changed from new to closed

In 47565:

Customize: Give the WordPress logo a white background for dark mode browsers.

The favicon is transparent, which would normally look fine, but on a dark background it washes out.

Bring the fix in r47564 to the 5.4 branch.

Props DhrRob, audrasjb.

Fixes #49798.

#6 @ocean90
5 months ago

  • Milestone changed from 5.4.1 to 5.4.2
  • Resolution fixed deleted
  • Status changed from closed to reopened

After [47832], [47564] should get reverted and the image added to wp-includes instead. Probably as a new image since it's also used for embeds.

#7 @SergeyBiryukov
5 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 47838:

Customize: Move the WordPress logo with a white background to the wp-includes directory.

This ensures that the image used as a default site icon looks good on a dark background.

The image was previously changed in the wp-admin directory, but the site icon is now loaded from wp-includes.

Follow-up to [36635], [47018], [47564], [47832].

Props ocean90.
Fixes #49798.

#8 @SergeyBiryukov
5 months ago

In 47839:

Customize: Move the WordPress logo with a white background to the wp-includes directory.

This ensures that the image used as a default site icon looks good on a dark background.

The image was previously changed in the wp-admin directory, but the site icon is now loaded from wp-includes.

Follow-up to [36635], [47018], [47564], [47832].

Props ocean90.
Merges [47838] to the 5.4 branch.
Fixes #49798.

Note: See TracTickets for help on using tickets.