The function get_self_link() in feed.php does not include the port

[damienwhaley]

Hi,

The function get_self_link() in /wp-includes/feed.php re-constructs the URL for the website. This is used for the atom site URL.

I have the situation where my WordPress site is running on a non-standard port. When the link for ATOM is constructed, it is missing the port.

As an example my site is running at ​https://wp.example.com:8080

But the get_self_link() prints it as ​https://wp.example.com

This might be solved by this change set: [45772]

Though in the time I spent looking it seems to be only used to generate the home root/home url of the site without any extra paths. It may or may not solve this problem correctly.

[Mte90]

Looking at the code ​https://github.com/WordPress/wordpress-develop/blob/master/src/wp-includes/feed.php#L626 there is also the problem that dens't support https

• Used the Scheme and Port Number that we are getting from the parse_url() function.

Trac ticket: https://core.trac.wordpress.org/ticket/50044

[Mte90]

@sh4lin the diff you attached include also changes in other part of wordpress and remove some tests.
The PR on github is fine, also the patch doesn't address the https.

[sh4lin]

@Mte90 I'll update the diff.

By default the URL scheme will be ​http:// but if there exists any scheme in the $host than it will use that.

I have tried this function on the website with ​https:// URL. and it is working.

Is my interpretation of your statement (the patch doesn't address the https.) correct?

Correct me if I am wrong.

Thank you so much.

[Mte90]

You are right, the patch check also the protocol.

[sh4lin]

has-patch

Trac ticket: https://core.trac.wordpress.org/ticket/50044

[mukesh27]

Added slight modern approach in ​PR #4503