Opened 8 months ago
Last modified 7 months ago
#50349 new defect (bug)
Plugin Update deletes plugin and showing "could not delete old plugin" message.
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Awaiting Review | Priority: | normal |
Severity: | normal | Version: | |
Component: | Plugins | Keywords: | |
Focuses: | Cc: |
Description
I just came across this on my local machine (Windows).
I had a plugin directory open in vscode editor. I had also previously edited one of the files in that plugin (added error_log
s in one of the functions for testing). I may or may not have had same file open with further unsaved changes (I don't know at this point).
In the Plugins page I clicked the "update now" in the plugin row (directory was still open in vscode).
The update resolved with a "Could not delete old plugin" error notice. However the plugin was removed and directory is left empty.
Change History (2)
#2
@
7 months ago
I'd like to start off by saying that this is not a major issue for me. I ran across this edge-case and figured I'd post a bug report - for the record. This did not impede my work in any meaningful way. Maybe it's an unimportant edge-case, maybe it touches upon a deeper implementation problem - I honestly don't know.
Nonetheless, if this issue is to be addressed:
- At the very least the message "Could not delete old plugin" is wrong. The old plugin was deleted. Empty plugin directory was all that remained.
- As for "expected" behaviour - my expectation would be that if the update failed, I'd still have the old version in place, and not have the plugin vanish unceremoniously. Or at least some indication that a plugin was removed due to an error (and what the plugin's basename was - allowing the user to troubleshoot). As it stands upon Plugins page refresh - everything appears normal sans the deleted plugin.
I've no idea as to the amount of work that would go into fixing this. Just laying it out.
I also had this happen a few times when attempting to update a plugin while one of its files was opened in an editor.
I believe this is working as intended though, since the OS doesn't allow for removing a directory with a locked file. What would be a suggested fix here?