WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 4 months ago

Last modified 4 months ago

#50350 closed defect (bug) (fixed)

Provide plugin and theme versions informations in auto-updates email notifications

Reported by: audrasjb Owned by: desrosj
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch has-screenshots commit
Focuses: Cc:

Description

It would be useful to provide version informations in the themes and plugins auto-updates email notification.

Probably something like:

The following plugins were successfully updated:

  • Hello Dolly (from 1.7 to 1.7.1)

Attachments (2)

50350.2.diff (1.6 KB) - added by audrasjb 4 months ago.
Upgrade/install: Add version information to auto-updates email notifications
Capture d’écran 2020-07-16 à 23.43.47.png (23.5 KB) - added by audrasjb 4 months ago.
Email notification received during tests

Download all attachments as: .zip

Change History (19)

#1 @audrasjb
6 months ago

  • Keywords needs-patch added
  • Type changed from defect (bug) to enhancement

#3 @pbiron
6 months ago

Quoting from the referenced GitHub issue:

Including the version updated FROM would help admins manually rollback if they later discover the update causes problems on the site (it's pretty likely they won't remember what version they were running before the update).

#4 @stuffradio
5 months ago

Further to discussions on #50268,

I agree it would sound more professional to change the word "Howdy", to "Hello".

So instead of something like

<?php
                        $body[]  = sprintf(
                                /* translators: %s: Home URL. */
                                __( 'Howdy! Failures occurred when attempting to update plugins/themes on your site at %s.', 'wp-autoupdates' ),
                                home_url()
                        );

We would instead have something like

<?php
                        $body[]  = sprintf(
                                /* translators: %s: Home URL. */
                                __( 'Hello,', 'wp-autoupdates' )
                        );
                        $body[] = "\n";
                        $body[]  = sprintf(
                                /* translators: %s: Home URL. */
                                __( 'Failures occurred when attempting to update plugins/themes on your site at %s.', 'wp-autoupdates' ),
                                home_url()
                        );

@audrasjb

Last edited 5 months ago by stuffradio (previous) (diff)

#5 @audrasjb
5 months ago

@stuffradio thanks!
This is not in this ticket's scope, because there is a bunch of other use of "Howdy!" in WordPress. This should be handled in a dedicated ticket.
For now, let's keep it as it for consistency with other email notification in WordPress core :)

#6 @davidbaumwald
5 months ago

  • Milestone changed from 5.5 to Future Release

With 5.5 Beta 1 releasing tomorrow ans this still needing a refresh and a review, this is being moved to Future Release. If any maintainer or committer feels the remainder of this ticket can be resolved in time, or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

@audrasjb
4 months ago

Upgrade/install: Add version information to auto-updates email notifications

@audrasjb
4 months ago

Email notification received during tests

#7 @audrasjb
4 months ago

  • Keywords has-patch has-screenshots added; needs-patch removed

#8 @audrasjb
4 months ago

  • Milestone changed from Future Release to 5.5
  • Type changed from enhancement to defect (bug)

#9 @pbiron
4 months ago

  • Keywords commit added

patch looks good to me.

#10 @desrosj
4 months ago

  • Owner set to desrosj
  • Status changed from new to reviewing

#11 @desrosj
4 months ago

The original suggestion was to include the version being updated from and the new version.

Was there a discussion around this that lead to the current patch without the previous version?

#12 @pbiron
4 months ago

Yes, that was the original suggestion. However, by the time the email is generated, the version updated FROM is not available.

So, in the weekly meeting on Jun 30, it was decided to add TO for 5.5, and work on FROM in 5.6.

#13 @desrosj
4 months ago

Great. Thanks, @pbiron! I just wanted to make sure I had that context.

#14 @desrosj
4 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 48517:

Administration: Include the new plugin and theme versions in email notifications.

This helps administrators keep track of which versions of plugins and themes are running on their site when auto-updates occur.

Props audrasjb, pbiron.
Fixes #50350.

#15 @pbiron
4 months ago

@desrosj should this ticket be opened up again for adding the FROM version in 5.6? Or should we create another ticket for that?

#16 @desrosj
4 months ago

@pbiron New ticket please! That way this one can stay in the milestone for future WordPress archaeologists!

#17 @SergeyBiryukov
4 months ago

In 48519:

I18N: Mark the strings with plugin and theme names in email notifications for translation.

Follow-up to [48517].

See #50350.

Note: See TracTickets for help on using tickets.