WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#50707 closed defect (bug) (fixed)

i18n: Add missing dot at the end of the sentence

Reported by: ramiy's profile ramiy Owned by: whyisjake's profile whyisjake
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-screenshots has-patch reporter-feedback
Focuses: accessibility Cc:

Description

Update translation string - add missing dot at the end of the sentence.

See the attached screenshot.

Attachments (3)

50707.png​ (49.0 KB) - added by ramiy 4 years ago.
50707.patch​ (686 bytes) - added by ramiy 4 years ago.
50707.diff​ (704 bytes) - added by whyisjake 4 years ago.

Download all attachments as: .zip

Change History (11)

@ramiy
4 years ago

@ramiy
4 years ago

#1 @ramiy
4 years ago

  • Keywords has-screenshots has-patch added

The the attached screenshot, there are two similar translation strings.

#2 @afercia
4 years ago

  • Focuses accessibility added

I'm guessing (most of) these strings are used for audible messages for assistive technologies via wp.a11y.speak(). If that's the case, they really don't need a dot at the end. Actually, the dot may be annoying for screen reader users as it may be announced as "dot".

#3 @ramiy
4 years ago

In that case, we should remove the dot from the other string.

This ticket was mentioned in ​Slack in #core by ramiy. ​View the logs.
4 years ago

#5 @audrasjb
4 years ago

  • Keywords reporter-feedback added

Yes, but the other string is not used in the wp.a11y.speak() context, it is used inside a normal sentence so it needs the final dot.

#6 @whyisjake
4 years ago

  • Owner set to whyisjake
  • Status changed from new to accepted

#7 @whyisjake
4 years ago

  • Milestone changed from Awaiting Review to 5.5

@whyisjake
4 years ago

#8 @whyisjake
4 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 48567:

I18N: Update some strings to have periods.

Fixes #50707.
Props ramiy, afercia, audrasjb.

Note: See TracTickets for help on using tickets.