wp_set_script_translations() ignores failure when called before script is registered.

[tellyworth]

wp_set_script_translations() only works if it's called after the script has already been registered. The doc page confirms this: ​https://developer.wordpress.org/reference/functions/wp_set_script_translations/. The function does trigger _doing_it_wrong when called prior to wp_register_scripts, but fails silently when called before the specific script has been registered.

In investigating js translation issues in the plugin directory, we discovered that it is very common for developers to incorrectly call wp_set_script_translations() too early. As a result, js translations are not correctly loaded for many plugins.

This would be easily fixed by having wp_set_script_translations() trigger _doing_it_wrong when $wp_scripts->set_translations() returns false.

[swissspidy]

This would be easily fixed by having wp_set_script_translations() trigger _doing_it_wrong when $wp_scripts->set_translations() returns false.

Note that $wp_scripts->set_translations() will also return false if the domain is not a string. That would be an easy checck to add to wp_set_script_translations as well.

Trigger _doing_it_wrong() when passed $domain is not a string and if $wp_scripts->set_translations() returns false.

Trac ticket: https://core.trac.wordpress.org/ticket/50749

[donmhico]

@tellyworth would be great if you can check if my patch corrects the issue? Also the $message passed to _doing_it_wrong could be improved. Thank you!

[swissspidy]

Worth noting that wp_add_inline_script() doesn't emit a warning either.

Instead of silently failing we could also just make it work.

See #41990