WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#50776 closed defect (bug) (fixed)

Translatable string inconsistency in `get_item_schema`

Reported by: audrasjb's profile audrasjb Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.5 Priority: normal
Severity: normal Version: 5.5
Component: I18N Keywords: has-patch
Focuses: rest-api Cc:

Description

There is a small inconsistency in two translatable strings.

In class-wp-rest-themes-controller.php, texdomain description text is "The theme\'s textdomain.", and in class-wp-rest-plugins-controller.php, it's "The plugin\'s text domain".

Let's use "text domain" on both places.

Attachments (1)

50776.diff​ (662 bytes) - added by audrasjb 4 years ago.
I18N: Fix an inconsistency in a translation string on the REST API.

Download all attachments as: .zip

Change History (5)

@audrasjb
4 years ago

I18N: Fix an inconsistency in a translation string on the REST API.

#1 @audrasjb
4 years ago

  • Keywords has-patch added; needs-patch removed

#2 @SergeyBiryukov
4 years ago

The name of the property itself is also inconsistent, text_domain vs. textdomain.

Let's use textdomain in both, for consistency with the one in WP_REST_Block_Types_Controller.

#3 @SergeyBiryukov
4 years ago

In 48627:

REST API: Use a consistent name for the textdomain schema property between plugins, themes, and block directory controllers.

Follow-up to [48242].

See #50321, #50776.

#4 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 48628:

REST API: Use a consistent description for the textdomain schema property between plugins and themes controllers.

Follow-up to [48242], [48627].

Props audrasjb.
Fixes #50776. See #50321.

Note: See TracTickets for help on using tickets.