Success Message Displays on Failure to Update Site Address

[megabyterose]

There's a misleading success message, "Site info updated" that displays on page refresh after you attempt to update an individual site's address to one that is already in use.

(I'll attach a screen recording of an example!)

[megabyterose]

Screen recording of updating a site address to an already-existing address, which shows success message but should be an error message.

[megabyterose]

For clarification on the example recording, 20041465.travsearch.com already existed within the network when I attempted to rename travsearch.com/20041465 to 20041465.travsearch.com. This is the example that made me discover the bug (the success message instead of an error).

Here I'm adding a new class for the dashboard notice class, as we have "notice" even if the update fails.
In addition to that adding a new check if update_blog_details() returns, as it's returning only false.

I guess the code would need some refactoring and we can place a few apply_filters() for future extendibility, but wanted to share the first version first.

Trac ticket: https://core.trac.wordpress.org/ticket/50814

[metodiew]

Hey hey, I've added a new pull request for this ticket and sharing the PR message here as well. Open to feedback for the approach!

Here I'm adding a new class for the dashboard notice class, as we have notice even if the update fails.
In addition to that adding a new check if update_blog_details() as it's returning only false.

I guess the code would need some refactoring and we can place a few apply_filters() for future extendibility, but wanted to share the first version first.