WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#50826 closed defect (bug) (fixed)

Wrong Escaping Function Was Used

Reported by: chintan1896's profile chintan1896 Owned by:
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: Widgets Keywords: has-patch
Focuses: Cc:

Description

Wrong Escaping Function Was Used in wp-includes/blocks/archives.php.

Attachments (2)

50826.diff​ (581 bytes) - added by chintan1896 4 years ago.
50826.1.diff​ (1.2 KB) - added by chintan1896 4 years ago.
I have attached updated patch with change in both files

Download all attachments as: .zip

Change History (10)

@chintan1896
4 years ago

#1 @afercia
4 years ago

  • Component changed from General to Widgets
  • Keywords needs-patch added; has-patch removed
  • Version trunk deleted

Good catch @chintan1896

As far as I see, this should be fixed both in the Gutenberg repo:
​https://github.com/WordPress/gutenberg/blob/be014202a75449c0afc384f71835c04a048e53e2/packages/block-library/src/archives/index.php#L69

and in the core widget:
https://core.trac.wordpress.org/browser/trunk/src/wp-includes/widgets/class-wp-widget-archives.php?rev=48410#L106

@chintan1896
4 years ago

I have attached updated patch with change in both files

#2 @chintan1896
4 years ago

Hey @afercia

Thanks, I have attached updated patch 50826.1.diff. I don't have knowledge about gutenberg work flow.

#3 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 5.6

#4 @SergeyBiryukov
4 years ago

  • Keywords has-patch added; needs-patch removed

#5 @SergeyBiryukov
4 years ago

In 48699:

Widgets: Use correct escaping function in WP_Widget_Archives::widget().

Props chintan1896, afercia.
See #50826.

#6 @SergeyBiryukov
4 years ago

Thanks for the patch! The instance in wp-includes/widgets/class-wp-widget-archives.php is now fixed.

For the instance in wp-includes/blocks/archives.php, could you please submit a PR upstream to the Gutenberg's ​bloсk library package? Thanks!

#8 @audrasjb
4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

This issue has been fixed upstream: ​https://github.com/WordPress/gutenberg/pull/25476

Closing this ticket as fixed.

Note: See TracTickets for help on using tickets.