#50845 closed defect (bug) (fixed)
Block patterns: Fix translatable strings (take 2)
Reported by: | SergeyBiryukov | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 5.5.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Editor | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Background: #50842
Reported by @tobifjellner:
I got this screenshot from @nabilmoqbel
Seems to be more hardcoded stuff in sample content.
Not sure this can be addressed in time for 5.5, so setting the milestone to 5.5.1 for now.
Attachments (4)
Change History (14)
#1
@
4 years ago
Just look and yes, the strings are hardcoded. Working on a patch for the blocks in the screenshots and also looking at investigating others block patterns.
#4
@
4 years ago
- Keywords commit added
- Owner set to audrasjb
- Status changed from new to accepted
Thanks @justinahinon, the patch looks good to me but it wasn't generated against wordpress-develop, so it's pretty hard to apply to WP Core dev environment. I added a new patch based on what you did and I checked all the patterns: you identified all the patterns with issues regarding i18n, thanks.
Marking this for commit
action.
#5
@
4 years ago
This also needs to be fixed upstream in Gutenberg. See #50842 for example, which was a backport of https://github.com/WordPress/gutenberg/pull/24317 for https://github.com/WordPress/gutenberg/issues/24316.
#6
@
4 years ago
Replying to SergeyBiryukov:
This also needs to be fixed upstream in Gutenberg.
Opened an issue https://github.com/WordPress/gutenberg/issues/24646.
Here's the PR: https://github.com/WordPress/gutenberg/pull/24647.
Read now button