Twenty Sixteen: Add Block Patterns

[melchoyce]

With block patterns introduced in WordPress 5.5, we now have the opportunity to add some patterns to our older default themes.

Let's consider adding some patterns to Twenty Sixteen.

@iamtakashi, since you were the designer for the theme, would love to get your input here.

[melchoyce]

Some potential quote pattern ideas.

[melchoyce]

Additional pattern ideas.

[melchoyce]

Fixed third quote (screenshot didn't grab the image for some reason?)

[beafialho]

I've worked on a few more block patterns:
​https://cloudup.com/cVOZHsRwZPB

Trac ticket: https://core.trac.wordpress.org/ticket/51101

[hellofromTonya]

In talking with @melchoyce and the core-theme team, we are punting this ticket to Future Release.

If any maintainer or committer feels this can be resolved in time, or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

[ryelle]

I've left ​a review on the PR.

Tested all with trunk, with & without gutenberg (master) active. They all worked without validation errors 👍

The "Large Blockquote" pattern looks great in the editor, but on the frontend it's got some uneven space on the top & bottom

[screenshots on github]

Updates #549.

• Escapes text strings and makes them translatable.
• Tidies up front-end spacing for the "Large blockquote" pattern (It will appear slightly off-centered vertically in the editor, but I think that's better than the alternative).
• Opts in to custom line height, since it is used in one of the patterns.

Trac ticket: https://core.trac.wordpress.org/ticket/51101

[kjellr]

I added a new patch [on GitHub ​https://github.com/WordPress/wordpress-develop/pull/610]. This fixes the issues in the earlier one, and also makes the text strings tranlatable. I'm going to add Needs Copy to this one, since the other block-patterns PRs have that label too.

Here are current screenshots:

[karmatosed]

I'm changing this milestone as it looks really close to me so could be great to get in.

[jffng]

LGTM, although where did the Big Title with Two-Columns text copy come from? It looks generated, nearly gibberish.

[helen]

I am not deeply concerned about getting this in before beta so I am marking as a task.

[melchoyce]

Yeah, let's get some new copy for the Big Title with Two Columns pattern.

[bridgetwillard]

From placeholder text in GitHub

​https://github.com/WordPress/wordpress-develop/pull/610/commits/9940ee31f309bd470fc4df4d582e87b957fbd93f

Suggested Edit

'Twenty Sixteen is a modern take on the horizontal masthead with an optional right sidebar. It works perfectly for WordPress websites and blogs.'

Currently says: 'Twenty Sixteen is a modernized take on an ever-popular WordPress layout — the horizontal masthead with an optional right sidebar that works perfectly for blogs and websites.' (line 34)

Suggested Edit

'Twenty Sixteen will make your WordPress website look beautiful everywhere. Take advantage of custom color options, beautiful default color schemes, a harmonious fluid grid using a mobile-first approach, and impeccable polish in every detail.'

Currently says: 'It has custom color options with beautiful default color schemes, a harmonious fluid grid using a mobile-first approach, and impeccable polish in every detail. Twenty Sixteen will make your WordPress look beautiful everywhere.' (Line 37)

Suggested Edit

It looks like the default blog post is from Chapter 3 of this Open Source Novel. So I'm going to suggest edits.

​https://www.gutenberg.org/files/2021/2021-h/2021-h.htm

[kjellr]

Thank you again, @bridgetwillard! I made the copy edits on GitHub.

As others have noted above, the Josepha Conrad text seems a little weird here. So I also replaced that with a riff on the rest of the copy used here.

I made tiny edits to the Call to Action pattern too — I removed the mention of Amazon (it seemed weird to feature that), and I changed the book title to "Twenty Sixteen" so it relates more to the rest of the pattern copy.

Let me know if anyone has any thoughts or objections to those updates. Thank you!

[bridgetwillard]

You rock @kjellr. Looks great to me.

[poena]

I have tested the patterns and the code looks good as well.

These patterns do not have descriptions, but because of the new categories (you now select them from the drop down instead of one long list with all patterns) it might not be needed.

[SergeyBiryukov]

In 49583:

Bundled Themes: Introduce block patterns for Twenty Sixteen.

Props melchoyce, kjellr, onemaggie, ryelle, beafialho, bridgetwillard, poena, jffng.
Fixes #51101.

Resolved in changeset https://core.trac.wordpress.org/changeset/49583

Resolved in changeset https://core.trac.wordpress.org/changeset/49583