WordPress.org

Make WordPress Core

Opened 16 months ago

Closed 13 months ago

Last modified 13 months ago

#51101 closed task (blessed) (fixed)

Twenty Sixteen: Add Block Patterns

Reported by: melchoyce Owned by: SergeyBiryukov
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch has-copy-review commit
Focuses: Cc:

Description

With block patterns introduced in WordPress 5.5, we now have the opportunity to add some patterns to our older default themes.

Let's consider adding some patterns to Twenty Sixteen.

@iamtakashi, since you were the designer for the theme, would love to get your input here.

Attachments (3)

2016-patterns-quotes.png (248.6 KB) - added by melchoyce 15 months ago.
Some potential quote pattern ideas.
2016-patterns-misc.png (50.6 KB) - added by melchoyce 15 months ago.
Additional pattern ideas.
Screen Shot 2020-09-03 at 6.18.52 PM.png (287.8 KB) - added by melchoyce 15 months ago.
Fixed third quote (screenshot didn't grab the image for some reason?)

Download all attachments as: .zip

Change History (24)

@melchoyce
15 months ago

Some potential quote pattern ideas.

@melchoyce
15 months ago

Additional pattern ideas.

@melchoyce
15 months ago

Fixed third quote (screenshot didn't grab the image for some reason?)

This ticket was mentioned in Slack in #design by melchoyce. View the logs.


15 months ago

#2 @beafialho
15 months ago

I've worked on a few more block patterns:
https://cloudup.com/cVOZHsRwZPB

This ticket was mentioned in PR #549 on WordPress/wordpress-develop by MaggieCabrera.


15 months ago

  • Keywords has-patch added

This ticket was mentioned in Slack in #core-themes by hellofromtonya. View the logs.


14 months ago

#5 @hellofromTonya
14 months ago

  • Milestone changed from 5.6 to Future Release

In talking with @melchoyce and the core-theme team, we are punting this ticket to Future Release.

If any maintainer or committer feels this can be resolved in time, or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

#6 @ryelle
14 months ago

I've left a review on the PR.

Tested all with trunk, with & without gutenberg (master) active. They all worked without validation errors 👍

The "Large Blockquote" pattern looks great in the editor, but on the frontend it's got some uneven space on the top & bottom

[screenshots on github]

This ticket was mentioned in PR #610 on WordPress/wordpress-develop by kjellr.


14 months ago

Updates #549.

  • Escapes text strings and makes them translatable.
  • Tidies up front-end spacing for the "Large blockquote" pattern (It will appear slightly off-centered vertically in the editor, but I think that's better than the alternative).
  • Opts in to custom line height, since it is used in one of the patterns.

Trac ticket: https://core.trac.wordpress.org/ticket/51101

#8 @kjellr
14 months ago

  • Keywords needs-copy-review added; needs-design removed

I added a new patch [on GitHub https://github.com/WordPress/wordpress-develop/pull/610]. This fixes the issues in the earlier one, and also makes the text strings tranlatable. I'm going to add Needs Copy to this one, since the other block-patterns PRs have that label too.

Here are current screenshots:

http://cldup.com/c5HCYKSIuf.png

https://cldup.com/Nz3wVXHUqz.png

#9 @karmatosed
14 months ago

  • Milestone changed from Future Release to 5.6

#10 @karmatosed
14 months ago

I'm changing this milestone as it looks really close to me so could be great to get in.

#11 @jffng
14 months ago

LGTM, although where did the Big Title with Two-Columns text copy come from? It looks generated, nearly gibberish.

#12 @helen
14 months ago

  • Type changed from enhancement to task (blessed)

I am not deeply concerned about getting this in before beta so I am marking as a task.

#13 @melchoyce
14 months ago

Yeah, let's get some new copy for the Big Title with Two Columns pattern.

#14 @bridgetwillard
13 months ago

  • Keywords has-copy-review added; needs-copy-review removed

From placeholder text in GitHub

https://github.com/WordPress/wordpress-develop/pull/610/commits/9940ee31f309bd470fc4df4d582e87b957fbd93f

Suggested Edit

'Twenty Sixteen is a modern take on the horizontal masthead with an optional right sidebar. It works perfectly for WordPress websites and blogs.'

Currently says: 'Twenty Sixteen is a modernized take on an ever-popular WordPress layout — the horizontal masthead with an optional right sidebar that works perfectly for blogs and websites.' (line 34)

Suggested Edit

'Twenty Sixteen will make your WordPress website look beautiful everywhere. Take advantage of custom color options, beautiful default color schemes, a harmonious fluid grid using a mobile-first approach, and impeccable polish in every detail.'

Currently says: 'It has custom color options with beautiful default color schemes, a harmonious fluid grid using a mobile-first approach, and impeccable polish in every detail. Twenty Sixteen will make your WordPress look beautiful everywhere.' (Line 37)

Suggested Edit

It looks like the default blog post is from Chapter 3 of this Open Source Novel. So I'm going to suggest edits.

https://www.gutenberg.org/files/2021/2021-h/2021-h.htm

#15 @kjellr
13 months ago

Thank you again, @bridgetwillard! I made the copy edits on GitHub.

As others have noted above, the Josepha Conrad text seems a little weird here. So I also replaced that with a riff on the rest of the copy used here.

I made tiny edits to the Call to Action pattern too — I removed the mention of Amazon (it seemed weird to feature that), and I changed the book title to "Twenty Sixteen" so it relates more to the rest of the pattern copy.

Let me know if anyone has any thoughts or objections to those updates. Thank you!

http://cldup.com/0AAjcIlLsT.png

#16 @bridgetwillard
13 months ago

You rock @kjellr. Looks great to me.


This ticket was mentioned in Slack in #core-themes by hellofromtonya. View the logs.


13 months ago

#18 @poena
13 months ago

  • Keywords commit added

I have tested the patterns and the code looks good as well.

These patterns do not have descriptions, but because of the new categories (you now select them from the drop down instead of one long list with all patterns) it might not be needed.

#19 @SergeyBiryukov
13 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 49583:

Bundled Themes: Introduce block patterns for Twenty Sixteen.

Props melchoyce, kjellr, onemaggie, ryelle, beafialho, bridgetwillard, poena, jffng.
Fixes #51101.

Note: See TracTickets for help on using tickets.