WordPress.org

Make WordPress Core

Opened 14 months ago

Closed 5 months ago

Last modified 5 months ago

#51102 closed enhancement (fixed)

Twenty Fifteen: Add Block Patterns

Reported by: melchoyce Owned by: ryelle
Milestone: 5.8 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch needs-copy-review needs-dev-note needs-codex
Focuses: Cc:

Description

With block patterns introduced in WordPress 5.5, we now have the opportunity to add some patterns to our older default themes.

Let's consider adding some patterns to Twenty Fifteen.

@iamtakashi, since you were the designer for the theme, would love to get your input here.

Attachments (1)

2015-patterns.png (1.7 MB) - added by melchoyce 14 months ago.

Download all attachments as: .zip

Change History (15)

This ticket was mentioned in Slack in #design by melchoyce. View the logs.


14 months ago

#2 @hellofromTonya
13 months ago

  • Milestone changed from 5.6 to Future Release

With Beta 1 for 5.6 landing in less than 2 weeks, punting this ticket to Future Release. If any maintainer or committer feels this can be resolved in time, or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

#3 @kjellr
9 months ago

@melchoyce thanks for the comps here. I think these ones would make a nice, simple first set of patterns for the theme:

https://cldup.com/fUl3yA9ajk.png

Do you have the block markup + images for these handy by any chance? I can get a patch started this week.

This ticket was mentioned in PR #999 on WordPress/wordpress-develop by kjellr.


9 months ago

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/51102

Adds a set of bundled block patterns for the Twenty Fifteen Theme.

Screenshots

https://i0.wp.com/user-images.githubusercontent.com/1202812/107803918-472eb300-6d31-11eb-9f09-978c0b483ac0.png

https://i0.wp.com/user-images.githubusercontent.com/1202812/107804140-8c52e500-6d31-11eb-9ee4-95e80208b0ce.png

#5 @kjellr
9 months ago

  • Keywords needs-copy-review added; needs-design removed

I've added a patch!

Some of the text looked to be from "The War of the Worlds", which should be fine to use since it's public domain. But in general, I'd love if someone could take a look at the copy and recommend any changes. I've added needs-copy-review to the ticket.

#6 @desrosj
8 months ago

  • Milestone changed from Future Release to 5.8

I'm going to move this to 5.8. But, if they are ready sooner we can move this to 5.7.1 (or if that's not realistic, please do move this back Future Release).

We can also release an update detached from a specific WordPress release as we did in December.

#7 @onemaggie
5 months ago

I just gave a pass to this one and replaced esc_html with esc_attr on the alt texts, besides that, I think this one is fine @kjellr @poena

#8 @kjellr
5 months ago

Thanks for helping out, @onemaggie! These look good — I think they're ready to go.

This ticket was mentioned in Slack in #core-themes by kjell. View the logs.


5 months ago

#10 @lukecarbis
5 months ago

The decision was made on Slack to keep this (and other theme pattern tickets) open after the feature freeze date.

https://wordpress.slack.com/archives/C01VACX5E2W/p1621972702066300

Last edited 5 months ago by lukecarbis (previous) (diff)

This ticket was mentioned in Slack in #core-themes by kjell. View the logs.


5 months ago

#12 @ryelle
5 months ago

  • Owner set to ryelle
  • Resolution set to fixed
  • Status changed from new to closed

In 51043:

Bundled Themes: Introduce block patterns for Twenty Fifteen.

Props melchoyce, kjellr, onemaggie.
Fixes #51102.

#13 @prbot
5 months ago

ryelle commented on PR #999:

This was committed in r51043.

#14 @milana_cap
5 months ago

  • Keywords needs-dev-note needs-codex added
Note: See TracTickets for help on using tickets.