Twenty Fourteen: Add Block Patterns

[melchoyce]

With block patterns introduced in WordPress 5.5, we now have the opportunity to add some patterns to our older default themes.

Let's consider adding some patterns to Twenty Fourteen.

@iamtakashi, since you were the designer for the theme, would love to get your input here.

[hellofromTonya]

With Beta 1 for 5.6 landing in less than 2 weeks, punting this ticket to Future Release. If any maintainer or committer feels this can be resolved in time, or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

[beafialho]

Here are some block pattern design proposals:
​https://cloudup.com/ciWstplePgD

[kjellr]

Thanks @beafialho! I like these ones the best:

I like this last one too, but I wonder if it could be a little shorter?

[melchoyce]

Agreed, I think those patterns show off blocks the best.

[beafialho]

@kjellr yes, I made it shorter: ​https://cloudup.com/cpqATvr9ih4

[kjellr]

Awesome, that looks great. Thank you!

Trac ticket: https://core.trac.wordpress.org/ticket/51103

---

This PR adds block patterns to Twenty Fourteen, along with the associated images.

Screenshots:

[kjellr]

@beafialho + @melchoyce I pushed a patch that includes these patterns. I edited the copy a bit to eliminate the Lorem Ipsum, and I also curated the images a bit so that they had a little more of a dreamy/nostalgia feel to them. Let me know if those work from your perspective!

[kjellr]

I'm also going to add "Needs Copy Review" here to get some additional eyes on the text!

[beafialho]

@kjellr thank you, they all look great!

[desrosj]

I'm going to move this to 5.8. But, if they are ready sooner we can move this to 5.7.1 (or if that's not realistic, move to Future Release).

We can also release an update detached from a specific WordPress release as we ​did in December.

[poena]

When I test the PR with Gutenberg version 10.7 RC1 only two patterns show up, the contact and summary.
I will follow this up with an issue on the Gutenberg GitHub repo ​https://github.com/WordPress/gutenberg/issues/32139

[onemaggie]

Updated the alt texts with esc_attr on this one too. Looks good to go.

[kjellr]

Thanks @onemaggie. Assuming that issue @poena found is a Gutenberg one, I agree this should be ready to go too.

[poena]

It just looks like the format of the
content inside register_block_pattern is handled stricter.
Without response from the editor team, this might well be intentional.

There is additional spacing between the blocks in the block markup in the patterns that are not showing. That can be fixed in the themes.

And themes that uses array() to separate the pattern content into individual lines does not have this problem.

[jffng]

I can confirm what @poena said re: TwentyFourteen patterns — removing the line breaks fixes the issue, and all four patterns appear.

I have a commit that does this @kjellr if you want to give me permission to your wordpress-develop fork to update the PR + diff.

[kjellr]

Go for it, thanks @jffng!

[lukecarbis]

The decision was made on Slack to keep this (and other theme pattern tickets) open after the feature freeze date.

​https://wordpress.slack.com/archives/C01VACX5E2W/p1621972702066300

[jffng]

We made a small change to ensure the text color was visible in one of the patterns. I gave them all another test, and they appear ready to land.

[ryelle]

In 51045:

Bundled Themes: Introduce block patterns for Twenty Fourteen.

Props beafialho, kjellr, melchoyce, onemaggie, poena, jffng, jeffikus.
Fixes #51103.

This was committed in r51045.