Make WordPress Core

Opened 4 years ago

Closed 3 years ago

Last modified 3 years ago

#51103 closed enhancement (fixed)

Twenty Fourteen: Add Block Patterns

Reported by: melchoyce's profile melchoyce Owned by: ryelle's profile ryelle
Milestone: 5.8 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch needs-copy-review needs-codex needs-dev-note
Focuses: Cc:


With block patterns introduced in WordPress 5.5, we now have the opportunity to add some patterns to our older default themes.

Let's consider adding some patterns to Twenty Fourteen.

@iamtakashi, since you were the designer for the theme, would love to get your input here.

Change History (25)

This ticket was mentioned in Slack in #design by melchoyce. View the logs.

4 years ago

#2 @hellofromTonya
4 years ago

  • Milestone changed from 5.6 to Future Release

With Beta 1 for 5.6 landing in less than 2 weeks, punting this ticket to Future Release. If any maintainer or committer feels this can be resolved in time, or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

#3 @beafialho
4 years ago

Here are some block pattern design proposals:

#4 follow-up: @kjellr
4 years ago

Thanks @beafialho! I like these ones the best:

I like this last one too, but I wonder if it could be a little shorter?

#5 @melchoyce
4 years ago

Agreed, I think those patterns show off blocks the best.

#6 in reply to: ↑ 4 @beafialho
4 years ago

@kjellr yes, I made it shorter:

#7 @kjellr
4 years ago

Awesome, that looks great. Thank you!

This ticket was mentioned in PR #1006 on WordPress/wordpress-develop by kjellr.

3 years ago

  • Keywords has-patch added

Trac ticket:


This PR adds block patterns to Twenty Fourteen, along with the associated images.


#9 follow-up: @kjellr
3 years ago

@beafialho + @melchoyce I pushed a patch that includes these patterns. I edited the copy a bit to eliminate the Lorem Ipsum, and I also curated the images a bit so that they had a little more of a dreamy/nostalgia feel to them. Let me know if those work from your perspective!

#10 @kjellr
3 years ago

  • Keywords needs-copy-review added; needs-design removed

I'm also going to add "Needs Copy Review" here to get some additional eyes on the text!

#11 in reply to: ↑ 9 @beafialho
3 years ago

@kjellr thank you, they all look great!

#12 @desrosj
3 years ago

  • Milestone changed from Future Release to 5.8

I'm going to move this to 5.8. But, if they are ready sooner we can move this to 5.7.1 (or if that's not realistic, move to Future Release).

We can also release an update detached from a specific WordPress release as we did in December.

#13 @poena
3 years ago

When I test the PR with Gutenberg version 10.7 RC1 only two patterns show up, the contact and summary.
I will follow this up with an issue on the Gutenberg GitHub repo

Last edited 3 years ago by poena (previous) (diff)

#14 @onemaggie
3 years ago

Updated the alt texts with esc_attr on this one too. Looks good to go.

#15 @kjellr
3 years ago

Thanks @onemaggie. Assuming that issue @poena found is a Gutenberg one, I agree this should be ready to go too.

#16 @poena
3 years ago

It just looks like the format of the
content inside register_block_pattern is handled stricter.
Without response from the editor team, this might well be intentional.

There is additional spacing between the blocks in the block markup in the patterns that are not showing. That can be fixed in the themes.

And themes that uses array() to separate the pattern content into individual lines does not have this problem.

This ticket was mentioned in Slack in #core-themes by kjell. View the logs.

3 years ago

#18 @jffng
3 years ago

I can confirm what @poena said re: TwentyFourteen patterns — removing the line breaks fixes the issue, and all four patterns appear.

I have a commit that does this @kjellr if you want to give me permission to your wordpress-develop fork to update the PR + diff.

#19 @kjellr
3 years ago

Go for it, thanks @jffng!

#20 @lukecarbis
3 years ago

The decision was made on Slack to keep this (and other theme pattern tickets) open after the feature freeze date.

This ticket was mentioned in Slack in #core-themes by kjell. View the logs.

3 years ago

#22 @jffng
3 years ago

We made a small change to ensure the text color was visible in one of the patterns. I gave them all another test, and they appear ready to land.

#23 @ryelle
3 years ago

  • Owner set to ryelle
  • Resolution set to fixed
  • Status changed from new to closed

In 51045:

Bundled Themes: Introduce block patterns for Twenty Fourteen.

Props beafialho, kjellr, melchoyce, onemaggie, poena, jffng, jeffikus.
Fixes #51103.

ryelle commented on PR #1006:

3 years ago

This was committed in r51045.

#25 @milana_cap
3 years ago

  • Keywords needs-codex needs-dev-note added
Note: See TracTickets for help on using tickets.