Make WordPress Core

Opened 4 years ago

Closed 3 years ago

Last modified 2 months ago

#51105 closed enhancement (fixed)

Twenty Twelve: Add Block Patterns

Reported by: melchoyce's profile melchoyce Owned by: ryelle's profile ryelle
Milestone: 5.8 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch needs-dev-note needs-codex
Focuses: Cc:

Description

With block patterns introduced in WordPress 5.5, we now have the opportunity to add some patterns to our older default themes.

Let's consider adding some patterns to Twenty Twelve.

Attachments (5)

51105.diff (10.3 KB) - added by melchoyce 3 years ago.
images.2.zip (188.6 KB) - added by melchoyce 3 years ago.
51105.2.diff (10.4 KB) - added by onemaggie 3 years ago.
51105.3.diff (10.5 KB) - added by onemaggie 3 years ago.
51105.4.diff (10.7 KB) - added by ryelle 3 years ago.

Download all attachments as: .zip

Change History (19)

This ticket was mentioned in Slack in #design by melchoyce. View the logs.


4 years ago

#2 @hellofromTonya
4 years ago

  • Milestone changed from 5.6 to Future Release

With Beta 1 for 5.6 landing in less than 2 weeks, punting this ticket to Future Release. If any maintainer or committer feels this can be resolved in time, or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

#3 @beafialho
4 years ago

I have designed some more block patterns for Twenty Twelve.
Here are them: https://cloudup.com/ciLhz5MVaxl

#4 @kjellr
4 years ago

Those are great @beafialho! I like the floating images one especially.

Do you have a preference between the two quotes ones? They're both so similar that I think we should include just one of them.

#5 @beafialho
4 years ago

Thanks @kjellr! I like them both but I believe the left-aligned quote with no background may work better for this theme.

@melchoyce
3 years ago

@melchoyce
3 years ago

#6 @melchoyce
3 years ago

  • Keywords has-patch added; needs-design removed

#7 @desrosj
3 years ago

  • Milestone changed from Future Release to 5.8

I'm going to move this to 5.8. But, if they are ready sooner we can move this to 5.7.1 (or if that's not realistic, please do move this back Future Release).

We can also release an update detached from a specific WordPress release as we did in December.

@onemaggie
3 years ago

@onemaggie
3 years ago

#8 @onemaggie
3 years ago

Updated this with escaped strings and urls and proper formatting

This ticket was mentioned in Slack in #core-themes by kjell. View the logs.


3 years ago

@ryelle
3 years ago

#10 @ryelle
3 years ago

Updated patch to load the patterns & fix an issue with the quote pattern. I don't like that the quote pattern is using a heading block, would it be possible to do the same with a paragraph block? I can try that out later/tomorrow.

#11 @ryelle
3 years ago

  • Owner set to ryelle
  • Resolution set to fixed
  • Status changed from new to closed

In 51033:

Bundled Themes: Introduce block patterns for Twenty Twelve.

Props beafialho, kjellr, melchoyce, onemaggie.
Fixes #51105.

This ticket was mentioned in Slack in #core-themes by kjell. View the logs.


3 years ago

#13 @milana_cap
3 years ago

  • Keywords needs-dev-note needs-codex added

#14 @sabernhardt
2 months ago

Follow-up: #61004

The 'Left-aligned Image and Paragraph' pattern's sentence that begins with "Pityful" had a typo correction in [57987], but would anyone have an objection to removing that sentence? The paragraph length would be 84 words instead of 93 (it seems to be the end of a 200-word sample).

Note: See TracTickets for help on using tickets.