#51315 closed task (blessed) (fixed)
Update mediaelement.js
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | External Libraries | Keywords: | has-patch needs-testing commit |
Focuses: | Cc: |
Description
Version 4.2.16 is now available.
Attachments (1)
Change History (10)
#2
@
4 years ago
- Keywords has-patch added; needs-patch removed
I have uploaded initial patch. @desrosj how to test if latest version is redacted or not?
#3
follow-up:
↓ 4
@
4 years ago
how to test if latest version is redacted or not?
I'm not sure I understand the question. Can you rephrase?
For future reference:
- Full list of changes released since core updated the library: https://github.com/mediaelement/mediaelement/compare/4.2.12...4.2.16
- MediaElements changelog detailing changes: https://github.com/mediaelement/mediaelement/blob/master/changelog.md
#4
in reply to:
↑ 3
@
4 years ago
Replying to desrosj:
how to test if latest version is redacted or not?
I'm not sure I understand the question. Can you rephrase?
It's probably about whether the version bundled with WP has any modifications to it, or is just a copy from upstream.
I think we include unmodified copy, but might be worth double-checking.
#5
@
4 years ago
- Keywords needs-testing added
Previously: #46681
As far as I have seen, it's a direct copy without any modifications. This patch needs testing across browsers.
#6
@
4 years ago
- Keywords commit added
- Owner set to desrosj
- Status changed from new to assigned
Looking at the recent changes in the release notes, it seems that only minor bug fixes and typo/link URL corrections have been made. I'll give this a final review this week and get it committed so that it can be tested.
#7
@
4 years ago
I wanted to document the weirdness that I just noticed in case anyone stumbles upon the same thing in the future.
In [46436], MediaElementJS was updated to 4.2.13. However, mejs.version
was not bumped prior to tagging the 4.2.13 release, so it's value remained at 4.2.12
. When I linked to the comparison between versions above in comment:3, I examined mejs.version
when choosing the version to compare 4.2.16 with.
This caused some inconsistencies in the diff comparisons and it took me a while to figure out where those inconsistencies were coming from.
A temporary shim was added in 4.2.13 along with a few other changes to fix some breaking bugs. These temporary fixes were then removed in 4.2.15. Because the shim was not present in 4.2.12 and Core was actually at 4.2.13, the original comparison posted above was missing the these deletions, but comparing trunk
after updating to 4.2.16 was showing them.
Initial patch.