Make WordPress Core

Opened 5 weeks ago

Closed 5 weeks ago

Last modified 5 weeks ago

#51332 closed enhancement (fixed)

Update URL of php.net date format table

Reported by: iandunn Owned by: SergeyBiryukov
Milestone: 5.6 Priority: low
Severity: minor Version:
Component: I18N Keywords: good-first-bug has-patch
Focuses: docs Cc:


There are a lot of /* translators: ... */ comments pointing people to https://www.php.net/date to reference the tokens that can be used in date( $format, ... ).

The table has moved from that page, and now lives at https://www.php.net/manual/en/datetime.format.php. If a translator doesn't know that already, they'll have to waste time figuring it out. Updating the links would remove that barrier.

Attachments (1)

51332.2.diff (15.3 KB) - added by Hareesh Pillai 5 weeks ago.

Download all attachments as: .zip

Change History (7)

#1 @iandunn
5 weeks ago

Er, they should probably be changed to https://www.php.net/manual/datetime.format.php instead of https://www.php.net/manual/en/datetime.format.php. I'm guessing php.net automatically redirects it to the user's locale.

#2 @SergeyBiryukov
5 weeks ago

  • Component changed from General to I18N
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.6

#3 @Hareesh Pillai
5 weeks ago

  • Keywords has-patch added; needs-patch removed

#4 @SergeyBiryukov
5 weeks ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#5 @SergeyBiryukov
5 weeks ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 48991:

Docs: Update the URL for PHP date formats table in translator comments.

Props hareesh-pillai, iandunn.
Fixes #51332.

#6 @SergeyBiryukov
5 weeks ago

In 48992:

Twenty Twenty: Update the URL for PHP date formats table in translator comments.

Follow-up to [48991].

Props hareesh-pillai, mukesh27, iandunn.
Fixes #51335. See #51332.

Note: See TracTickets for help on using tickets.