Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#51332 closed enhancement (fixed)

Update URL of php.net date format table

Reported by: iandunn Owned by: SergeyBiryukov
Priority: low Milestone: 5.6
Component: I18N Version:
Severity: minor Keywords: good-first-bug has-patch
Cc: Focuses: docs

Description

There are a lot of /* translators: ... */ comments pointing people to ​https://www.php.net/date to reference the tokens that can be used in date( $format, ... ).

The table has moved from that page, and now lives at ​https://www.php.net/manual/en/datetime.format.php. If a translator doesn't know that already, they'll have to waste time figuring it out. Updating the links would remove that barrier.

Attachments (1)

51332.2.diff​ (15.3 KB ) - added by Hareesh Pillai 6 years ago.

Download all attachments as: .zip

Change History (7)

#1 @iandunn
6 years ago

Er, they should probably be changed to https://www.php.net/manual/datetime.format.php instead of https://www.php.net/manual/en/datetime.format.php. I'm guessing php.net automatically redirects it to the user's locale.

#2 @SergeyBiryukov
6 years ago

  • Component General → I18N
  • Keywords needs-patch added
  • Milestone Awaiting Review → 5.6

#3 @Hareesh Pillai
6 years ago

  • Keywords has-patch added; needs-patch removed

#4 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Status new → reviewing

#5 @SergeyBiryukov
6 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 48991:

Docs: Update the URL for PHP date formats table in translator comments.

Props hareesh-pillai, iandunn.
Fixes #51332.

#6 @SergeyBiryukov
6 years ago

In 48992:

Twenty Twenty: Update the URL for PHP date formats table in translator comments.

Follow-up to [48991].

Props hareesh-pillai, mukesh27, iandunn.
Fixes #51335. See #51332.

Note: See TracTickets for help on using tickets.