WordPress.org

Make WordPress Core

Opened 11 months ago

Closed 10 months ago

Last modified 10 months ago

#51526 closed task (blessed) (fixed)

Import Twenty Twenty-One

Reported by: poena Owned by: desrosj
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch has-unit-tests commit dev-reviewed
Focuses: Cc:

Description

This is the reference ticket for the Twenty Twenty-One theme which is currently under development, ready for 5.6.

Initial development happened on GitHub:https://github.com/WordPress/twentytwentyone

Read the announcement post: https://make.wordpress.org/core/2020/09/23/introducing-twenty-twenty-one/

Attachments (1)

51526.diff (999.8 KB) - added by desrosj 11 months ago.

Download all attachments as: .zip

Change History (52)

#1 @joostdevalk
11 months ago

  • Milestone changed from Awaiting Review to 5.6
  • Type changed from defect (bug) to task (blessed)

#2 @Hareesh Pillai
11 months ago

We should remember to update the Tested up to value to 5.6 before releasing. Leaving this comment as a reminder.

This ticket was mentioned in PR #625 on WordPress/wordpress-develop by luminuu.


11 months ago

  • Keywords has-patch added

Adding trunk of Twenty Twenty-One default theme to the WordPress repository for Beta 1 of 5.6.

Trac ticket: https://core.trac.wordpress.org/ticket/51526

@desrosj
11 months ago

#4 @desrosj
11 months ago

  • Keywords commit added
  • Owner set to desrosj
  • Status changed from new to assigned

51526.diff has only very minor edits from the linked PR above:

  • Changed tested up to from 5.5 to 5.6.
  • Made some minor coding standards fixes (mostly stray commas or extra white space)
  • Added the package.json file.
  • Removed inline phpstan comments. This tooling is not yet used in Core, and to my knowledge has not been used in a default theme previously. Don't feel strongly about removing these, though. They can always be added on the next sync.
  • Changed an inline comment targeting eslint to jshint as that's what is used in Core currently (see #31823).
  • Removed a stray, extra </a> from the footer.
  • Fixed a typo in a translator comment.

#5 @desrosj
11 months ago

In 49216:

Bundled Themes: Import Twenty Twenty-One, the new default theme for WordPress 5.6.

Welcome to the bundled themes family!

Twenty Twenty-One is a blank canvas for your ideas, making the block editor your best brush.

Theme development to this point has taken place on GitHub. See: https://github.com/WordPress/twentytwentyone/.

Props poena, melchoyce, luminuu, elmastudio, bethsoderberg, williampatton, aristath, jffng, kjellr, jeffikus, audrasjb, fabiankaegy, mukesh27, dingo_d, kellylawrence, acosmin, whyisjake, metodiew, ryelle, nielslange, littlebigthing, mahesh901122, zebulan, kishanjasani, lukecavanagh, scruffian, abhijitrakas, utz119, sudoshreyansh, kau-boy, justinahinon, joostdevalk, bduclos, hareesh-pillai, mager19, rolfsiebers, webmigrates, sresok, guidooffermans, francina, marybaum, hareshlive, navanathbhosale, afercia, richtabor, joyously, sarahricker, nrqsnchz, glauberglauber, sabernhardt, kraftbj, ItsJonQ, joen, CTMartin0, decrecementofeliz, bhautikvirani.
See #51526.

#6 @desrosj
11 months ago

  • Keywords commit removed
  • Owner desrosj deleted

Leaving this open to facilitate syncing the theme throughout the release cycle.

#7 @desrosj
11 months ago

In 49217:

Bundled Themes: Add the theme screenshot for Twenty Twenty-One

Follow up to [49216].

See #51526.

This ticket was mentioned in PR #628 on WordPress/wordpress-develop by desrosj.


11 months ago

  • Keywords has-unit-tests added

#9 @desrosj
11 months ago

Linked to the wrong ticket in [49220], which makes Twenty Twenty-One the default theme for new installs going forward.

This ticket was mentioned in PR #632 on WordPress/wordpress-develop by luminuu.


11 months ago

Updated version of Twenty Twenty-One theme.

Trac ticket: https://core.trac.wordpress.org/ticket/51526

#13 @desrosj
11 months ago

In 49247:

Twenty Twenty: Import the latest changes from GitHub

For a full list of changes since [49216], see https://github.com/WordPress/twentytwentyone/compare/dfe141276ca4b856bbcd748f9da108ddad026c4c...trunk/.

Props poena, melchoyce, luminuu, aristath, jffng, ryelle, kishanjasani, rolfsiebers, sresok, desrosj.
See #51526.

#14 @desrosj
11 months ago

In 49250:

Twenty Twenty: Use jshint exclude statements instead of eslint.

Also, exclude the node_modules folder within twentytwentyone.

See #51526.

#15 @mukesh27
11 months ago

We should add License URI in style.css and ie.css

License URI: LICENSE

Replace to

License URI: http://www.gnu.org/licenses/gpl-2.0.html

#16 @poena
11 months ago

@mukesh27 Development is still happening on Github, do you mind opening an issue? https://github.com/WordPress/twentytwentyone/

This ticket was mentioned in PR #663 on WordPress/wordpress-develop by luminuu.


11 months ago

#19 @desrosj
11 months ago

In 49320:

Twenty Twenty-One: Import the latest changes for 5.6 beta 2.

For a full list of changes since beta 1, see https://github.com/WordPress/twentytwentyone/compare/9e34dca...e580895.

Props poena, melchoyce, luminuu, aristath, justinahinon, jffng, ryelle, kishanjasani, rolfsiebers.
See #51526.

#20 @prbot
11 months ago

desrosj commented on PR #663:

Tanks @luminuu! Merged into core in https://core.trac.wordpress.org/changeset/49320.

This ticket was mentioned in PR #667 on WordPress/wordpress-develop by carolinan.


11 months ago

Trac ticket:
https://core.trac.wordpress.org/ticket/51526

Now contributors since last commit:
bph

#22 @desrosj
11 months ago

In 49330:

Twenty Twenty-One: Import the latest changes.

For a full list of changes since [49320], see https://github.com/WordPress/twentytwentyone/compare/461dcf9cd...5759e96.

Props poena, melchoyce, aristath, justinahinon, ryelle.
See #51526.

This ticket was mentioned in PR #682 on WordPress/wordpress-develop by luminuu.


11 months ago

Current state of Twenty Twenty-One with updates from the past week.

Trac ticket: https://core.trac.wordpress.org/ticket/51526

#25 @desrosj
11 months ago

In 49478:

Bundled Themes: Sync Twenty Twenty-One with the latest changes from GitHub.

For a full list of changes since [49330], see https://github.com/WordPress/twentytwentyone/compare/5759e96...e7d5991.

Props poena, luminuu, ryelle, kjellr, aristath, justinahinon, felipeelia, joostdevalk.
See #51526.

This ticket was mentioned in PR #740 on WordPress/wordpress-develop by luminuu.


10 months ago

Updates of the Twenty Twenty-One theme for the Beta 4 release.

Trac ticket: https://core.trac.wordpress.org/ticket/51526

This ticket was mentioned in PR #742 on WordPress/wordpress-develop by desrosj.


10 months ago

Updated PR based off #740

Trac ticket: https://core.trac.wordpress.org/ticket/51526

#29 @desrosj
10 months ago

In 49574:

Twenty Twenty-One: Merge the latest changes changes from GitHub for Beta 4.

In addition to syncing the latest changes, this change also merges the theme’s .scss files and other related build tool configurations required to compile the theme’s CSS.

This will allow development of the theme to continue on Trac after 5.6 is released and the GitHub repository is archived.

For a full list of changes since [], see https://github.com/WordPress/twentytwentyone/compare/e7d5991...aa284fd.

Props poena, luminuu kjellr, aristath, justinahinon.
See #51526.

#30 @desrosj
10 months ago

In 49575:

Twenty Twenty-One: Convert inline ESLint comments to JSHint.

WordPress Core currently uses JSHint instead of ESlint.

See #51526.

#31 @desrosj
10 months ago

In 49576:

Twenty Twenty-One: Ignore .css.map files.

These are generated when Sass is compiled, but should never be committed.

See #51526.

#32 @desrosj
10 months ago

In 49577:

Twenty Twenty-One: Ignore the node_modules folder in SVN.

[49576] mistakenly partially reverted [49250].

See #51526.

#33 @desrosj
10 months ago

Just some notes on the most recent sync for the future.

The sentence casing as discussed above.

  • I've added the Sass related files to trunk . These are required in order to build the CSS after the GitHub repository has been archived (which happens shortly after release), and should be included in syncs going forward.
  • To ensure these build tasks continue to work, I've also merged the StyleLint related files required. Ideally, this should be adjusted in the future to use whatever CSS linting tools Core uses. Core does not currently have one set up, so I think this is fine for now.
  • I've removed the wp-env dependency present in the GitHub repository. I was experiencing compatibility issues with NodeJS 14.x, which is the new LTS version. trunk uses lts/* to define the version of NodeJS to use in the .nvmrc file, so all themes should be able to perform Node related tasks using that version. Everything else seemed to work fine. The WP Docker Environment included in trunk should be used for local environments anyway.
  • I also took liberty and converted all strings from Title Case to Sentence case. This is the recommendation for strings in Core (though it needs to be documented somewhere more prominent in the handbook).

#34 @desrosj
10 months ago

In 49578:

Twenty Twenty-One: Use consistent casing in strings.

This converts strings using Title Case to sentence case, which is currently preferred for consistency (see discussions on #40244).

Also included is the replacement of an escaped apostrophe with &#8217;, which is also preferred per the Internationalization guidelines.

See #51526.

#35 @prbot
10 months ago

desrosj commented on PR #742:

Merged into Core.

This ticket was mentioned in PR #749 on WordPress/wordpress-develop by luminuu.


10 months ago

Twenty Twenty-One theme updated for RC1.

Trac ticket: https://core.trac.wordpress.org/ticket/51526

#38 @desrosj
10 months ago

In 49633:

Twenty Twenty-One: Sync the latest changes for 5.6 RC1.

For a full list of changes since [49574-49577], see https://github.com/WordPress/twentytwentyone/compare/aa284fd...trunk.

Props poena, luminuu, kjellr, ryelle, aristath.
See #51526.

#40 @desrosj
10 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

I'm going to close this out for now. If an additional sync is needed to address issues discovered during RC, we can reopen.

This ticket was mentioned in PR #781 on WordPress/wordpress-develop by luminuu.


10 months ago

Update Twenty Twenty-One theme for RC-2

Trac ticket: https://core.trac.wordpress.org/ticket/51526

This ticket was mentioned in PR #781 on WordPress/wordpress-develop by luminuu.


10 months ago

Update Twenty Twenty-One theme for RC-2

Trac ticket: https://core.trac.wordpress.org/ticket/51526

#44 @desrosj
10 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Looks like we'll have an additional sync before RC2 later today!

#45 @desrosj
10 months ago

In 49726:

Twenty Twenty-One: Sync the latest changes for 5.6 RC2.

This will be the final sync from GitHub before placing that repository into read-only mode. All further changes should now flow entirely through Trac.

For a full list of changes since [49633], see https://github.com/WordPress/twentytwentyone/compare/1d5a895...53acd9b.

Props poena, luminuu, kjellr, ryelle, allancole, melchoyce, felipeelia, aljullu, kebbet, chaton666, Clorith, mkaz, ingereck, paaljoachim.
See #51526.

#46 @desrosj
10 months ago

  • Keywords commit dev-feedback added

This ticket was mentioned in Slack in #core by desrosj. View the logs.


10 months ago

This ticket was mentioned in Slack in #core-committers by hellofromtonya. View the logs.


10 months ago

#49 @SergeyBiryukov
10 months ago

  • Keywords dev-reviewed added; dev-feedback removed

[49726] looks good to backport.

#50 @desrosj
10 months ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from reopened to closed

In 49728:

Twenty Twenty-One: Sync the latest changes for 5.6 RC2.

This will be the final sync from GitHub before placing that repository into read-only mode. All further changes should now flow entirely through Trac.

For a full list of changes since [49633], see https://github.com/WordPress/twentytwentyone/compare/1d5a895...53acd9b.

Props poena, luminuu, kjellr, ryelle, allancole, melchoyce, felipeelia, aljullu, kebbet, chaton666, Clorith, mkaz, ingereck, paaljoachim.
Reviewed by desrosj, SergeyBiryukov.
Merges [49726] to the 5.6 branch.
Fixes #51526.

Note: See TracTickets for help on using tickets.