#51526 closed task (blessed) (fixed)
Import Twenty Twenty-One
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch has-unit-tests commit dev-reviewed |
Focuses: | Cc: |
Description
This is the reference ticket for the Twenty Twenty-One theme which is currently under development, ready for 5.6.
Initial development happened on GitHub:https://github.com/WordPress/twentytwentyone
Read the announcement post: https://make.wordpress.org/core/2020/09/23/introducing-twenty-twenty-one/
Attachments (1)
Change History (52)
#1
@
6 months ago
- Milestone changed from Awaiting Review to 5.6
- Type changed from defect (bug) to task (blessed)
This ticket was mentioned in PR #625 on WordPress/wordpress-develop by luminuu.
6 months ago
- Keywords has-patch added
Adding trunk of Twenty Twenty-One default theme to the WordPress repository for Beta 1 of 5.6.
Trac ticket: https://core.trac.wordpress.org/ticket/51526
#4
@
6 months ago
- Keywords commit added
- Owner set to desrosj
- Status changed from new to assigned
51526.diff has only very minor edits from the linked PR above:
- Changed tested up to from
5.5
to5.6
. - Made some minor coding standards fixes (mostly stray commas or extra white space)
- Added the
package.json
file. - Removed inline phpstan comments. This tooling is not yet used in Core, and to my knowledge has not been used in a default theme previously. Don't feel strongly about removing these, though. They can always be added on the next sync.
- Changed an inline comment targeting
eslint
tojshint
as that's what is used in Core currently (see #31823). - Removed a stray, extra
</a>
from the footer. - Fixed a typo in a translator comment.
#6
@
6 months ago
- Keywords commit removed
- Owner desrosj deleted
Leaving this open to facilitate syncing the theme throughout the release cycle.
This ticket was mentioned in PR #628 on WordPress/wordpress-develop by desrosj.
6 months ago
- Keywords has-unit-tests added
#9
@
6 months ago
Linked to the wrong ticket in [49220], which makes Twenty Twenty-One the default theme for new installs going forward.
#10
@
6 months ago
desrosj commented on PR #628:
Merged into core in https://core.trac.wordpress.org/changeset/49220.
#11
@
6 months ago
desrosj commented on PR #625:
Merged into Core in https://core.trac.wordpress.org/changeset/49216.
This ticket was mentioned in PR #632 on WordPress/wordpress-develop by luminuu.
6 months ago
Updated version of Twenty Twenty-One theme.
Trac ticket: https://core.trac.wordpress.org/ticket/51526
#15
@
6 months ago
We should add License URI
in style.css and ie.css
License URI: LICENSE
Replace to
License URI: http://www.gnu.org/licenses/gpl-2.0.html
#16
@
6 months ago
@mukesh27 Development is still happening on Github, do you mind opening an issue? https://github.com/WordPress/twentytwentyone/
#17
@
6 months ago
https://github.com/WordPress/twentytwentyone/issues/626 issue reported on GitHub
This ticket was mentioned in PR #663 on WordPress/wordpress-develop by luminuu.
6 months ago
Trac ticket: https://core.trac.wordpress.org/ticket/51526
Ping @desrosj
#20
@
6 months ago
desrosj commented on PR #663:
Tanks @luminuu! Merged into core in https://core.trac.wordpress.org/changeset/49320.
This ticket was mentioned in PR #667 on WordPress/wordpress-develop by carolinan.
6 months ago
Trac ticket:
https://core.trac.wordpress.org/ticket/51526
Now contributors since last commit:
bph
#23
@
6 months ago
desrosj commented on PR #667:
Merged into WordPress Core in https://core.trac.wordpress.org/changeset/49330.
This ticket was mentioned in PR #682 on WordPress/wordpress-develop by luminuu.
5 months ago
Current state of Twenty Twenty-One with updates from the past week.
Trac ticket: https://core.trac.wordpress.org/ticket/51526
#26
@
5 months ago
desrosj commented on PR #682:
Thank you! Merged into Core in https://core.trac.wordpress.org/changeset/49478.
This ticket was mentioned in PR #740 on WordPress/wordpress-develop by luminuu.
5 months ago
Updates of the Twenty Twenty-One theme for the Beta 4 release.
Trac ticket: https://core.trac.wordpress.org/ticket/51526
This ticket was mentioned in PR #742 on WordPress/wordpress-develop by desrosj.
5 months ago
Updated PR based off #740
Trac ticket: https://core.trac.wordpress.org/ticket/51526
#33
@
5 months ago
Just some notes on the most recent sync for the future.
The sentence casing as discussed above.
- I've added the Sass related files to trunk . These are required in order to build the CSS after the GitHub repository has been archived (which happens shortly after release), and should be included in syncs going forward.
- To ensure these build tasks continue to work, I've also merged the StyleLint related files required. Ideally, this should be adjusted in the future to use whatever CSS linting tools Core uses. Core does not currently have one set up, so I think this is fine for now.
- I've removed the
wp-env
dependency present in the GitHub repository. I was experiencing compatibility issues with NodeJS 14.x, which is the new LTS version.trunk
useslts/*
to define the version of NodeJS to use in the.nvmrc
file, so all themes should be able to perform Node related tasks using that version. Everything else seemed to work fine. The WP Docker Environment included in trunk should be used for local environments anyway. - I also took liberty and converted all strings from Title Case to Sentence case. This is the recommendation for strings in Core (though it needs to be documented somewhere more prominent in the handbook).
This ticket was mentioned in PR #749 on WordPress/wordpress-develop by luminuu.
5 months ago
Twenty Twenty-One theme updated for RC1.
Trac ticket: https://core.trac.wordpress.org/ticket/51526
#39
@
5 months ago
desrosj commented on PR #749:
Thank you! Merged in https://core.trac.wordpress.org/changeset/49633.
#40
@
5 months ago
- Resolution set to fixed
- Status changed from assigned to closed
I'm going to close this out for now. If an additional sync is needed to address issues discovered during RC, we can reopen.
#41
@
5 months ago
hellofromtonya commented on PR #632:
Merged in changeset https://core.trac.wordpress.org/changeset/49216
This ticket was mentioned in PR #781 on WordPress/wordpress-develop by luminuu.
4 months ago
Update Twenty Twenty-One theme for RC-2
Trac ticket: https://core.trac.wordpress.org/ticket/51526
This ticket was mentioned in PR #781 on WordPress/wordpress-develop by luminuu.
4 months ago
Update Twenty Twenty-One theme for RC-2
Trac ticket: https://core.trac.wordpress.org/ticket/51526
#44
@
4 months ago
- Resolution fixed deleted
- Status changed from closed to reopened
Looks like we'll have an additional sync before RC2 later today!
This ticket was mentioned in Slack in #core by desrosj. View the logs.
4 months ago
This ticket was mentioned in Slack in #core-committers by hellofromtonya. View the logs.
4 months ago
#49
@
4 months ago
- Keywords dev-reviewed added; dev-feedback removed
[49726] looks good to backport.
#50
@
4 months ago
- Owner set to desrosj
- Resolution set to fixed
- Status changed from reopened to closed
In 49728:
#51
@
4 months ago
hellofromtonya commented on PR #781:
Merged in changeset https://core.trac.wordpress.org/changeset/49726
We should remember to update the
Tested up to
value to 5.6 before releasing. Leaving this comment as a reminder.