WordPress.org

Make WordPress Core

Opened 15 months ago

Last modified 9 days ago

#40244 assigned enhancement

Inconsistent casing in the list table select filters

Reported by: afercia Owned by: bhargavbhandari90
Milestone: 5.0 Priority: normal
Severity: normal Version: 4.7.4
Component: Administration Keywords: has-screenshots good-first-bug has-patch
Focuses: ui Cc:

Description

In the various admin screens with list tables (posts, pages, media, comments, users...) a toolbar on the top displays some <select> elements to filter the lists by different criteria.

The default option sometimes uses title casing, sometimes not. Using always the same casing would be an easy fix and a minor, but nice, UI enhancement.

Worth mentioning title casing is mainly an English thing. In many other languages just the first letter in a title or label is uppercase. This is a minor thing and probably can be handled by translations. However, while I'd generally agree to use title case for English titles and labels, I'm not sure it makes sense for the select options.

Some screenshots:

Posts screen: All dates and All Categories (see also Bulk Actions)

https://cldup.com/KXQKxL6CwG.png

Media Library screen: All media items and All dates

https://cldup.com/bYFVoEqabr.png

Comments screen: All comment types

https://cldup.com/cYY4EwHZjw.png

Users screen: Change role to...

https://cldup.com/CgiL5MCx8X.png

Haven't checked the network screens, there are probably some other cases around.

Given most of them don't use title casing, I'd propose to standardise on this.

Attachments (3)

40244.patch (3.5 KB) - added by bhargavbhandari90 14 months ago.
40244.2.patch (4.5 KB) - added by rcutmore 13 months ago.
Fix additional inconsistent casing and relocate patch to root directory
40244.3.patch (4.4 KB) - added by manojlovic 10 days ago.

Download all attachments as: .zip

Change History (13)

#1 @welcher
15 months ago

  • Keywords needs-patch added

#2 @bhargavbhandari90
14 months ago

  • Keywords has-patch added; needs-patch removed

#3 @bhargavbhandari90
14 months ago

  • Version set to 4.7.4

#4 @bhargavbhandari90
14 months ago

May be there are more strings like this.

@rcutmore
13 months ago

Fix additional inconsistent casing and relocate patch to root directory

#5 @rcutmore
13 months ago

I added 40244.2.patch to fix a couple additional strings with inconsistent casing. These are on the grid view of the Media Library.

#6 @DrewAPicture
12 months ago

  • Owner set to bhargavbhandari90
  • Status changed from new to assigned

Assigning ownership to mark the good-first-bug as "claimed".

#7 @webzunft
7 weeks ago

I looked for more occurrences of similar strings using regex All [a-z] and didn’t find any that are relevant here. I also checked the code around the fixed strings and didn’t find similar texts that need adjustment of the casing.

#8 @SergeyBiryukov
7 weeks ago

  • Milestone changed from Awaiting Review to 5.0

@manojlovic
10 days ago

#9 @manojlovic
10 days ago

I updated patch and checked all lists, including Multisite screens.

#10 @jeremyfelt
9 days ago

Thank you for the patches @manojlovic, @rcutmore, and @bhargavbhandari90.

Re-reading the ticket description, I'm wondering if we should discuss the switch to title case vs sentence case a bit more. @afercia mentioned that "title casing is mainly an English thing". How much does this impact translations? It may make sense to use sentence casing for consistency.

Note: See TracTickets for help on using tickets.