WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 6 months ago

#51744 closed enhancement (fixed)

Allow MariaDB to be used with the local Docker environment

Reported by: desrosj Owned by: desrosj
Milestone: 5.7 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch commit
Focuses: Cc:

Description

MariaDB Docker images are available in the Docker Hub, and seems that they can be easily substituted for the MySQL ones that the local Docker environment currently uses.

This would unblock #30462, which aims to test multiple database types/versions (though Travis made this really difficult.

Attachments (3)

51744.diff (785 bytes) - added by desrosj 7 months ago.
image.png (16.5 KB) - added by davidbaumwald 7 months ago.
Test with mariadb
51744.2.diff (1.1 KB) - added by desrosj 6 months ago.

Download all attachments as: .zip

Change History (6)

@desrosj
7 months ago

#1 @desrosj
7 months ago

  • Keywords needs-testing added

51744.diff is a proof of concept that introduces LOCAL_DB_TYPE and accepts mysql or mariadb.

LOCAL_MYSQL is now a bit too specific, but if it is renamed (maybe to LOCAL_DB_VERSION), there should probably be a check that copies the value to the new one.

@davidbaumwald
7 months ago

Test with mariadb

@desrosj
6 months ago

#2 @desrosj
6 months ago

  • Keywords commit added; needs-testing removed
  • Milestone changed from Future Release to 5.7

51744.2.diff changes LOCAL_MYSQL to LOCAL_DB_VERSION.

#3 @desrosj
6 months ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 49836:

Build/Test Tools: Support the use of MariaDB in the local Docker environment.

In addition to MySQL, WordPress also supports MariaDB for databases. This makes changes to the local Docker environment to allow MariaDB to be used instead, if desired.

The LOCAL_DB_TYPE environment variable will now be used to determine which type of database container to use. This will default to mysql, but will also accept mariadb.

The LOCAL_MYSQL environment variable (which previously held the version of MySQL to use) has been replaced with the new, more generic LOCAL_DB_VERSION environment variable.

This change will make it possible to perform automated testing on a wider array of supported database types and versions.

Props davidbaumwald.
Fixes #51744. See #30462.

Note: See TracTickets for help on using tickets.