WordPress.org

Make WordPress Core

Opened 2 months ago

Last modified 12 days ago

#51770 reviewing enhancement

Add unit tests for WP_Http_Cookie

Reported by: andizer Owned by: SergeyBiryukov
Milestone: 5.7 Priority: normal
Severity: normal Version: 5.2
Component: HTTP API Keywords: has-patch has-unit-tests needs-refresh
Focuses: Cc:

Description

The class wasn't covered yet. We added these during contributor day at Yoast.

Worked on this together with:
https://profiles.wordpress.org/andizer
https://profiles.wordpress.org/herregroen
https://profiles.wordpress.org/lopo

Attachments (1)

acf2d6ebfe0accfbe74bed562c53b4ea3b3dbbb2.patch (14.0 KB) - added by andizer 2 months ago.
Added unittests for WP_Http_Cookie

Download all attachments as: .zip

Change History (4)

@andizer
2 months ago

Added unittests for WP_Http_Cookie

#1 @hellofromTonya
2 months ago

  • Version changed from trunk to 5.2

Moving off trunk to match the last @since in the class.

#2 @SergeyBiryukov
2 months ago

  • Milestone changed from Awaiting Review to 5.7
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#3 @hellofromTonya
12 days ago

  • Keywords needs-refresh added

Looking at the PHP Test standard, the methods should be broken up in individual test files:

As a rule, a single test class should not contain tests for more than one function/method.

How should the individual public method test files be organized? I've asked this question in slack.

Note: See TracTickets for help on using tickets.