Opened 4 years ago
Last modified 3 years ago
#51770 reviewing enhancement
Add unit tests for WP_Http_Cookie
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | Future Release | Priority: | normal |
| Severity: | normal | Version: | 5.2 |
| Component: | HTTP API | Keywords: | has-patch has-unit-tests |
| Focuses: | Cc: |
Description
The class wasn't covered yet. We added these during contributor day at Yoast.
Worked on this together with:
https://profiles.wordpress.org/andizer
https://profiles.wordpress.org/herregroen
https://profiles.wordpress.org/lopo
Attachments (1)
Change History (7)
#1
@
4 years ago
- Version changed from trunk to 5.2
Moving off trunk to match the last @since in the class.
#2
@
4 years ago
- Milestone changed from Awaiting Review to 5.7
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
#3
@
4 years ago
- Milestone changed from 5.7 to 5.8
5.7 Beta 1 is happening in about 25 minutes. Ran out of time to get this ticket into the release. Punting to 5.8.
If any maintainer or committer feels this can be resolved in time, or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.
This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.
4 years ago
This ticket was mentioned in Slack in #core by chaion07. View the logs.
3 years ago
#6
@
3 years ago
- Milestone changed from 5.8 to Future Release
Thanks for taking the time to write these, @andizer! Apologies that it did not get reviewed in 5.8 either.
I'm going to punt this as today is the cut off for enhancement and feature request tickets. However, test improvements can be made up until the RC phase of the release cycle.
If a committer is able to review this before then, feel free to move back to 5.8 and give it the attention it deserves. For now, I'll punt this to Future Release to prevent repeated punting.
Added unittests for WP_Http_Cookie