WordPress.org

Make WordPress Core

Opened 10 months ago

Last modified 4 months ago

#51770 reviewing enhancement

Add unit tests for WP_Http_Cookie

Reported by: andizer Owned by: SergeyBiryukov
Milestone: Future Release Priority: normal
Severity: normal Version: 5.2
Component: HTTP API Keywords: has-patch has-unit-tests
Focuses: Cc:

Description

The class wasn't covered yet. We added these during contributor day at Yoast.

Worked on this together with:
https://profiles.wordpress.org/andizer
https://profiles.wordpress.org/herregroen
https://profiles.wordpress.org/lopo

Attachments (1)

acf2d6ebfe0accfbe74bed562c53b4ea3b3dbbb2.patch (14.0 KB) - added by andizer 10 months ago.
Added unittests for WP_Http_Cookie

Download all attachments as: .zip

Change History (7)

@andizer
10 months ago

Added unittests for WP_Http_Cookie

#1 @hellofromTonya
10 months ago

  • Version changed from trunk to 5.2

Moving off trunk to match the last @since in the class.

#2 @SergeyBiryukov
10 months ago

  • Milestone changed from Awaiting Review to 5.7
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#3 @hellofromTonya
8 months ago

  • Milestone changed from 5.7 to 5.8

5.7 Beta 1 is happening in about 25 minutes. Ran out of time to get this ticket into the release. Punting to 5.8.

If any maintainer or committer feels this can be resolved in time, or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


7 months ago

This ticket was mentioned in Slack in #core by chaion07. View the logs.


4 months ago

#6 @desrosj
4 months ago

  • Milestone changed from 5.8 to Future Release

Thanks for taking the time to write these, @andizer! Apologies that it did not get reviewed in 5.8 either.

I'm going to punt this as today is the cut off for enhancement and feature request tickets. However, test improvements can be made up until the RC phase of the release cycle.

If a committer is able to review this before then, feel free to move back to 5.8 and give it the attention it deserves. For now, I'll punt this to Future Release to prevent repeated punting.

Note: See TracTickets for help on using tickets.