Opened 4 years ago
Closed 4 years ago
#51968 closed defect (bug) (fixed)
Remove Appveyor
Reported by: | desrosj | Owned by: | desrosj |
---|---|---|---|
Milestone: | 5.7 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Appveyor was added to core in [44594] to ensure npm install
and related build scripts continue to work with every commit. Since TravisCI did not support Windows at the time, there was a need for an additional service.
Now that there is a GitHub Action workflow for this testing, the Appveyor configuration can be removed.
This change should be backported to all branches that have an Appveyor configuration file after the GitHub Action is backported.
Attachments (1)
Change History (12)
#1
@
4 years ago
On a second look, only 5.6 branch has the workflows/verify-npm-on-windows.yml
CI task, so it looks like we either need to port all Github actions CI tasks to those versions, or only remove Appveyor on 5.6 and keep it for other versions.
#2
@
4 years ago
- Keywords has-patch commit added
After the GitHub Actions workflows landed in trunk
, the plan was to let them sit for a bit before backporting to older branches. I think we're just about there after the test reporter and Slack messages are set up (see #50401 for that).
I think we can remove this from trunk
for now, and then I'll return here to backport after the Actions workflows are backported.
Delete button go brrrrrrrr :) Happy to see WordPress CI getting more leaner. The attached patch is just deleting the file, and it appears there are no other references to the file. It's probably just easier to delete the file and remove github hooks by a repository administrator; no props necessary. Thank you.