WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 5 months ago

#51968 closed defect (bug) (fixed)

Remove Appveyor

Reported by: desrosj Owned by: desrosj
Milestone: 5.7 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch commit
Focuses: Cc:

Description

Appveyor was added to core in [44594] to ensure npm install and related build scripts continue to work with every commit. Since TravisCI did not support Windows at the time, there was a need for an additional service.

Now that there is a GitHub Action workflow for this testing, the Appveyor configuration can be removed.

This change should be backported to all branches that have an Appveyor configuration file after the GitHub Action is backported.

Attachments (1)

51968-remove-appveyor.patch (931 bytes) - added by ayeshrajans 5 months ago.
Delete button go brrrrrrrr :) Happy to see WordPress CI getting more leaner. The attached patch is just deleting the file, and it appears there are no other references to the file. It's probably just easier to delete the file and remove github hooks by a repository administrator; no props necessary. Thank you.

Download all attachments as: .zip

Change History (12)

@ayeshrajans
5 months ago

Delete button go brrrrrrrr :) Happy to see WordPress CI getting more leaner. The attached patch is just deleting the file, and it appears there are no other references to the file. It's probably just easier to delete the file and remove github hooks by a repository administrator; no props necessary. Thank you.

#1 @ayeshrajans
5 months ago

On a second look, only 5.6 branch has the workflows/verify-npm-on-windows.yml CI task, so it looks like we either need to port all Github actions CI tasks to those versions, or only remove Appveyor on 5.6 and keep it for other versions.

#2 @desrosj
5 months ago

  • Keywords has-patch commit added

After the GitHub Actions workflows landed in trunk, the plan was to let them sit for a bit before backporting to older branches. I think we're just about there after the test reporter and Slack messages are set up (see #50401 for that).

I think we can remove this from trunk for now, and then I'll return here to backport after the Actions workflows are backported.

#3 @desrosj
5 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 49779:

Build/Test Tools: Remove the Appveyor configuration file.

Appveyor was added to Core in [44594] to ensure that NPM and the WordPress build tools continue to work correctly on Windows systems as changes are made. Using an additional service for this was required at the time, TravisCI did not support testing on Windows.

[49162] introduced a GitHub Action workflow that performed the same testing. Since all automated testing is moving to GitHub Actions, using Appveyor is no longer necessary, and it’s preferable to have all automated testing in one location as much as possible.

Props ayeshrajans.
Fixes #51968.

#4 @desrosj
5 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening to backport.

#5 @desrosj
5 months ago

In 49809:

Build/Test Tools: Remove the Appveyor configuration file.

Appveyor was added to Core in [44594] to ensure that NPM and the WordPress build tools continue to work correctly on Windows systems as changes are made. Using an additional service for this was required at the time, TravisCI did not support testing on Windows.

[49162] introduced a GitHub Action workflow that performed the same testing. Since all automated testing is moving to GitHub Actions, using Appveyor is no longer necessary, and it’s preferable to have all automated testing in one location as much as possible.

Props ayeshrajans.
Merges [49779] to the 5.6 branch.
See #51968.

#6 @desrosj
5 months ago

In 49810:

Build/Test Tools: Remove the Appveyor configuration file.

Appveyor was added to Core in [44594] to ensure that NPM and the WordPress build tools continue to work correctly on Windows systems as changes are made. Using an additional service for this was required at the time, TravisCI did not support testing on Windows.

[49162] introduced a GitHub Action workflow that performed the same testing. Since all automated testing is moving to GitHub Actions, using Appveyor is no longer necessary, and it’s preferable to have all automated testing in one location as much as possible.

Props ayeshrajans.
Merges [49779] to the 5.5 branch.
See #51968.

#7 @desrosj
5 months ago

In 49811:

Build/Test Tools: Remove the Appveyor configuration file.

Appveyor was added to Core in [44594] to ensure that NPM and the WordPress build tools continue to work correctly on Windows systems as changes are made. Using an additional service for this was required at the time, TravisCI did not support testing on Windows.

[49162] introduced a GitHub Action workflow that performed the same testing. Since all automated testing is moving to GitHub Actions, using Appveyor is no longer necessary, and it’s preferable to have all automated testing in one location as much as possible.

Props ayeshrajans.
Merges [49779] to the 5.4 branch.
See #51968.

#8 @desrosj
5 months ago

In 49812:

Build/Test Tools: Remove the Appveyor configuration file.

Appveyor was added to Core in [44594] to ensure that NPM and the WordPress build tools continue to work correctly on Windows systems as changes are made. Using an additional service for this was required at the time, TravisCI did not support testing on Windows.

[49162] introduced a GitHub Action workflow that performed the same testing. Since all automated testing is moving to GitHub Actions, using Appveyor is no longer necessary, and it’s preferable to have all automated testing in one location as much as possible.

Props ayeshrajans.
Merges [49779] to the 5.3 branch.
See #51968.

#9 @desrosj
5 months ago

In 49813:

Build/Test Tools: Remove the Appveyor configuration file.

Appveyor was added to Core in [44594] to ensure that NPM and the WordPress build tools continue to work correctly on Windows systems as changes are made. Using an additional service for this was required at the time, TravisCI did not support testing on Windows.

[49162] introduced a GitHub Action workflow that performed the same testing. Since all automated testing is moving to GitHub Actions, using Appveyor is no longer necessary, and it’s preferable to have all automated testing in one location as much as possible.

Props ayeshrajans.
Merges [49779] to the 5.2 branch.
See #51968.

#10 @desrosj
5 months ago

In 49814:

Build/Test Tools: Remove the Appveyor configuration file.

Appveyor was added to Core in [44594] to ensure that NPM and the WordPress build tools continue to work correctly on Windows systems as changes are made. Using an additional service for this was required at the time, TravisCI did not support testing on Windows.

[49162] introduced a GitHub Action workflow that performed the same testing. Since all automated testing is moving to GitHub Actions, using Appveyor is no longer necessary, and it’s preferable to have all automated testing in one location as much as possible.

Props ayeshrajans.
Merges [49779] to the 5.1 branch.
See #51968.

#11 @desrosj
5 months ago

  • Keywords fixed-major removed
  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.