![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 6 years ago
Closed 5 years ago
#52029 closed defect (bug) (fixed)
Twenty Twenty-One: missing styles for button[type=submit]
| Reported by: | slaFFik | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.7 |
| Component: | Bundled Theme | Version: | 5.6 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | ui, css |
Description
2021 theme has default styles for input[type=submit] but it does not have those same styles for button[type=submit].
So some plugins, that use button to submit the form on the front-end, are having CSS issues with 2021.
Attachments (3)
Change History (11)
#1
@
6 years ago
- Summary Twenty Twenty-One: → Twenty Twenty-One: missing styles for button[type=submit]
#5
@
6 years ago
The button styles are found here:
https://github.com/WordPress/wordpress-develop/blob/master/src/wp-content/themes/twentytwentyone/assets/sass/05-blocks/button/_style.scss
and
I recommend changing this only after #51927 which updates the buttons.
-There will always be themes that are unstyled, so it is safest for plugins to style their own elements.
This ticket was mentioned in Slack in #core-themes by poena. View the logs.
6 years ago
Note:
See TracTickets
for help on using tickets.
It looks like https://github.com/WordPress/wordpress-develop/blob/master/src/wp-content/themes/twentytwentyone/assets/sass/04-elements/forms.scss should be modified to include additional styles for
button[type=submit]same asinput[type=submit].Not sure what to do with:
button[type=clear]buttonwithout defined type - most likely apply the same asbutton[type=button]andbutton[type=submit].