WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#52065 closed defect (bug) (fixed)

Media gallery: 'Align' and 'Link To' fields missing from 'Insert from URL'

Reported by: noisysocks Owned by: desrosj
Priority: normal Milestone: 5.6.1
Component: Media Version:
Severity: normal Keywords: has-patch commit fixed-major
Cc: Focuses:

Description

Reported here: ​https://wordpress.org/support/topic/is-it-just-me-or-wtf-add-media-gutenberg-disabled/

  1. Disable the block editor.
  2. Create a new post.
  3. Click 'Add Media'.
  4. Select 'Insert from URL'.
  5. Type in a URL to an image.

Expected result: The 'Align' and 'Link To' fields should appear at the bottom of the form.
Actual result: Only the 'Alternative Text' and 'Caption' fields appear.

Attachments (2)

insert-from-url-5.5.png​ (641.7 KB ) - added by noisysocks 6 years ago.
'Insert from URL' in WP 5.5
insert-from-url-5.6.png​ (626.1 KB ) - added by noisysocks 6 years ago.
'Insert from URL' in WP 5.6

Download all attachments as: .zip

Change History (10)

@noisysocks
6 years ago

'Insert from URL' in WP 5.5

@noisysocks
6 years ago

'Insert from URL' in WP 5.6

#1 @noisysocks
6 years ago

I ran git bisect and found that this is a regression introduced by r49101 cc. @azaozz.

#2 @noisysocks
6 years ago

  • Milestone Awaiting Review → 5.6.1

This ticket was mentioned in ​PR #815 on ​WordPress/wordpress-develop by ​mukeshpanchal27.
6 years ago #3

  • Keywords has-patch added; needs-patch removed

Trac ticket: https://core.trac.wordpress.org/ticket/52065

#4 @mukesh27
6 years ago

Hi there!

I reproduce same issue and fix the issue on ​PR #815 patch.

#5 @azaozz
6 years ago

Ahh, good catch @noisysocks and @mukesh27! I tested the media modal quite a bit but didn't see that (wish we had more tests there) :)

#6 @SergeyBiryukov
6 years ago

  • Keywords commit fixed-major added

This was fixed in [49804], but the comment didn't make it here.

Marking for backporting to the 5.6 branch.

#7 @desrosj
6 years ago

  • Owner set to desrosj
  • Resolution → fixed
  • Status new → closed

In 49820:

Media: Fix the template for the "Align" and "Link To" fields in the media modal when inserting an image from URL.

Props noisysocks, mukesh27.
Merges [49804] to the 5.6 branch.
Fixes #52065.

#8 @sabernhardt
6 years ago

#52340 was marked as a duplicate.

Note: See TracTickets for help on using tickets.