Context Navigation

← Previous Ticket
Next Ticket →

#52317 closed enhancement (fixed)

REST API: Improve JSON Schema validation error codes

Reported by:	TimothyBlynJacobs	Owned by:	TimothyBlynJacobs
Priority:	normal	Milestone:	5.7
Component:	REST API	Version:	4.7
Severity:	normal	Keywords:	has-patch commit dev-reviewed
Cc:		Focuses:

Description

rest_validate_value_from_schema currently has a mix of error codes in use. Some are nice and specific like rest_invalid_date but most are the unhelpful rest_invalid_param. Right now, this doesn't have much of an impact since the individual errors from rest_validate_value_from_schema are not returned to clients. But in preparation for #46191, we should take this opportunity to make them more useful, as after it may be more of a BC break.

Change History (7)

This ticket was mentioned in PR #875 on WordPress/wordpress-develop by TimothyBJacobs.

6 years ago #1

Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/52317

#2 @TimothyBlynJacobs
5 years ago

Owner set to TimothyBlynJacobs
Resolution → fixed
Status new → closed

In 50007:

REST API: Add more specific error codes for schema validation.

Previously, the majority of JSON Schema validation errors returned a generic rest_invalid_param error code. In preparation for #46191, where the underlying validation error code will be exposed, this commit adds specific error codes for each failure scenario.

Fixes #52317.

TimothyBJacobs commented on PR #875:

5 years ago #3

Merged in https://github.com/WordPress/wordpress-develop/commit/15c8166424a2f20419d0397783867f276e178ce5.

#4 @TimothyBlynJacobs
5 years ago

Resolution fixed
Status closed → reopened

Reopening to backport r50461 to 5.7.

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.

5 years ago

#6 @desrosj
5 years ago

Keywords commit dev-reviewed added

[50461] looks good to backport.

#7 @SergeyBiryukov
5 years ago

Resolution → fixed
Status reopened → closed

In 50470:

REST API: Correct error code for the maxItems keyword.

Follow-up to [50007].

Props TimothyBlynJacobs.
Reviewed by desrosj, SergeyBiryukov.
Merges [50461] to the 5.7 branch.
Fixes #52317.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#52317 closed enhancement (fixed)

REST API: Improve JSON Schema validation error codes

Description

Change History (7)

This ticket was mentioned in ​PR #875 on ​WordPress/wordpress-develop by ​TimothyBJacobs. 6 years ago #1

#2 @TimothyBlynJacobs 5 years ago

​TimothyBJacobs commented on ​PR #875: 5 years ago #3

#4 @TimothyBlynJacobs 5 years ago

This ticket was mentioned in ​Slack in #core by hellofromtonya. ​View the logs. 5 years ago

#6 @desrosj 5 years ago

#7 @SergeyBiryukov 5 years ago