WordPress.org

Make WordPress Core

Opened 6 weeks ago

Closed 4 weeks ago

#52334 closed task (blessed) (fixed)

Update WordPress packages for 5.7 Beta 1

Reported by: noisysocks Owned by: noisysocks
Milestone: 5.7 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch
Focuses: Cc:

Description

The @wordpress npm packages need to be updated prior to Beta 1. I'll do this in two parts so that there's less rushing in the days prior to Beta 1:

  1. Update packages as of Gutenberg 9.8 on Jan 20.
  2. Update packages as of Gutenberg 9.9 on Feb 1.

Change History (13)

This ticket was mentioned in PR #887 on WordPress/wordpress-develop by noisysocks.


6 weeks ago

  • Keywords has-patch added

Update WordPress packages ahead of WP 5.7.

To do:

https://core.trac.wordpress.org/ticket/52334

#2 @prbot
6 weeks ago

noisysocks commented on PR #887:

Need https://github.com/constancecchen/object-fit-polyfill to publish src to npm so that we can vendor it.

Spoke to @ajlende about this. He's going to open a PR which adds src to the npm package.

#3 @prbot
6 weeks ago

noisysocks commented on PR #887:

Fix failing font-size-picker.test.js test.

This is the only remaining failure I get when I run Gutenberg E2E tests against this branch:

  ● Font Size Picker › should apply a custom font size using the font size input

    expect(received).toMatchSnapshot()

    Snapshot name: `Font Size Picker should apply a custom font size using the font size input 1`

    - Snapshot  - 1
    + Received  + 1

    - 
    + 
      <p style="font-size:23px">Paragraph to be made "small"</p>
      

      76 | 		// Ensure content matches snapshot.
      77 | 		const content = await getEditedPostContent();
    > 78 | 		expect( content ).toMatchSnapshot();
         | 		                  ^
      79 | 	} );
      80 | 
      81 | 	it( 'should reset a named font size using the reset button', async () => {

      at Object.<anonymous> (specs/editor/various/font-size-picker.test.js:78:21)
          at runMicrotasks (<anonymous>)

This seemingly relates to https://github.com/WordPress/gutenberg/pull/27083. I'm having a hard time figuring out if px should be appended in Core or if that's a FSE-related change that should remain in the plugin only. Do you know, @jorgefilipecosta ? If it should be changed in Core, where should that change happen?

#4 @prbot
6 weeks ago

noisysocks commented on PR #887:

Need https://github.com/constancecchen/object-fit-polyfill to publish src to npm so that we can vendor it.

Spoke to @ajlende about this. He's going to open a PR which adds src to the npm package.

https://github.com/constancecchen/object-fit-polyfill/pull/59

#5 @prbot
6 weeks ago

noisysocks commented on PR #887:

Unsure about whether to port i18n change in client-assets.php. Have asked in WordPress/gutenberg#28279.

Preference is to land Core-46089 as a proper fix for this. Will land the workaround that Gutenberg has if that can't be done for 5.7.

#6 @prbot
5 weeks ago

noisysocks commented on PR #887:

Fix failing font-size-picker.test.js test.

...
This seemingly relates to WordPress/gutenberg#27083. I'm having a hard time figuring out if px should be appended in Core or if that's a FSE-related change that should remain in the plugin only. Do you know, @jorgefilipecosta ? If it should be changed in Core, where should that change happen?

It looks like in the plugin it sets the attribute to 23px because there is a px in editorSettings.__experimentalFeatures.global.typography.fontSizes. In my mind it makes sense to leave this as is (no px) because we do not want __experimentalFeatures to be added to Core.

This ticket was mentioned in Slack in #core by noisysocks. View the logs.


5 weeks ago

#8 @prbot
5 weeks ago

noisysocks commented on PR #887:

Only one small issue in the editor: typing /freeform doesn't bring up the Classic block as expected (this works in Gutenberg 9.8)

Hmm... this seems okay to me?

https://i0.wp.com/user-images.githubusercontent.com/612155/106077673-1281ff80-6166-11eb-893c-822b4807e713.gif

#9 @noisysocks
5 weeks ago

In 50048:

Editor: Update @wordpress npm packages

Update @wordpress npm packages to the latest published versions. This means that
the block editor includes functionality that exists in Gutenberg 9.8.

See #52334.
Props isabel_brison.

#10 in reply to: ↑ description @noisysocks
5 weeks ago

  • Keywords has-patch removed

Replying to noisysocks:

  1. Update packages as of Gutenberg 9.8 on Jan 20.

[50048] does this.

  1. Update packages as of Gutenberg 9.9 on Feb 1.

This is next. Waiting for Gutenberg 9.9 RC to be published at the end of this week.

#11 @noisysocks
5 weeks ago

In 50066:

Editor: Move blocks/classic -> blocks/freeform

Moves src/wp-includes/blocks/classic to src/wp-includes/blocks/freeform. This
reflects the 'classic' block being renamed to 'freeform'.

Follows [50048].
See #52334.

This ticket was mentioned in PR #963 on WordPress/wordpress-develop by noisysocks.


4 weeks ago

  • Keywords has-patch added

Update WordPress packages ahead of WP 5.7. This is everything that is included in Gutenberg 9.9.

I have checked git diff release/9.8 release/9.9 lib for changes and ran Gutenberg E2E tests against Core.

https://core.trac.wordpress.org/ticket/52334

#13 @noisysocks
4 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 50137:

Editor: Update @wordpress npm packages

Update @wordpress npm packages to the latest published versions. This means that
the block editor includes functionality that exists in Gutenberg 9.9.

Fixes #52334.

Note: See TracTickets for help on using tickets.