Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#52374 closed defect (bug) (fixed)

Twenty Twenty-One: Menu button has the wrong colors

Reported by:	poena	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	5.7
Component:	Bundled Theme	Version:
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:	css

Description (last modified by SergeyBiryukov)

An unintended side effect of the updated button styles in #51927 was that the menu button changed color.

In trunk, the current menu button has a dark grey background color
var(--global--color-primary); and a transparent text.

As per design, the background should be transparent and the text should be dark grey.

Attachments (3)

menu-button-trunk.png (6.1 KB ) - added by poena 5 years ago.: Menu button with incorrect colors
52374.patch (8.4 KB ) - added by poena 5 years ago.: Override specificity from default button styles by using the button ID.
with-patch.png (30.6 KB ) - added by jeroenrotty 5 years ago.: Mobile menu button with correct styling

Download all attachments as: .zip

Change History (9)

@poena
5 years ago

Attachment menu-button-trunk.png added

Menu button with incorrect colors

@poena
5 years ago

Attachment 52374.patch added

Override specificity from default button styles by using the button ID.

#1 @poena
5 years ago

Keywords needs-testing added

#2 @SergeyBiryukov
5 years ago

Description modified (diff)

#3 @SergeyBiryukov
5 years ago

Owner set to SergeyBiryukov
Resolution → fixed
Status new → closed

Twenty Twenty-One: Correct colors for the Menu button.

As per design, the background should be transparent and the text should be dark grey, not vice versa.

Follow-up to [49987].

Props poena.
Fixes #52374. See #51927.

@jeroenrotty
5 years ago

Attachment with-patch.png added

Mobile menu button with correct styling

#4 @jeroenrotty
5 years ago

Tested the patch with @rolfsiebers and the patch worked as intended, see screenshot.

This ticket was mentioned in Slack in #core by francina. View the logs.

5 years ago

#6 @hellofromTonya
5 years ago

Keywords has-patch added; needs-testing removed

Note: See TracTickets for help on using tickets.

Download in other formats: