WordPress.org

Make WordPress Core

Opened 10 months ago

Last modified 10 months ago

#52378 new defect (bug)

Network admin site action confirmation leads to expired link screen when referer not available

Reported by: sanchothefat Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Networks and Sites Keywords:
Focuses: multisite Cc:

Description

Sorry for the wordy summary.

In the network admin on a multisite installation the sites list shows links for actions like "Archive", "Deactivate" etc. that take you to an interstitial page to confirm the action.

This interstitial page outputs a simple form with the action being confirmed, nonce values and so on filled in, including a field for _wp_http_referer which is then used in the check_admin_referer() call.

The referrer field is built using the following code:

<?php
<input type="hidden" name="_wp_http_referer" value="<?php echo esc_attr( wp_get_referer() ); ?>" />

In infrastructure where WordPress is behind a load balancer and for caching reasons the referer header is not passed to the web server this breaks because the output from wp_get_referer() is empty. Clicking confirm will result in a wp_die() screen from wp_nonce_ays() saying the link has expired.

This can be worked around by filtering network_admin_url where the link contains action=confirm to add _wp_http_referer as a query parameter but ideally the referer should be passed in the query string by default.

Given there is a workaround this is low priority, and I can't see anywhere else in WP affected by this currently either.

Change History (2)

#1 @johnbillion
10 months ago

  • Component changed from General to Networks and Sites
  • Focuses multisite added

#2 @sanchothefat
10 months ago

I found another related issue with the "Network Enable" and "Network Disable" action links for themes in the network admin too. If the referrer header is missing they cause an infinite redirect loop also. These links are generated using wp_nonce_url() which is not filterable so the workaround using the network_admin_url filter is not an option.

Note: See TracTickets for help on using tickets.