WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#52502 closed defect (bug) (fixed)

Twenty Twenty-One, Twenty and Nineteen: Syncronise ignored files between git and svn.

Reported by: peterwilsoncc's profile peterwilsoncc Owned by: peterwilsoncc's profile peterwilsoncc
Milestone: 5.7 Priority: normal
Severity: normal Version: 5.7
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Currently the SVN config for themes are set to ignore the following files:

.map files

  • 2021 (due to change in #52377)

node_modules directory

  • 2021
  • 2020
  • 2019

These are not included in the .gitignore file and should probably be synced up.

Attachments (1)

52502.diff​ (470 bytes) - added by peterwilsoncc 4 years ago.

Download all attachments as: .zip

Change History (4)

#1 @peterwilsoncc
4 years ago

  • Summary changed from Twenty Twenty-One: Syncronise ignored files between git and svn. to Twenty Twenty-One, Twenty and Nineteen: Syncronise ignored files between git and svn.

@peterwilsoncc
4 years ago

#2 @peterwilsoncc
4 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 5.7
  • Owner set to peterwilsoncc
  • Status changed from new to assigned

52502.diff​ ignores the directories:

  • /src/wp-content/themes/twentynineteen/node_modules
  • /src/wp-content/themes/twentytwentyone/node_modules
  • /src/wp-content/themes/twentytwenty/node_modules

Moving to 5.7 to avoid potential for mistakes on a PR/with a git diff.

#52377 will need to be committed prior to this patch.

#3 @peterwilsoncc
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 50349:

Bundled Themes: Synchronise .gitignore with themes' svn ignore property.

Add node_modules directories within Twenty Twenty-One, Twenty Twenty and Twenty Nineteen to the .gitignore file.

Fixes #52502.

Note: See TracTickets for help on using tickets.