Make WordPress Core

Opened 3 years ago

Last modified 15 months ago

#52501 reopened defect (bug)

Bad date format in data picker, depends on time format settings

Reported by: marektp's profile MarekTP Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 5.6.1
Component: Quick/Bulk Edit Keywords: needs-patch
Focuses: Cc:

Description (last modified by SergeyBiryukov)

Datepicker in publish area, and in quick edit, depends on time format.

In europe is usual format dd.mm.yyyy, it works with setting of time format is setted to 'g:i A'.
After change to 24 hour format ('G:i'/'H:i') is datepicker setted to mm-dd-yyyy
https://test.olsavsky.cz/dp.jpg ('Únor' is 'February' in CS).

Thank You

Attachments (1)

WordPress-times.png (194.6 KB) - added by oglekler 16 months ago.
Time Format in WordPress

Download all attachments as: .zip

Change History (23)

#1 @SergeyBiryukov
3 years ago

  • Component changed from Formatting to Editor
  • Description modified (diff)

#2 @MarekTP
3 years ago

Addition: WooCommerce edit ignores every combinations, still formated in month-day-year order. :-(

#4 @sabernhardt
3 years ago

  • Component changed from Editor to Quick/Bulk Edit

If you want to discuss the block editor part, please follow the GitHub issue.

In quick edit, however, the month comes before day in French (fr-FR) yet not in Czech (cs-CZ). So we could use this ticket for investigating that.

This ticket was mentioned in Slack in #core by abhanonstopnews. View the logs.


2 years ago

#6 @webcommsat
2 years ago

Highlighted in component bug scrub. To request #polyglots feedback in testing based on last update by @sabernhardt.

@marybaum to request feedback in polyglots channel about the behavior and whether it needs a patch.

Last edited 2 years ago by webcommsat (previous) (diff)

This ticket was mentioned in Slack in #core by abhanonstopnews. View the logs.


22 months ago

#8 @webcommsat
18 months ago

  • Resolution set to invalid
  • Status changed from new to closed

No feedback as yet from polyglots. To be rehighlighted in #polyglots for feedback to help progress this ticket.

#9 @webcommsat
18 months ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

#10 @oglekler
16 months ago

This ticket needs to be discussed with the Polyglots team and will be followed by @oglekler

Attendees of the component review: @marybaum @webcommsat @oglekler @nalininonstopnewsuk

Last edited 16 months ago by oglekler (previous) (diff)

This ticket was mentioned in Slack in #core by oglekler. View the logs.


16 months ago

@oglekler
16 months ago

Time Format in WordPress

#12 follow-up: @oglekler
16 months ago

I tested this on WP version 6.1.2 (6.1.1) and 4.8.21 with Czech and output is different due to how this string is translated in the current WordPress version. Due to different translation abilities (see the collage above) it can be inconsistent and differ from place to place. But it looks like Time and Date formats in General Settings are more for the site frontend, and Data piker is using 24-hours time anyway.

So, possible improvements are:

  • unify date format and translation abilities for the whole site to be consistent
  • in case if Date Format and Time Format are not supposed to be applied directly in the admin, make it clear that date format in General Settings is for the frontend

Right now if for some language format is not as it should be it needs to be checked for the correct translation and if existing translation abilities are not covering needs for localization, requirements could be collected to make improvements.

Related ticket: #42394

Dear Polyglots, please participate in this issue discussion. It cannot be handled without you. Thanks in advance.

This ticket was mentioned in Slack in #polyglots by oglekler. View the logs.


16 months ago

This ticket was mentioned in Slack in #core by oglekler. View the logs.


16 months ago

This ticket was mentioned in Slack in #polyglots by kharisulistiyo. View the logs.


16 months ago

This ticket was mentioned in Slack in #polyglots by oglekler. View the logs.


16 months ago

#17 @Mamaduka
16 months ago

Every option in General Settings affects the whole WP; changing the language changes it everywhere. I think it makes sense to treat the time formats the same way.

#18 in reply to: ↑ 12 @SergeyBiryukov
15 months ago

Replying to oglekler:

But it looks like Time and Date formats in General Settings are more for the site frontend

That is indeed the case.

Just linking to some related tickets: #2601, #3767, #23227, #26736, #30716, #30864, #35525, #39285, #48063, #54333.

Per the changes in [35811] and comments like comment:2:ticket:2601 or comment:15:ticket:30864, it looks like there was a consensus previously that the Date Format and Time Format settings should only affect the front end of the site. The internal date formats in the admin can be different, depending on the context they are used in.

in case if Date Format and Time Format are not supposed to be applied directly in the admin, make it clear that date format in General Settings is for the frontend

I think this would be the preferred approach here.

This ticket was mentioned in Slack in #polyglots by spiraltee. View the logs.


15 months ago

#20 @NekoJonez
15 months ago

I personally think that the format of the date should be consistent everywhere. I mean, why should the date be different for users when they do their work in the back end?

This ticket was mentioned in Slack in #polyglots by oglekler. View the logs.


15 months ago

This ticket was mentioned in Slack in #polyglots by spiraltee. View the logs.


15 months ago

Note: See TracTickets for help on using tickets.